Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticache/rep_group: Remove availability zones and other deprecated parameters #31008

Merged
merged 6 commits into from
May 2, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Apr 26, 2023

Description

Relations

Closes #18439
Closes #18441
Closes #22903

References

Output from Acceptance Testing

Failure unrelated to these changes

% make t T='TestAccElastiCacheReplicationGroup_ClusterMode_basic|TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup|TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown|TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp|TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown|TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp|TestAccElastiCacheReplicationGroup_enableAtRestEncryption|TestAccElastiCacheReplicationGroup_enableAuthTokenTransitEncryption|TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic|TestAccElastiCacheReplicationGroup_tagWithOtherModification|TestAccElastiCacheReplicationGroup_updateAuthToken|TestAccElastiCacheReplicationGroup_useCMKKMSKeyID' K=elasticache P=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 3 -run='TestAccElastiCacheReplicationGroup_ClusterMode_basic|TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup|TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown|TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp|TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown|TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp|TestAccElastiCacheReplicationGroup_enableAtRestEncryption|TestAccElastiCacheReplicationGroup_enableAuthTokenTransitEncryption|TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic|TestAccElastiCacheReplicationGroup_tagWithOtherModification|TestAccElastiCacheReplicationGroup_updateAuthToken|TestAccElastiCacheReplicationGroup_useCMKKMSKeyID'  -timeout 180m
=== RUN   TestAccElastiCacheReplicationGroup_updateAuthToken
=== PAUSE TestAccElastiCacheReplicationGroup_updateAuthToken
=== RUN   TestAccElastiCacheReplicationGroup_ClusterMode_basic
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterMode_basic
=== RUN   TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp
=== RUN   TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown
=== RUN   TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup
=== RUN   TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp
=== RUN   TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown
=== RUN   TestAccElastiCacheReplicationGroup_enableAuthTokenTransitEncryption
=== PAUSE TestAccElastiCacheReplicationGroup_enableAuthTokenTransitEncryption
=== RUN   TestAccElastiCacheReplicationGroup_enableAtRestEncryption
=== PAUSE TestAccElastiCacheReplicationGroup_enableAtRestEncryption
=== RUN   TestAccElastiCacheReplicationGroup_useCMKKMSKeyID
=== PAUSE TestAccElastiCacheReplicationGroup_useCMKKMSKeyID
=== RUN   TestAccElastiCacheReplicationGroup_tagWithOtherModification
=== PAUSE TestAccElastiCacheReplicationGroup_tagWithOtherModification
=== RUN   TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic
=== PAUSE TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic
=== CONT  TestAccElastiCacheReplicationGroup_updateAuthToken
=== CONT  TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown
--- PASS: TestAccElastiCacheReplicationGroup_updateAuthToken (1039.85s)
=== CONT  TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown (2188.47s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown (2521.79s)
=== CONT  TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup
=== CONT  TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleUp (2655.21s)
=== CONT  TestAccElastiCacheReplicationGroup_useCMKKMSKeyID
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup (2171.31s)
=== CONT  TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp (2179.21s)
=== CONT  TestAccElastiCacheReplicationGroup_tagWithOtherModification
--- PASS: TestAccElastiCacheReplicationGroup_useCMKKMSKeyID (792.83s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_basic (1049.49s)
=== CONT  TestAccElastiCacheReplicationGroup_enableAtRestEncryption
--- PASS: TestAccElastiCacheReplicationGroup_enableAtRestEncryption (837.54s)
=== CONT  TestAccElastiCacheReplicationGroup_enableAuthTokenTransitEncryption
--- PASS: TestAccElastiCacheReplicationGroup_enableAuthTokenTransitEncryption (2189.62s)
=== NAME  TestAccElastiCacheReplicationGroup_tagWithOtherModification
    replication_group_test.go:1793: Step 2/2 error: Error running apply: exit status 1
        
        Error: updating ElastiCache Replication Group (tf-acc-test-8460758980054193126): InvalidReplicationGroupState: Replication group must be in available state to modify.
        	status code: 400, request id: fe639b9f-13ee-452a-a606-18c74ac55a79
        
          with aws_elasticache_replication_group.test,
          on terraform_plugin_test.tf line 8, in resource "aws_elasticache_replication_group" "test":
           8: resource "aws_elasticache_replication_group" "test" {
        
--- FAIL: TestAccElastiCacheReplicationGroup_tagWithOtherModification (914.19s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic (3798.17s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	3831.602s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/elasticache Issues and PRs that pertain to the elasticache service. service/iam Issues and PRs that pertain to the iam service. service/networkmanager Issues and PRs that pertain to the networkmanager service. service/vpc Issues and PRs that pertain to the vpc service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels Apr 26, 2023
@YakDriver YakDriver changed the base branch from main to prerelease/5.x April 26, 2023 22:03
@YakDriver YakDriver added this to the v5.0.0 milestone Apr 26, 2023
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/vpc Issues and PRs that pertain to the vpc service. tags Pertains to resource tagging. service/networkmanager Issues and PRs that pertain to the networkmanager service. provider Pertains to the provider itself, rather than any interaction with AWS. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) service/iam Issues and PRs that pertain to the iam service. labels Apr 26, 2023
@YakDriver YakDriver added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. tags Pertains to resource tagging. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) and removed size/L Managed by automation to categorize the size of a PR. labels Apr 26, 2023
@YakDriver YakDriver removed provider Pertains to the provider itself, rather than any interaction with AWS. tags Pertains to resource tagging. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels Apr 26, 2023
@YakDriver YakDriver changed the title elasticache/rep_group: Remove availability zones elasticache/rep_group: Remove availability zones and other deprecated parameters May 1, 2023
@YakDriver YakDriver merged commit 24c4ed9 into prerelease/5.x May 2, 2023
45 checks passed
@YakDriver YakDriver deleted the d-elasticache-rep-group-remove-azs branch May 2, 2023 02:03
github-actions bot pushed a commit that referenced this pull request May 2, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

danielw-aws pushed a commit to danielw-aws/terraform-provider-aws that referenced this pull request May 31, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
1 participant