Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GlobalSettings resource for Amazon Chime SDK voice connector #31365

Merged

Conversation

Prateeksharma13
Copy link
Contributor

Description

Adding GlobalSettings resource for Amazon Chime SDK voice connector
This will help users to set the s3 bucket destination for CallDetailRecords for voice connector calls.

Example terraform confiiguration:

resource "aws_chimesdkvoice_global_settings" "test" {
	voice_connector {
		cdr_bucket = "test-bucket-name"
    }
}

Relations

Closes #31362

References

https://docs.aws.amazon.com/chime-sdk/latest/APIReference/API_voice-chime_UpdateGlobalSettings.html
https://docs.aws.amazon.com/chime-sdk/latest/APIReference/API_voice-chime_GetGlobalSettings.html
https://docs.aws.amazon.com/chime-sdk/latest/APIReference/API_Operations_Amazon_Chime_SDK_Voice.html

Output from Acceptance Testing

make testacc TESTS=TestAccChimeSdkVoiceGlobalSettings PKG=chimesdkvoice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chimesdkvoice/... -v -count 1 -parallel 20 -run='TestAccChimeSdkVoiceGlobalSettings'  -timeout 180m
=== RUN   TestAccChimeSdkVoiceGlobalSettings_basic
=== PAUSE TestAccChimeSdkVoiceGlobalSettings_basic
=== CONT  TestAccChimeSdkVoiceGlobalSettings_basic
--- PASS: TestAccChimeSdkVoiceGlobalSettings_basic (34.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chimesdkvoice	39.044s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels May 12, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 12, 2023
@AdamTylerLynch AdamTylerLynch added the partner Contribution from a partner. label May 16, 2023
@jar-b jar-b self-assigned this Jun 6, 2023
- use diags in crud handlers
- handle eventual consistency on create
- simplify flex functions
- change voice_connector to TypeList
- handle out of band settings changes
- add _disappears, _update tests
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jun 6, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=chimesdkvoice TESTS=TestAccChimeSDKVoiceGlobalSettings_serial
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chimesdkvoice/... -v -count 1 -parallel 20 -run='TestAccChimeSDKVoiceGlobalSettings_serial'  -timeout 180m
=== RUN   TestAccChimeSDKVoiceGlobalSettings_serial
=== PAUSE TestAccChimeSDKVoiceGlobalSettings_serial
=== CONT  TestAccChimeSDKVoiceGlobalSettings_serial
=== RUN   TestAccChimeSDKVoiceGlobalSettings_serial/update
=== RUN   TestAccChimeSDKVoiceGlobalSettings_serial/basic
=== RUN   TestAccChimeSDKVoiceGlobalSettings_serial/disappears
--- PASS: TestAccChimeSDKVoiceGlobalSettings_serial (45.28s)
    --- PASS: TestAccChimeSDKVoiceGlobalSettings_serial/update (20.69s)
    --- PASS: TestAccChimeSDKVoiceGlobalSettings_serial/basic (13.05s)
    --- PASS: TestAccChimeSDKVoiceGlobalSettings_serial/disappears (11.53s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chimesdkvoice      48.436s

@jar-b jar-b merged commit 7617734 into hashicorp:main Jun 6, 2023
45 checks passed
@jar-b
Copy link
Member

jar-b commented Jun 6, 2023

Thanks for your contribution, @Prateeksharma13! 👏

@github-actions github-actions bot added this to the v5.2.0 milestone Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: Support GlobalSettings for Chime SDK Voice Connector
4 participants