Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ec2_client_vpn_network_association: Remove security_groups #31396

Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 12, 2023

Description

Removes the deprecated security_groups attribute.

Relations

Closes #31387.
Relates #22911.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccClientVPNEndpoint_serial/NetworkAssociation_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccClientVPNEndpoint_serial/NetworkAssociation_ -timeout 180m
=== RUN   TestAccClientVPNEndpoint_serial
=== PAUSE TestAccClientVPNEndpoint_serial
=== CONT  TestAccClientVPNEndpoint_serial
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_multipleSubnets
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_multipleSubnets
=== RUN   TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== PAUSE TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_basic
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears
=== CONT  TestAccClientVPNEndpoint_serial/NetworkAssociation_multipleSubnets
--- PASS: TestAccClientVPNEndpoint_serial (0.38s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_basic (794.14s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_multipleSubnets (856.67s)
    --- PASS: TestAccClientVPNEndpoint_serial/NetworkAssociation_disappears (898.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	903.882s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/vpnclient Issues and PRs that pertain to the vpnclient service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels May 12, 2023
@ewbankkit ewbankkit added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label May 12, 2023
@ewbankkit ewbankkit merged commit 69d74de into main May 12, 2023
39 of 40 checks passed
@ewbankkit ewbankkit deleted the remove-aws_ec2_client_vpn_network_association.security_groups branch May 12, 2023 22:28
@github-actions github-actions bot added this to the v5.0.0 milestone May 12, 2023
github-actions bot pushed a commit that referenced this pull request May 12, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

danielw-aws pushed a commit to danielw-aws/terraform-provider-aws that referenced this pull request May 31, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/vpnclient Issues and PRs that pertain to the vpnclient service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_ec2_client_vpn_network_association: Remove security_groups
1 participant