Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema type for vlan_id on aws_dx_connection #31480

Merged
merged 3 commits into from
May 30, 2023

Conversation

Maddog2050
Copy link
Contributor

Description

Fixes the schema type for vlan_id for aws_dx_connection so that null isn't returned.

Relations

Closes #29165

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/directconnect Issues and PRs that pertain to the directconnect service. needs-triage Waiting for first response or review from a maintainer. labels May 19, 2023
@Maddog2050 Maddog2050 marked this pull request as ready for review May 19, 2023 11:26
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 19, 2023
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label May 19, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDirectConnectConnectionDataSource_basic\|TestAccDirectConnectConnection_basic' PKG=directconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/directconnect/... -v -count 1 -parallel 20  -run=TestAccDirectConnectConnectionDataSource_basic\|TestAccDirectConnectConnection_basic -timeout 180m
=== RUN   TestAccDirectConnectConnectionDataSource_basic
=== PAUSE TestAccDirectConnectConnectionDataSource_basic
=== RUN   TestAccDirectConnectConnection_basic
=== PAUSE TestAccDirectConnectConnection_basic
=== CONT  TestAccDirectConnectConnectionDataSource_basic
=== CONT  TestAccDirectConnectConnection_basic
--- PASS: TestAccDirectConnectConnectionDataSource_basic (19.74s)
--- PASS: TestAccDirectConnectConnection_basic (22.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/directconnect	28.069s

@ewbankkit
Copy link
Contributor

@Maddog2050 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit added this to the v5.1.0 milestone May 19, 2023
@ewbankkit ewbankkit merged commit c0cce82 into hashicorp:main May 30, 2023
38 checks passed
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/directconnect Issues and PRs that pertain to the directconnect service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_dx_connection data-source reports vlan_id null
2 participants