aws_eip: deprecate vpc attribute

[johnsonaj]

Description

Relations

Closes #26714

References

Output from Acceptance Testing

$ make testacc TESTS="TestAccEC2EIP_basic|TestAccEC2EIP_noVPC|TestAccEC2EIP_disappears" PKG=ec2
                                                                                   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EIP_basic|TestAccEC2EIP_noVPC|TestAccEC2EIP_disappears'  -timeout 180m
--- PASS: TestAccEC2EIP_disappears (11.60s)
--- PASS: TestAccEC2EIP_noVPC (15.72s)
--- PASS: TestAccEC2EIP_basic (15.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	18.994s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[gdavison]

Will there we a follow-up PR to update aws_eip resources used in other service tests?

--- PASS: TestAccEC2EIP_disappears (22.62s)
--- PASS: TestAccEC2EIP_BYOIPAddress_default (24.51s)
--- PASS: TestAccEC2EIP_noVPC (26.63s)
--- PASS: TestAccEC2EIP_networkBorderGroup (26.66s)
--- PASS: TestAccEC2EIP_basic (27.47s)
--- PASS: TestAccEC2EIP_PublicIPv4Pool_default (27.67s)
--- PASS: TestAccEC2EIP_NetworkInterface_twoEIPsOneInterface (34.03s)
--- PASS: TestAccEC2EIP_networkInterface (36.04s)
--- PASS: TestAccEC2EIP_tags (48.45s)
--- PASS: TestAccEC2EIP_instance (86.77s)
--- PASS: TestAccEC2EIP_association (107.38s)
--- PASS: TestAccEC2EIP_Instance_notAssociated (123.28s)
--- PASS: TestAccEC2EIP_Instance_reassociate (125.37s)
--- PASS: TestAccEC2EIP_Instance_associatedUserPrivateIP (147.51s)

[gdavison]

Since this and vpc are both marked ForceNew, will it destroy an existing EIP if someone updates their config from vpc = true to domain = "vpc"?

[johnsonaj]

good call. It does not. I went ahead and added a test to verify

$ make testacc TESTS="TestAccEC2EIP_migrateVPCToDomain" PKG=ec2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EIP_migrateVPCToDomain'  -timeout 180m
--- PASS: TestAccEC2EIP_migrateVPCToDomain (30.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	34.189s

[johnsonaj]

@gdavison updated all the tests and examples that use aws_eip to domain = "vpc"

[github-actions]

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.