-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data source: aws_ecr_pull_through_cache_rule #31696
New data source: aws_ecr_pull_through_cache_rule #31696
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECRPullThroughCacheRuleDataSource_' PKG=ecr ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 2 -run=TestAccECRPullThroughCacheRuleDataSource_ -timeout 180m
=== RUN TestAccECRPullThroughCacheRuleDataSource_basic
=== PAUSE TestAccECRPullThroughCacheRuleDataSource_basic
=== CONT TestAccECRPullThroughCacheRuleDataSource_basic
--- PASS: TestAccECRPullThroughCacheRuleDataSource_basic (20.61s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecr 26.347s
@bschaatsbergen Thanks for the contribution 🎉 👏. |
Thank You @bschaatsbergen . Can't wait to get my hands on it and test it out! 🚀 |
Happy to help! |
This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Provides a new data source for the ECR Pull Through Cache Rule
Relations
Closes #31578
References
Output from Acceptance Testing