Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_redshiftserverless_namespace: Fix iam_roles diff #31749

Merged
merged 5 commits into from
Jun 2, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 2, 2023

Description

Prevents iam roles diffs once the namespace contains a workgroup.

Relations

Closes #26624.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRedshiftServerlessNamespace_' PKG=redshiftserverless ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 3  -run=TestAccRedshiftServerlessNamespace_ -timeout 180m
=== RUN   TestAccRedshiftServerlessNamespace_basic
=== PAUSE TestAccRedshiftServerlessNamespace_basic
=== RUN   TestAccRedshiftServerlessNamespace_defaultIAMRole
=== PAUSE TestAccRedshiftServerlessNamespace_defaultIAMRole
=== RUN   TestAccRedshiftServerlessNamespace_user
=== PAUSE TestAccRedshiftServerlessNamespace_user
=== RUN   TestAccRedshiftServerlessNamespace_tags
=== PAUSE TestAccRedshiftServerlessNamespace_tags
=== RUN   TestAccRedshiftServerlessNamespace_disappears
=== PAUSE TestAccRedshiftServerlessNamespace_disappears
=== RUN   TestAccRedshiftServerlessNamespace_withWorkgroup
=== PAUSE TestAccRedshiftServerlessNamespace_withWorkgroup
=== CONT  TestAccRedshiftServerlessNamespace_basic
=== CONT  TestAccRedshiftServerlessNamespace_tags
=== CONT  TestAccRedshiftServerlessNamespace_withWorkgroup
--- PASS: TestAccRedshiftServerlessNamespace_basic (45.52s)
=== CONT  TestAccRedshiftServerlessNamespace_user
--- PASS: TestAccRedshiftServerlessNamespace_tags (62.67s)
=== CONT  TestAccRedshiftServerlessNamespace_defaultIAMRole
--- PASS: TestAccRedshiftServerlessNamespace_defaultIAMRole (25.71s)
=== CONT  TestAccRedshiftServerlessNamespace_disappears
--- PASS: TestAccRedshiftServerlessNamespace_user (43.33s)
--- PASS: TestAccRedshiftServerlessNamespace_disappears (16.42s)
--- PASS: TestAccRedshiftServerlessNamespace_withWorkgroup (524.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless	530.487s

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRedshiftServerlessNamespace_' PKG=redshiftserverless ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 3  -run=TestAccRedshiftServerlessNamespace_ -timeout 180m
=== RUN   TestAccRedshiftServerlessNamespace_basic
=== PAUSE TestAccRedshiftServerlessNamespace_basic
=== RUN   TestAccRedshiftServerlessNamespace_defaultIAMRole
=== PAUSE TestAccRedshiftServerlessNamespace_defaultIAMRole
=== RUN   TestAccRedshiftServerlessNamespace_user
=== PAUSE TestAccRedshiftServerlessNamespace_user
=== RUN   TestAccRedshiftServerlessNamespace_tags
=== PAUSE TestAccRedshiftServerlessNamespace_tags
=== RUN   TestAccRedshiftServerlessNamespace_disappears
=== PAUSE TestAccRedshiftServerlessNamespace_disappears
=== CONT  TestAccRedshiftServerlessNamespace_basic
=== CONT  TestAccRedshiftServerlessNamespace_disappears
=== CONT  TestAccRedshiftServerlessNamespace_user
--- PASS: TestAccRedshiftServerlessNamespace_disappears (20.57s)
=== CONT  TestAccRedshiftServerlessNamespace_defaultIAMRole
--- PASS: TestAccRedshiftServerlessNamespace_user (46.90s)
=== CONT  TestAccRedshiftServerlessNamespace_tags
--- PASS: TestAccRedshiftServerlessNamespace_basic (47.65s)
--- PASS: TestAccRedshiftServerlessNamespace_defaultIAMRole (27.82s)
--- PASS: TestAccRedshiftServerlessNamespace_tags (51.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless	104.378s
@ewbankkit ewbankkit changed the title r/aws_redshiftserverless_namespace: Fix iam roles diff r/aws_redshiftserverless_namespace: Fix iam_roles diff Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 2, 2023
@ewbankkit ewbankkit merged commit f3e3775 into main Jun 2, 2023
38 checks passed
@ewbankkit ewbankkit deleted the b-aws_redshiftserverless_namespace.iam_roles branch June 2, 2023 21:58
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 2, 2023
github-actions bot pushed a commit that referenced this pull request Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_redshiftserverless_namespace iam_roles updates on every plan/apply
1 participant