Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transitgateway_connect_peer: add bgp ip attribute references #31752

Merged
merged 22 commits into from
Jun 6, 2023

Conversation

kurochan
Copy link
Contributor

@kurochan kurochan commented Jun 3, 2023

Description

Add some BGP IP attribute references to r/ec2_transit_gateway_connect_peer and d/ec2_transit_gateway_connect_peer.

Output from Acceptance Testing

Due to a permissions issue with an AWS account I own, I was unable to run the test properly.
The tests that should have been run are

$ make testacc TESTS=TestAccTransitGateway_serial PKG=ec2
$ make testacc TESTS=TestAccTransitGatewayDataSource_serial PKG=ec2

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/transitgateway Issues and PRs that pertain to the transitgateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jun 3, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 5, 2023
@github-actions github-actions bot added service/organizations Issues and PRs that pertain to the organizations service. service/ssm Issues and PRs that pertain to the ssm service. service/vpc Issues and PRs that pertain to the vpc service. size/L Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. service/ec2 Issues and PRs that pertain to the ec2 service. service/acm Issues and PRs that pertain to the acm service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/organizations Issues and PRs that pertain to the organizations service. service/ssm Issues and PRs that pertain to the ssm service. service/budgets Issues and PRs that pertain to the budgets service. service/iot Issues and PRs that pertain to the iot service. service/eks Issues and PRs that pertain to the eks service. service/fsx Issues and PRs that pertain to the fsx service. service/networkmanager Issues and PRs that pertain to the networkmanager service. service/meta service/ipam Issues and PRs that pertain to the ipam service. service/ds Issues and PRs that pertain to the ds service. service/logs Issues and PRs that pertain to the logs service. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. service/vpc Issues and PRs that pertain to the vpc service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. labels Jun 6, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransitGatewayDataSource_serial/ConnectPeer\|TestAccTransitGateway_serial/ConnectPeer/basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGatewayDataSource_serial/ConnectPeer\|TestAccTransitGateway_serial/ConnectPeer/basic -timeout 180m
=== RUN   TestAccTransitGatewayDataSource_serial
=== PAUSE TestAccTransitGatewayDataSource_serial
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGatewayDataSource_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGatewayDataSource_serial/ConnectPeer
=== RUN   TestAccTransitGatewayDataSource_serial/ConnectPeer/Filter
=== RUN   TestAccTransitGateway_serial/ConnectPeer
=== RUN   TestAccTransitGateway_serial/ConnectPeer/basic
=== RUN   TestAccTransitGatewayDataSource_serial/ConnectPeer/ID
--- PASS: TestAccTransitGateway_serial (718.39s)
    --- PASS: TestAccTransitGateway_serial/ConnectPeer (718.39s)
        --- PASS: TestAccTransitGateway_serial/ConnectPeer/basic (718.39s)
--- PASS: TestAccTransitGatewayDataSource_serial (1338.40s)
    --- PASS: TestAccTransitGatewayDataSource_serial/ConnectPeer (1338.40s)
        --- PASS: TestAccTransitGatewayDataSource_serial/ConnectPeer/Filter (715.87s)
        --- PASS: TestAccTransitGatewayDataSource_serial/ConnectPeer/ID (622.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1344.205s

@ewbankkit
Copy link
Contributor

@kurochan Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ac55de2 into hashicorp:main Jun 6, 2023
45 checks passed
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/transitgateway Issues and PRs that pertain to the transitgateway service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants