Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws_ecr_repository data source's most_recent_image_tags attribute #31757

Merged

Conversation

Mikopet
Copy link
Contributor

@Mikopet Mikopet commented Jun 4, 2023

Description

Just a quick fix for most_recent_image_tags in ecr_repository data source to give result with a single image in a repository

Output from Acceptance Testing

$ make testacc TESTS=TestAccECRRepositoryDataSource_ PKG=ecr

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 8 -run='TestAccECRRepositoryDataSource_'  -timeout 180m
=== RUN   TestAccECRRepositoryDataSource_basic
=== PAUSE TestAccECRRepositoryDataSource_basic
=== RUN   TestAccECRRepositoryDataSource_encryption
=== PAUSE TestAccECRRepositoryDataSource_encryption
=== RUN   TestAccECRRepositoryDataSource_nonExistent
=== PAUSE TestAccECRRepositoryDataSource_nonExistent
=== CONT  TestAccECRRepositoryDataSource_basic
=== CONT  TestAccECRRepositoryDataSource_nonExistent
=== CONT  TestAccECRRepositoryDataSource_encryption
--- PASS: TestAccECRRepositoryDataSource_nonExistent (5.06s)
--- PASS: TestAccECRRepositoryDataSource_basic (38.64s)
--- PASS: TestAccECRRepositoryDataSource_encryption (39.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        39.714s

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ecr Issues and PRs that pertain to the ecr service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Jun 4, 2023
@Mikopet Mikopet force-pushed the b-fix-ecr-repository-datasource-most-recent branch from fb8acb6 to f0707ca Compare June 4, 2023 11:38
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Mikopet 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 5, 2023
@ewbankkit ewbankkit self-assigned this Aug 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 11, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECRRepositoryDataSource_' PKG=ecr ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 2  -run=TestAccECRRepositoryDataSource_ -timeout 180m
=== RUN   TestAccECRRepositoryDataSource_basic
=== PAUSE TestAccECRRepositoryDataSource_basic
=== RUN   TestAccECRRepositoryDataSource_encryption
=== PAUSE TestAccECRRepositoryDataSource_encryption
=== RUN   TestAccECRRepositoryDataSource_nonExistent
=== PAUSE TestAccECRRepositoryDataSource_nonExistent
=== CONT  TestAccECRRepositoryDataSource_basic
=== CONT  TestAccECRRepositoryDataSource_nonExistent
--- PASS: TestAccECRRepositoryDataSource_nonExistent (4.40s)
=== CONT  TestAccECRRepositoryDataSource_encryption
--- PASS: TestAccECRRepositoryDataSource_basic (24.08s)
--- PASS: TestAccECRRepositoryDataSource_encryption (24.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	34.399s

@ewbankkit
Copy link
Contributor

@Mikopet Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7e8e161 into hashicorp:main Aug 11, 2023
31 checks passed
@github-actions github-actions bot added this to the v5.13.0 milestone Aug 11, 2023
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Aug 18, 2023
@github-actions
Copy link

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ecr Issues and PRs that pertain to the ecr service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants