Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource and data source aws_quicksight_theme #31900

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

comtef
Copy link
Contributor

@comtef comtef commented Jun 12, 2023

Description

  • New resource for Quicksight Theme.
  • New data source for Quicksight Theme.

Relations

Closes #31898
Closes #31899

References

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_CreateTheme.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeTheme.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeThemePermissions.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_UpdateTheme.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DeleteTheme.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccQuickSightTheme PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightTheme'  -timeout 180m
=== RUN   TestAccQuickSightTheme_basic
=== PAUSE TestAccQuickSightTheme_basic
=== RUN   TestAccQuickSightTheme_disappears
=== PAUSE TestAccQuickSightTheme_disappears
=== RUN   TestAccQuickSightTheme_fullConfig
=== PAUSE TestAccQuickSightTheme_fullConfig
=== RUN   TestAccQuickSightTheme_update
=== PAUSE TestAccQuickSightTheme_update
=== CONT  TestAccQuickSightTheme_basic
=== CONT  TestAccQuickSightTheme_fullConfig
=== CONT  TestAccQuickSightTheme_update
=== CONT  TestAccQuickSightTheme_disappears
--- PASS: TestAccQuickSightTheme_disappears (36.66s)
--- PASS: TestAccQuickSightTheme_basic (44.21s)
--- PASS: TestAccQuickSightTheme_fullConfig (44.49s)
--- PASS: TestAccQuickSightTheme_update (55.74s)
PASS

$ make testacc TESTS=TestAccQuickSightThemeDataSource PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightThemeDataSource'  -timeout 180m
=== RUN   TestAccQuickSightThemeDataSource_basic
=== PAUSE TestAccQuickSightThemeDataSource_basic
=== RUN   TestAccQuickSightThemeDataSource_fullConfig
=== PAUSE TestAccQuickSightThemeDataSource_fullConfig
=== CONT  TestAccQuickSightThemeDataSource_basic
=== CONT  TestAccQuickSightThemeDataSource_fullConfig
--- PASS: TestAccQuickSightThemeDataSource_fullConfig (28.11s)
--- PASS: TestAccQuickSightThemeDataSource_basic (29.01s)
PASS

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/quicksight Issues and PRs that pertain to the quicksight service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/quicksight Issues and PRs that pertain to the quicksight service. generators Relates to code generators. labels Jun 12, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/quicksight Issues and PRs that pertain to the quicksight service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 12, 2023
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Jun 12, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

make testacc TESTS=TestAccQuickSightTheme PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightTheme'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightTheme_disappears (18.23s)
--- PASS: TestAccQuickSightThemeDataSource_fullConfig (23.07s)
--- PASS: TestAccQuickSightThemeDataSource_basic (23.63s)
--- PASS: TestAccQuickSightTheme_basic (24.27s)
--- PASS: TestAccQuickSightTheme_fullConfig (24.76s)
--- PASS: TestAccQuickSightTheme_update (35.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 40.700s
$ make testacc TESTS=TestAccQuickSightThemeDataSource PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightThemeDataSource'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightThemeDataSource_basic (23.48s)
--- PASS: TestAccQuickSightThemeDataSource_fullConfig (23.63s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 27.137s

@jar-b jar-b merged commit f2909cf into hashicorp:main Jun 12, 2023
45 checks passed
@jar-b
Copy link
Member

jar-b commented Jun 12, 2023

Thanks for your contribution, @comtef! 👍

@github-actions github-actions bot added this to the v5.3.0 milestone Jun 12, 2023
@github-actions
Copy link

This functionality has been released in v5.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/quicksight Issues and PRs that pertain to the quicksight service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_quicksight_theme [New Data Source]: aws_quicksight_theme
2 participants