r/aws_lambda_function: deprecate replace_security_groups_on_destroy attribute

[jar-b]

Description

Deprecates the replace_security_groups_on_destroy and replacement_security_group_ids attributes. Also replaces the underlying logic to remove security groups from lambda ENIs to prevent configurations with this attribute set from failing. Acceptance tests have been left in place until the attribute is fully removed in the next major version.

Relations

Closes #31520
Relates #29289

Output from Acceptance Testing

$ make testacc PKG=lambda TESTS="TestAccLambdaFunction_VPC_replaceSGWithDefault|TestAccLambdaFunction_VPC_replaceSGWithCustom"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunction_VPC_replaceSGWithDefault|TestAccLambdaFunction_VPC_replaceSGWithCustom'  -timeout 180m
=== RUN   TestAccLambdaFunction_VPC_replaceSGWithDefault
=== PAUSE TestAccLambdaFunction_VPC_replaceSGWithDefault
=== RUN   TestAccLambdaFunction_VPC_replaceSGWithCustom
=== PAUSE TestAccLambdaFunction_VPC_replaceSGWithCustom
=== CONT  TestAccLambdaFunction_VPC_replaceSGWithDefault
=== CONT  TestAccLambdaFunction_VPC_replaceSGWithCustom
--- PASS: TestAccLambdaFunction_VPC_replaceSGWithCustom (1362.65s)
--- PASS: TestAccLambdaFunction_VPC_replaceSGWithDefault (1585.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     1588.440s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

[github-actions]

This functionality has been released in v5.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.