Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ssm_default_patch_baseline: Fix *conns.AWSClient is not ssm.ssmClient: missing method SSMClient panic #31928

Merged
merged 5 commits into from
Jun 13, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 13, 2023

Description

Ibid.

Relations

Closes #31924

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSSM_serial' PKG=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20  -run=TestAccSSM_serial -timeout 180m
=== RUN   TestAccSSM_serial
=== PAUSE TestAccSSM_serial
=== CONT  TestAccSSM_serial
=== RUN   TestAccSSM_serial/PatchBaseline
=== RUN   TestAccSSM_serial/PatchBaseline/deleteDefault
=== RUN   TestAccSSM_serial/DefaultPatchBaseline
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/multiRegion
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/disappears
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/otherOperatingSystem
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/patchBaselineARN
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/systemDefault
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/update
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/deleteDefault
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/basic
=== RUN   TestAccSSM_serial/DefaultPatchBaseline/wrongOperatingSystem
--- PASS: TestAccSSM_serial (259.85s)
    --- PASS: TestAccSSM_serial/PatchBaseline (24.34s)
        --- PASS: TestAccSSM_serial/PatchBaseline/deleteDefault (24.34s)
    --- PASS: TestAccSSM_serial/DefaultPatchBaseline (235.51s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/multiRegion (37.13s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/disappears (19.45s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/otherOperatingSystem (25.59s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/patchBaselineARN (25.85s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/systemDefault (27.54s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/update (40.94s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/deleteDefault (23.20s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/basic (25.84s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/wrongOperatingSystem (9.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	265.668s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ssm Issues and PRs that pertain to the ssm service. size/S Managed by automation to categorize the size of a PR. labels Jun 13, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Jun 13, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

$ make testacc TESTARGS='-run=TestAccSSM_serial' PKG=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20  -run=TestAccSSM_serial -timeout 180m

--- PASS: TestAccSSM_serial (207.95s)
    --- PASS: TestAccSSM_serial/DefaultPatchBaseline (189.66s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/patchBaselineARN (21.89s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/update (33.18s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/wrongOperatingSystem (8.40s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/basic (20.64s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/disappears (15.49s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/otherOperatingSystem (20.53s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/systemDefault (22.27s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/deleteDefault (18.27s)
        --- PASS: TestAccSSM_serial/DefaultPatchBaseline/multiRegion (28.98s)
    --- PASS: TestAccSSM_serial/PatchBaseline (18.29s)
        --- PASS: TestAccSSM_serial/PatchBaseline/deleteDefault (18.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        211.309s

@ewbankkit ewbankkit merged commit 3287e88 into main Jun 13, 2023
45 checks passed
@ewbankkit ewbankkit deleted the b-aws_ssm_default_patch_baseline.crash branch June 13, 2023 17:23
@github-actions github-actions bot added this to the v5.4.0 milestone Jun 13, 2023
github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
@github-actions
Copy link

This functionality has been released in v5.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/ssm Issues and PRs that pertain to the ssm service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ReadResource call.
2 participants