Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing 'id' values in pool map (#32106) #32133

Merged
merged 8 commits into from
Oct 30, 2023
Merged

fix: add missing 'id' values in pool map (#32106) #32133

merged 8 commits into from
Oct 30, 2023

Conversation

trc-ikeskin
Copy link
Contributor

Description

Add missing values for 'id' attribute for IPAM pools returned by the aws_vpc_ipam_pools data source

Relations

Closes #32106

References

Output from Acceptance Testing

make testacc TESTS=TestAccIPAMPoolsDataSource PKG=ec2
    
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAMPoolsDataSource'  -timeout 180m
    === RUN   TestAccIPAMPoolsDataSource_basic
    === PAUSE TestAccIPAMPoolsDataSource_basic
    === RUN   TestAccIPAMPoolsDataSource_empty
    === PAUSE TestAccIPAMPoolsDataSource_empty
    === CONT  TestAccIPAMPoolsDataSource_basic
    === CONT  TestAccIPAMPoolsDataSource_empty
    --- PASS: TestAccIPAMPoolsDataSource_empty (9.80s)
    --- PASS: TestAccIPAMPoolsDataSource_basic (79.66s)
    PASS
    ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        88.286s

...

%make testacc TESTS=TestAccIPAMPoolsDataSource PKG=ec2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAMPoolsDataSource'  -timeout 180m
=== RUN   TestAccIPAMPoolsDataSource_basic
=== PAUSE TestAccIPAMPoolsDataSource_basic
=== RUN   TestAccIPAMPoolsDataSource_empty
=== PAUSE TestAccIPAMPoolsDataSource_empty
=== CONT  TestAccIPAMPoolsDataSource_basic
=== CONT  TestAccIPAMPoolsDataSource_empty
--- PASS: TestAccIPAMPoolsDataSource_empty (9.80s)
--- PASS: TestAccIPAMPoolsDataSource_basic (79.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        88.286s
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ipam Issues and PRs that pertain to the ipam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ipam Issues and PRs that pertain to the ipam service. labels Jun 21, 2023
@github-actions github-actions bot added service/ipam Issues and PRs that pertain to the ipam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 21, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @trc-ikeskin 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 21, 2023
@trc-ikeskin
Copy link
Contributor Author

trc-ikeskin commented Jun 26, 2023

@justinretzolk Any maintainers available to implement this fix?

@justinretzolk
Copy link
Member

Hey @trc-ikeskin 👋 Thank you for checking in on this! Unfortunately I can't provide an ETA on when this will be reviewed/merged due to the potential of shifting priorities. We prioritize by count of 👍 reactions and a few other things (more information on our prioritization guide if you're interested).

Copy link
Collaborator

@drewmullen drewmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Small comment in the changelog but not big enough of a deal to block. Note the website docs already contained id and not the (now removed) ipam_pool_id so no changes required there

Thanks for finding, reporting, and fixing this bug! And thanks for your patience!

$ make testacc TESTS=TestAccIPAMPoolsDataSource PKG=ec2
=== RUN   TestAccIPAMPoolsDataSource_basic
=== PAUSE TestAccIPAMPoolsDataSource_basic
=== RUN   TestAccIPAMPoolsDataSource_empty
=== PAUSE TestAccIPAMPoolsDataSource_empty
=== CONT  TestAccIPAMPoolsDataSource_basic
=== CONT  TestAccIPAMPoolsDataSource_empty
--- PASS: TestAccIPAMPoolsDataSource_empty (20.09s)
--- PASS: TestAccIPAMPoolsDataSource_basic (151.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        154.091s

.changelog/32133.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIPAMPoolsDataSource_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccIPAMPoolsDataSource_basic -timeout 360m
=== RUN   TestAccIPAMPoolsDataSource_basic
=== PAUSE TestAccIPAMPoolsDataSource_basic
=== CONT  TestAccIPAMPoolsDataSource_basic
--- PASS: TestAccIPAMPoolsDataSource_basic (78.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	84.132s

@ewbankkit
Copy link
Contributor

@trc-ikeskin Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ca39f8a into hashicorp:main Oct 30, 2023
36 checks passed
@github-actions github-actions bot added this to the v5.24.0 milestone Oct 30, 2023
Copy link

github-actions bot commented Nov 2, 2023

This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@trc-ikeskin trc-ikeskin deleted the b-data-aws_vpc_ipam_pools-missing_ids branch November 3, 2023 10:06
Copy link

github-actions bot commented Dec 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ipam Issues and PRs that pertain to the ipam service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: data.aws_vpc_ipam_pools lacks ipam_pool_id and/or id values
4 participants