Addressing Issue 32229 - cleaning up IAM_PATTERN properly

[mc-etcher]

Description

This PR addresses issue 32229

Relations

Closes #32229
Closes #33038

References

Output from Acceptance Testing

$ make testacc PKG=servicecatalog TESTS='TestAccServiceCatalogPrincipalPortfolioAssociation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogPrincipalPortfolioAssociation'  -timeout 180m
=== RUN   TestAccServiceCatalogPrincipalPortfolioAssociation_basic
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_basic
=== RUN   TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern
=== RUN   TestAccServiceCatalogPrincipalPortfolioAssociation_disappears
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_disappears
=== CONT  TestAccServiceCatalogPrincipalPortfolioAssociation_basic
=== CONT  TestAccServiceCatalogPrincipalPortfolioAssociation_disappears
=== CONT  TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern (44.34s)
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_basic (64.08s)
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_disappears (89.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog     95.463s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @mc-etcher 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[boxrick]

This fixes an ongoing problem for me and would be amazing if its merged in.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccServiceCatalogPrincipalPortfolioAssociation_' PKG=servicecatalog ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 2  -run=TestAccServiceCatalogPrincipalPortfolioAssociation_ -timeout 180m
=== RUN   TestAccServiceCatalogPrincipalPortfolioAssociation_basic
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_basic
=== RUN   TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern
=== RUN   TestAccServiceCatalogPrincipalPortfolioAssociation_disappears
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_disappears
=== RUN   TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0
=== PAUSE TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0
=== CONT  TestAccServiceCatalogPrincipalPortfolioAssociation_basic
=== CONT  TestAccServiceCatalogPrincipalPortfolioAssociation_disappears
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_disappears (33.61s)
=== CONT  TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_basic (37.13s)
=== CONT  TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_iam_pattern (28.01s)
--- PASS: TestAccServiceCatalogPrincipalPortfolioAssociation_migrateV0 (117.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	160.253s

[ewbankkit]

@mc-etcher Thanks for the contribution 🎉 👏.
I added a StateUpgrader to convert the resource's id attribute from the old 3-part format to the new 4-part format.

[github-actions]

This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.