Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Migrate keyspaces resources to AWS SDK for Go v2 #32339

Merged
merged 13 commits into from
Jul 3, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 3, 2023

Description

Also adds the client_side_timestamps configuration block.

Relations

Closes #32338.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccKeyspaces' PKG=keyspaces ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 2  -run=TestAccKeyspaces -timeout 180m
=== RUN   TestAccKeyspacesKeyspace_basic
=== PAUSE TestAccKeyspacesKeyspace_basic
=== RUN   TestAccKeyspacesKeyspace_disappears
=== PAUSE TestAccKeyspacesKeyspace_disappears
=== RUN   TestAccKeyspacesKeyspace_tags
=== PAUSE TestAccKeyspacesKeyspace_tags
=== RUN   TestAccKeyspacesTable_basic
=== PAUSE TestAccKeyspacesTable_basic
=== RUN   TestAccKeyspacesTable_disappears
=== PAUSE TestAccKeyspacesTable_disappears
=== RUN   TestAccKeyspacesTable_tags
=== PAUSE TestAccKeyspacesTable_tags
=== RUN   TestAccKeyspacesTable_clientSideTimestamps
=== PAUSE TestAccKeyspacesTable_clientSideTimestamps
=== RUN   TestAccKeyspacesTable_multipleColumns
=== PAUSE TestAccKeyspacesTable_multipleColumns
=== RUN   TestAccKeyspacesTable_update
=== PAUSE TestAccKeyspacesTable_update
=== RUN   TestAccKeyspacesTable_addColumns
=== PAUSE TestAccKeyspacesTable_addColumns
=== RUN   TestAccKeyspacesTable_delColumns
=== PAUSE TestAccKeyspacesTable_delColumns
=== CONT  TestAccKeyspacesKeyspace_basic
=== CONT  TestAccKeyspacesTable_clientSideTimestamps
--- PASS: TestAccKeyspacesKeyspace_basic (73.50s)
=== CONT  TestAccKeyspacesTable_addColumns
--- PASS: TestAccKeyspacesTable_clientSideTimestamps (111.13s)
=== CONT  TestAccKeyspacesTable_delColumns
--- PASS: TestAccKeyspacesTable_addColumns (137.02s)
=== CONT  TestAccKeyspacesTable_update
--- PASS: TestAccKeyspacesTable_delColumns (163.10s)
=== CONT  TestAccKeyspacesTable_multipleColumns
--- PASS: TestAccKeyspacesTable_multipleColumns (98.30s)
=== CONT  TestAccKeyspacesTable_basic
--- PASS: TestAccKeyspacesTable_basic (110.11s)
=== CONT  TestAccKeyspacesTable_tags
--- PASS: TestAccKeyspacesTable_tags (141.12s)
=== CONT  TestAccKeyspacesTable_disappears
--- PASS: TestAccKeyspacesTable_disappears (117.40s)
=== CONT  TestAccKeyspacesKeyspace_tags
--- PASS: TestAccKeyspacesKeyspace_tags (105.68s)
=== CONT  TestAccKeyspacesKeyspace_disappears
--- PASS: TestAccKeyspacesKeyspace_disappears (64.77s)
--- PASS: TestAccKeyspacesTable_update (970.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces	1187.263s
% make sweep SWEEPARGS=-sweep-run=aws_keyspaces_keyspace
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_keyspaces_keyspace -timeout 60m
2023/07/02 17:19:40 [DEBUG] Running Sweepers for region (us-west-2):
2023/07/02 17:19:40 [DEBUG] Running Sweeper (aws_keyspaces_keyspace) in region (us-west-2)
2023/07/02 17:19:41 [DEBUG] Waiting for state to become: [success]
2023/07/02 17:19:41 [DEBUG] Deleting Keyspaces Keyspace: (tf_acc_test_xb0pvgxe73dmu2se9c0i)
2023/07/02 17:19:41 [DEBUG] Waiting for state to become: [success]
2023/07/02 17:19:41 [DEBUG] Waiting for state to become: [success]
2023/07/02 17:19:41 [TRACE] Waiting 500ms before next try
2023/07/02 17:19:42 [TRACE] Waiting 1s before next try
2023/07/02 17:19:43 [TRACE] Waiting 2s before next try
2023/07/02 17:19:45 [TRACE] Waiting 4s before next try
2023/07/02 17:19:49 [TRACE] Waiting 8s before next try
2023/07/02 17:19:57 [TRACE] Waiting 10s before next try
2023/07/02 17:20:07 [TRACE] Waiting 10s before next try
2023/07/02 17:20:17 [TRACE] Waiting 10s before next try
2023/07/02 17:20:27 [TRACE] Waiting 10s before next try
2023/07/02 17:20:37 [DEBUG] Completed Sweeper (aws_keyspaces_keyspace) in region (us-west-2) in 57.338631668s
2023/07/02 17:20:37 Completed Sweepers for region (us-west-2) in 57.338822952s
2023/07/02 17:20:37 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_keyspaces_keyspace
2023/07/02 17:20:37 [DEBUG] Running Sweepers for region (us-east-1):
2023/07/02 17:20:37 [DEBUG] Running Sweeper (aws_keyspaces_keyspace) in region (us-east-1)
2023/07/02 17:20:38 [DEBUG] Completed Sweeper (aws_keyspaces_keyspace) in region (us-east-1) in 810.112632ms
2023/07/02 17:20:38 Completed Sweepers for region (us-east-1) in 810.18428ms
2023/07/02 17:20:38 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_keyspaces_keyspace
2023/07/02 17:20:38 [DEBUG] Running Sweepers for region (us-east-2):
2023/07/02 17:20:38 [DEBUG] Running Sweeper (aws_keyspaces_keyspace) in region (us-east-2)
2023/07/02 17:20:39 [DEBUG] Completed Sweeper (aws_keyspaces_keyspace) in region (us-east-2) in 552.703236ms
2023/07/02 17:20:39 Completed Sweepers for region (us-east-2) in 552.935661ms
2023/07/02 17:20:39 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_keyspaces_keyspace
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	64.297s

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/keyspaces Issues and PRs that pertain to the keyspaces service. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 3, 2023
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jul 3, 2023
@ewbankkit ewbankkit merged commit eca426c into main Jul 3, 2023
54 checks passed
@ewbankkit ewbankkit deleted the td-migrate-keyspaces-to-aws-sdk-v2 branch July 3, 2023 13:45
@github-actions github-actions bot added this to the v5.7.0 milestone Jul 3, 2023
github-actions bot pushed a commit that referenced this pull request Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/keyspaces Issues and PRs that pertain to the keyspaces service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add client side timestamps enablement to aws_keyspaces_table resource
2 participants