Stop private and public dns namespace resources being replaced when the description is altered

[pierskarsenbarg]

Description

Currently, if you update the description of either a private DNS namespace (aws_service_discovery_private_dns_namespaceediscovery) or a public DNS namespace (aws_service_discovery_public_dns_namespaceediscovery) it triggers a replacement. This doesn't happen either in the console or with the AWS CLI, so it probably shouldn't happen here.

Relations

Closes #32341

References

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccServiceDiscoveryPublicDNSNamespace_\|TestAccServiceDiscoveryPrivateDNSNamespace_' PKG=servicediscovery ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicediscovery/... -v -count 1 -parallel 2  -run=TestAccServiceDiscoveryPublicDNSNamespace_\|TestAccServiceDiscoveryPrivateDNSNamespace_ -timeout 180m
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_basic
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_basic
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_disappears
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_disappears
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_description
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_description
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_basic
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_basic
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_disappears
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_disappears
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_description
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_description
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_tags
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_tags
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_basic
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_basic
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_basic (114.63s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_tags
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_basic (118.92s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_tags (151.81s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_description
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap (176.03s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_disappears
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_description (131.18s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_tags
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_disappears (111.82s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_description
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_description (129.71s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_disappears
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_tags (151.63s)
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_disappears (104.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	646.391s

[ewbankkit]

@pierskarsenbarg Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.