Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug reading emr studio session mapping #32416

Merged

Conversation

Yunsang-Jeong
Copy link
Contributor

@Yunsang-Jeong Yunsang-Jeong commented Jul 7, 2023

Description

When creating aws_emr_studio_session_mapping, identity_id and identity_name can be selected. However, only identity_id is always used in the read, update, and delete process after creation, so it needs to be modified.

There's already an MR to address this, but it's outdated and seems to require test code changes.

Relations

Closes #26369.
Closes #25761.

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccEMRStudioSessionMapping PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRStudioSessionMapping'  -timeout 180m
=== RUN   TestAccEMRStudioSessionMapping_basic
=== PAUSE TestAccEMRStudioSessionMapping_basic
=== RUN   TestAccEMRStudioSessionMapping_disappears
=== PAUSE TestAccEMRStudioSessionMapping_disappears
=== CONT  TestAccEMRStudioSessionMapping_basic
=== CONT  TestAccEMRStudioSessionMapping_disappears
--- PASS: TestAccEMRStudioSessionMapping_disappears (54.85s)
--- PASS: TestAccEMRStudioSessionMapping_basic (80.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	82.556s

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emr Issues and PRs that pertain to the emr service. needs-triage Waiting for first response or review from a maintainer. labels Jul 7, 2023
@Yunsang-Jeong Yunsang-Jeong marked this pull request as ready for review July 7, 2023 17:46
@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 7, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRStudioSessionMapping_' PKG=emr ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 2  -run=TestAccEMRStudioSessionMapping_ -timeout 180m
=== RUN   TestAccEMRStudioSessionMapping_basic
=== PAUSE TestAccEMRStudioSessionMapping_basic
=== RUN   TestAccEMRStudioSessionMapping_disappears
=== PAUSE TestAccEMRStudioSessionMapping_disappears
=== CONT  TestAccEMRStudioSessionMapping_basic
=== CONT  TestAccEMRStudioSessionMapping_disappears
    studio_session_mapping_test.go:180: AWS_IDENTITY_STORE_USER_ID env var must be set for AWS Identity Store User acceptance test. This is required until ListUsers API returns results without filtering by name.
--- SKIP: TestAccEMRStudioSessionMapping_disappears (0.46s)
=== NAME  TestAccEMRStudioSessionMapping_basic
    studio_session_mapping_test.go:180: AWS_IDENTITY_STORE_USER_ID env var must be set for AWS Identity Store User acceptance test. This is required until ListUsers API returns results without filtering by name.
--- SKIP: TestAccEMRStudioSessionMapping_basic (0.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	6.489s

@ewbankkit
Copy link
Contributor

@Yunsang-Jeong Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d1a767a into hashicorp:main Jul 28, 2023
34 checks passed
@github-actions github-actions bot added this to the v5.11.0 milestone Jul 28, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/emr Issues and PRs that pertain to the emr service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_emr_studio_session_mapping not populating identity_id
3 participants