Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typos in Quicksight flatteners for visible_range, rows, and visibility #32464

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

justinretzolk
Copy link
Member

@justinretzolk justinretzolk commented Jul 11, 2023

Description

There were three typos in some of the Quicksight flattener functions that were leading to the following errors. This PR aims to correct them so that the data can successfully be written to the state.

I'm unsure on running the acceptance tests for this, so have left that out for now. I'd also be interested in how to properly approach the changelog entry for this, since it affects multiple resources due to the shared schema.

Error: setting definition: Invalid address to set: []string{"definition", "0", "sheets", "0", "visuals", "0", "bar_chart_visual", "0", "chart_configuration", "0", "category_axis", "0", "scrollbar_options", "0", "visibile_range"}
Error: setting definition: Invalid address to set: []string{"definition", "0", "sheets", "0", "visuals", "0", "pivot_table_visual", "0", "chart_configuration", "0", "field_options", "0", "selected_field_options", "0", "visbility"}
Error: setting definition: Invalid address to set: []string{"definition", "0", "sheets", "0", "visuals", "0", "pivot_table_visual", "0", "chart_configuration", "0", "field_wells", "0", "pivot_table_aggregated_field_wells", "0", "row"}

Relations

Closes #31923
Closes #32347

References

Schema reference for:

Output from Acceptance Testing

The acceptance tests for Quicksight are a bit unclear to me, so I'll need some assistance in running those, should it be needed for these typo fixes.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/quicksight Issues and PRs that pertain to the quicksight service. size/XS Managed by automation to categorize the size of a PR. labels Jul 11, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=quicksight TESTS=TestAccQuickSightAnalysis_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightAnalysis_'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightAnalysis_forceDelete (66.13s)
--- PASS: TestAccQuickSightAnalysis_parametersConfig (77.63s)
--- PASS: TestAccQuickSightAnalysis_disappears (82.51s)
--- PASS: TestAccQuickSightAnalysis_sourceEntity (82.62s)
--- PASS: TestAccQuickSightAnalysis_basic (88.76s)
--- PASS: TestAccQuickSightAnalysis_update (123.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 127.049s
$ make testacc PKG=quicksight TESTS=TestAccQuickSightDashboard_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightDashboard_'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (74.58s)
--- PASS: TestAccQuickSightDashboard_basic (75.44s)
--- PASS: TestAccQuickSightDashboard_disappears (82.13s)
--- PASS: TestAccQuickSightDashboard_sourceEntity (87.14s)
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (130.51s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 133.963s
$ make testacc PKG=quicksight TESTS=TestAccQuickSightTemplate_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightTemplate_'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightTemplate_disappears (56.96s)
--- PASS: TestAccQuickSightTemplate_barChart (61.01s)
--- PASS: TestAccQuickSightTemplate_basic (61.47s)
--- PASS: TestAccQuickSightTemplate_sourceEntity (63.19s)
--- PASS: TestAccQuickSightTemplate_table (87.59s)
--- PASS: TestAccQuickSightTemplate_update (96.64s)
--- PASS: TestAccQuickSightTemplate_tags (114.31s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 117.657s

.changelog/32464.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 12, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@justinretzolk justinretzolk merged commit 54cb05c into main Jul 12, 2023
38 checks passed
@justinretzolk justinretzolk deleted the b-quicksight-visible-range branch July 12, 2023 19:48
@github-actions github-actions bot added this to the v5.8.0 milestone Jul 12, 2023
github-actions bot pushed a commit that referenced this pull request Jul 12, 2023
@github-actions
Copy link

This functionality has been released in v5.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/quicksight Issues and PRs that pertain to the quicksight service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
2 participants