Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_connect_queue - support delete #32538

Merged
merged 5 commits into from
Jul 18, 2023

Conversation

GlennChia
Copy link
Collaborator

Description

Support delete for aws_connect_queue

Relations

Closes #32537

References

Amazon Connect Delete Queue API

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccConnect_serial/Queue/disappears' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/Queue/disappears -timeout 180m
=== RUN   TestAccConnect_serial
=== PAUSE TestAccConnect_serial
=== CONT  TestAccConnect_serial
=== RUN   TestAccConnect_serial/Queue
=== RUN   TestAccConnect_serial/Queue/disappears
--- PASS: TestAccConnect_serial (126.10s)
    --- PASS: TestAccConnect_serial/Queue (126.10s)
        --- PASS: TestAccConnect_serial/Queue/disappears (126.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    126.247s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/connect Issues and PRs that pertain to the connect service. size/XS Managed by automation to categorize the size of a PR. partner Contribution from a partner. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/connect Issues and PRs that pertain to the connect service. labels Jul 17, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/connect Issues and PRs that pertain to the connect service. size/S Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/connect Issues and PRs that pertain to the connect service. labels Jul 17, 2023
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/connect Issues and PRs that pertain to the connect service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 17, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccConnect_serial/Queue/' PKG=connect

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/Queue/ -timeout 180m
    queue_test.go:175: A bug in the service API has been reported
--- PASS: TestAccConnect_serial (1074.24s)
    --- PASS: TestAccConnect_serial/Queue (1074.24s)
        --- PASS: TestAccConnect_serial/Queue/disappears (97.00s)
        --- PASS: TestAccConnect_serial/Queue/hoursOfOperationId (135.39s)
        --- SKIP: TestAccConnect_serial/Queue/maxContacts (0.00s)
        --- PASS: TestAccConnect_serial/Queue/basic (114.68s)
        --- PASS: TestAccConnect_serial/Queue/outboundCallerConfig (115.13s)
        --- PASS: TestAccConnect_serial/Queue/status (121.13s)
        --- PASS: TestAccConnect_serial/Queue/quickConnectIds (160.09s)
        --- PASS: TestAccConnect_serial/Queue/dataSource_id (98.90s)
        --- PASS: TestAccConnect_serial/Queue/dataSource_name (98.25s)
        --- PASS: TestAccConnect_serial/Queue/tags (133.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	1077.536s

@johnsonaj
Copy link
Contributor

@GlennChia thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 2ff432c into hashicorp:main Jul 18, 2023
47 checks passed
@github-actions github-actions bot added this to the v5.9.0 milestone Jul 18, 2023
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@GlennChia GlennChia deleted the f-aws_connect_queue-delete branch August 13, 2023 01:13
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/connect Issues and PRs that pertain to the connect service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Amazon Connect Queue - Support Delete
3 participants