Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_datasync_agent: handle computed private_link_endpoint values #32546

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jul 17, 2023

Description

Prevent persistent diffs on aws_datasync_agent configurations where private_link_endpoint is not explicitly configured but is returned by the AWS API.

Relations

Closes #19947

Output from Acceptance Testing

$ make testacc PKG=datasync TESTS=TestAccDataSyncAgent_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run='TestAccDataSyncAgent_'  -timeout 180m

--- PASS: TestAccDataSyncAgent_disappears (106.23s)
--- PASS: TestAccDataSyncAgent_basic (111.66s)
--- PASS: TestAccDataSyncAgent_tags (150.82s)
--- PASS: TestAccDataSyncAgent_agentName (172.15s)
--- PASS: TestAccDataSyncAgent_vpcEndpointID (292.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datasync   295.587s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/datasync Issues and PRs that pertain to the datasync service. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 17, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc PKG=datasync TESTS=TestAccDataSyncAgent_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run='TestAccDataSyncAgent_'  -timeout 180m
--- PASS: TestAccDataSyncAgent_disappears (127.40s)
--- PASS: TestAccDataSyncAgent_basic (130.30s)
--- PASS: TestAccDataSyncAgent_agentName (137.29s)
--- PASS: TestAccDataSyncAgent_tags (166.40s)
--- PASS: TestAccDataSyncAgent_vpcEndpointID (279.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	282.552s

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Jul 18, 2023
@jar-b jar-b merged commit 05fa0a6 into main Jul 18, 2023
38 checks passed
@jar-b jar-b deleted the b-aws_datasync_agent-diff-fix branch July 18, 2023 17:25
@github-actions github-actions bot added this to the v5.9.0 milestone Jul 18, 2023
github-actions bot pushed a commit that referenced this pull request Jul 18, 2023
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/datasync Issues and PRs that pertain to the datasync service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_datasync_agent with activation_key is not idempotent
2 participants