r/aws_rds_instance: Add 'backup_target' attribute

[jcg-2]

Description

• Add a backup_target attribute to the aws_rds_instance resource that allows selection of where backups are stored (either in region or on an Outpost) on creation
• Update aws_rds_instance acceptance tests to share common Outpost config for testing backup_target and customer_owned_ip_enabled attributes.
  • Update the common Outpost config to use a new, dedicated list of Preferred Instance Classes because Outposts only support a subset.

Relations

Closes #31469

References

• https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/rds-on-outposts.html

Output from Acceptance Testing

$ make testacc TESTS='TestAccRDSInstance_BackupTarget' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_BackupTarget'  -timeout 180m
=== RUN   TestAccRDSInstance_BackupTarget
=== PAUSE TestAccRDSInstance_BackupTarget
=== CONT  TestAccRDSInstance_BackupTarget
--- PASS: TestAccRDSInstance_BackupTarget (498.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        498.259s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jcg-2]

I ran the new TestAccRDSInstance_BackupTarget acceptance test, however I can't run the TestAccRDSInstance_coIPEnabled* tests because I don't have access to the required resources.

Would it be possible for someone to confirm they still work.
I'm also curious to see if they actually work on the main branch, for the following reasons:

• The aws_db_instance created on the Outpost is currently using the the following preferred instance classes:

  mySQLPreferredInstanceClasses           = `"db.t3.micro", "db.t3.small", "db.t2.small", "db.t2.medium"`
  

  None of which are available to use on an Outpost according to these docs

• The testAccInstanceConfig_CoIPEnabled_snapshotID config refers to an aws_db_subnet_group.foo.name, which doesn't exist as far as I can tell

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSInstance_basic\|TestAccRDSInstance_manage_password\|TestAccRDSInstance_BackupTarget\|TestAccRDSInstance_CoIPEnabled\|TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_basic\|TestAccRDSInstance_manage_password\|TestAccRDSInstance_BackupTarget\|TestAccRDSInstance_CoIPEnabled\|TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion -timeout 180m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_manage_password
=== PAUSE TestAccRDSInstance_manage_password
=== RUN   TestAccRDSInstance_CoIPEnabled
=== PAUSE TestAccRDSInstance_CoIPEnabled
=== RUN   TestAccRDSInstance_CoIPEnabled_disabledToEnabled
=== PAUSE TestAccRDSInstance_CoIPEnabled_disabledToEnabled
=== RUN   TestAccRDSInstance_CoIPEnabled_enabledToDisabled
=== PAUSE TestAccRDSInstance_CoIPEnabled_enabledToDisabled
=== RUN   TestAccRDSInstance_CoIPEnabled_restoreToPointInTime
=== PAUSE TestAccRDSInstance_CoIPEnabled_restoreToPointInTime
=== RUN   TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
=== PAUSE TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
=== RUN   TestAccRDSInstance_BackupTarget
=== PAUSE TestAccRDSInstance_BackupTarget
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== CONT  TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_CoIPEnabled_restoreToPointInTime
    acctest.go:1104: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_restoreToPointInTime (1.00s)
=== CONT  TestAccRDSInstance_BackupTarget
    acctest.go:1104: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_BackupTarget (0.16s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
--- PASS: TestAccRDSInstance_basic (649.93s)
=== CONT  TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
    acctest.go:1104: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_snapshotIdentifier (0.43s)
=== CONT  TestAccRDSInstance_CoIPEnabled_disabledToEnabled
    acctest.go:1104: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_disabledToEnabled (0.22s)
=== CONT  TestAccRDSInstance_CoIPEnabled_enabledToDisabled
    acctest.go:1104: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_enabledToDisabled (0.18s)
=== CONT  TestAccRDSInstance_CoIPEnabled
    acctest.go:1104: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled (0.18s)
=== CONT  TestAccRDSInstance_manage_password
--- PASS: TestAccRDSInstance_manage_password (454.72s)
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion (2421.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2428.004s

[ewbankkit]

@jcg-2 Thanks for the contribution 🎉 👏.

The maintainers do not have access to an Outpost so have not been running the COIP acceptance tests.

[github-actions]

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.