Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssm contacts rotation resource and data source #32710

Merged
merged 27 commits into from
Feb 1, 2024

Conversation

jimfkong
Copy link
Contributor

@jimfkong jimfkong commented Jul 27, 2023

Description

Add support for AWS SSM Contacts Rotations resource and data source.

Relations

Relates #22687

References

https://docs.aws.amazon.com/incident-manager/latest/APIReference/API_SSMContacts_CreateRotation.html

Output from Acceptance Testing

kongji@bcd074504200 % make testacc TESTS=TestAccSSMContactsRotation PKG=ssmcontacts
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssmcontacts/... -v -count 1 -parallel 20 -run='TestAccSSMContactsRotation'  -timeout 180m
=== RUN   TestAccSSMContactsRotationDataSource_basic
--- PASS: TestAccSSMContactsRotationDataSource_basic (330.52s)
=== RUN   TestAccSSMContactsRotationDataSource_dailySettings
--- PASS: TestAccSSMContactsRotationDataSource_dailySettings (328.59s)
=== RUN   TestAccSSMContactsRotationDataSource_monthlySettings
--- PASS: TestAccSSMContactsRotationDataSource_monthlySettings (328.70s)
=== RUN   TestAccSSMContactsRotation_basic
--- PASS: TestAccSSMContactsRotation_basic (314.21s)
=== RUN   TestAccSSMContactsRotation_disappears
--- PASS: TestAccSSMContactsRotation_disappears (326.69s)
=== RUN   TestAccSSMContactsRotation_updateRequiredFields
--- PASS: TestAccSSMContactsRotation_updateRequiredFields (350.73s)
=== RUN   TestAccSSMContactsRotation_startTime
--- PASS: TestAccSSMContactsRotation_startTime (350.28s)
=== RUN   TestAccSSMContactsRotation_contactIds
--- PASS: TestAccSSMContactsRotation_contactIds (352.59s)
=== RUN   TestAccSSMContactsRotation_recurrence
--- PASS: TestAccSSMContactsRotation_recurrence (451.09s)
=== RUN   TestAccSSMContactsRotation_tags
--- PASS: TestAccSSMContactsRotation_tags (430.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssmcontacts	3567.144s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/ssmcontacts Issues and PRs that pertain to the ssmcontacts service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 27, 2023
@jimfkong jimfkong marked this pull request as ready for review July 27, 2023 01:54
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jimfkong 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added new-resource Introduces a new resource. new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 27, 2023
@breathingdust breathingdust added the partner Contribution from a partner. label Nov 20, 2023
@johnsonaj johnsonaj self-assigned this Dec 19, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 19, 2023
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccSSMContacts_serial/RotationResource" PKG=ssmcontacts

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssmcontacts/... -v -count 1 -parallel 20  -run=TestAccSSMContacts_serial/RotationResource -timeout 360m
=== RUN   TestAccSSMContacts_serial
=== PAUSE TestAccSSMContacts_serial
=== CONT  TestAccSSMContacts_serial
=== RUN   TestAccSSMContacts_serial/RotationResource
=== RUN   TestAccSSMContacts_serial/RotationResource/startTime
=== RUN   TestAccSSMContacts_serial/RotationResource/contactIds
=== RUN   TestAccSSMContacts_serial/RotationResource/recurrence
=== RUN   TestAccSSMContacts_serial/RotationResource/basic
=== RUN   TestAccSSMContacts_serial/RotationResource/tags
=== RUN   TestAccSSMContacts_serial/RotationResource/disappears
=== RUN   TestAccSSMContacts_serial/RotationResource/update
--- PASS: TestAccSSMContacts_serial (2067.26s)
    --- PASS: TestAccSSMContacts_serial/RotationResource (2067.26s)
        --- PASS: TestAccSSMContacts_serial/RotationResource/startTime (330.58s)
        --- PASS: TestAccSSMContacts_serial/RotationResource/contactIds (329.37s)
        --- PASS: TestAccSSMContacts_serial/RotationResource/recurrence (375.37s)
        --- PASS: TestAccSSMContacts_serial/RotationResource/basic (386.07s)
        --- PASS: TestAccSSMContacts_serial/RotationResource/disappears (317.67s)
        --- PASS: TestAccSSMContacts_serial/RotationResource/update (328.19s)
        --- PASS: TestAccSSMContacts_serial/RotationResource/tags (329.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssmcontacts	2074.270s
% make testacc TESTARGS="-run=TestAccSSMContacts_serial/RotationDataSource" PKG=ssmcontacts

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssmcontacts/... -v -count 1 -parallel 20  -run=TestAccSSMContacts_serial/RotationDataSource -timeout 360m
=== RUN   TestAccSSMContacts_serial
=== PAUSE TestAccSSMContacts_serial
=== CONT  TestAccSSMContacts_serial
=== RUN   TestAccSSMContacts_serial/RotationDataSource
=== RUN   TestAccSSMContacts_serial/RotationDataSource/basic
=== RUN   TestAccSSMContacts_serial/RotationDataSource/dailySettings
=== RUN   TestAccSSMContacts_serial/RotationDataSource/monthlySettings
--- PASS: TestAccSSMContacts_serial (948.60s)
    --- PASS: TestAccSSMContacts_serial/RotationDataSource (948.60s)
        --- PASS: TestAccSSMContacts_serial/RotationDataSource/basic (316.58s)
        --- PASS: TestAccSSMContacts_serial/RotationDataSource/dailySettings (316.59s)
        --- PASS: TestAccSSMContacts_serial/RotationDataSource/monthlySettings (315.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssmcontacts	955.592s

@johnsonaj
Copy link
Contributor

@jimfkong thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit eb165ab into hashicorp:main Feb 1, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.35.0 milestone Feb 1, 2024
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. new-resource Introduces a new resource. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ssmcontacts Issues and PRs that pertain to the ssmcontacts service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants