Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource] DMS Serverless Replication resource #32908

Merged

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented Aug 8, 2023

Description

This PR adds the aws_dms_serverless_replication resource.

This resource is a serverless option in DMS that automatically sets up, scales, and manages the migration of resources for your database migrations.

Relations

Closes #32162
Closes #32920

References

Output from Acceptance Testing

terraform-provider-aws git:(f-aws_dms_serverless_replication_resource) ✗ make testacc TESTS=TestAccDMSServerlessReplication_ PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSServerlessReplication_'  -timeout 180m
=== RUN   TestAccDMSServerlessReplication_basic
=== PAUSE TestAccDMSServerlessReplication_basic
=== RUN   TestAccDMSServerlessReplication_update
=== PAUSE TestAccDMSServerlessReplication_update
=== RUN   TestAccDMSServerlessReplication_startReplication
=== PAUSE TestAccDMSServerlessReplication_startReplication
=== CONT  TestAccDMSServerlessReplication_basic
=== CONT  TestAccDMSServerlessReplication_startReplication
=== CONT  TestAccDMSServerlessReplication_update
--- PASS: TestAccDMSServerlessReplication_basic (1493.10s)
--- PASS: TestAccDMSServerlessReplication_update (1504.35s)
--- PASS: TestAccDMSServerlessReplication_startReplication (3114.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        3116.427s

...

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/dms Issues and PRs that pertain to the dms service. labels Aug 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 8, 2023
@DanielRieske DanielRieske marked this pull request as ready for review August 8, 2023 20:32
@DanielRieske DanielRieske changed the title [WIP] [New Resource] DMS Serverless Replication resource [New Resource] DMS Serverless Replication resource Aug 8, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 9, 2023
@bschaatsbergen bschaatsbergen self-requested a review August 15, 2023 09:33
@csbain
Copy link

csbain commented Aug 18, 2023

Hi @DanielRieske I was really wanting to test this MR (i.e. get early access) , could you possibly point me to any instructions on compiling and using this within terraform?

cheers

@DanielRieske
Copy link
Contributor Author

DanielRieske commented Aug 18, 2023

Hiya @csbain 👋 , you should be able to clone my fork and checkout the branch.
From there on you can follow these instructions to build and test it.

Keep in mind that this feature isn't final and might be changed during code review.

@bschaatsbergen
Copy link
Member

bschaatsbergen commented Sep 4, 2023

It's impressive to see your involvement in this 👏🏼 , @DanielRieske. Since we are direct colleagues, I'm more than willing to review it and provide feedback, but I would recommend having someone like @ewbankkit formally review and approve this.

@bschaatsbergen bschaatsbergen removed their request for review September 4, 2023 13:35
@Oden-Allfader
Copy link

Hi @DanielRieske !
Thank you for picking up my issue! Great job 🙏
Any idea of ETA when this would be released?
Much appreciated !

@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 21, 2023
% make testacc TESTARGS='-run=TestAccDMSReplicationConfig_' PKG=dms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2  -run=TestAccDMSReplicationConfig_ -timeout 360m
=== RUN   TestAccDMSReplicationConfig_basic
=== PAUSE TestAccDMSReplicationConfig_basic
=== RUN   TestAccDMSReplicationConfig_update
=== PAUSE TestAccDMSReplicationConfig_update
=== RUN   TestAccDMSReplicationConfig_startReplication
=== PAUSE TestAccDMSReplicationConfig_startReplication
=== CONT  TestAccDMSReplicationConfig_basic
=== CONT  TestAccDMSReplicationConfig_startReplication
--- PASS: TestAccDMSReplicationConfig_basic (1492.04s)
=== CONT  TestAccDMSReplicationConfig_update
--- PASS: TestAccDMSReplicationConfig_update (1532.52s)
--- PASS: TestAccDMSReplicationConfig_startReplication (3206.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	3212.085s
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Sep 21, 2023
@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.
I have renamed the new resource to aws_dms_replication_config to match the underlying AWS API.
In general everything looks great -- I just want to add a few more acceptance tests before merging.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDMSReplicationConfig_disappears\|TestAccDMSReplicationConfig_tags' PKG=dms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2  -run=TestAccDMSReplicationConfig_disappears\|TestAccDMSReplicationConfig_tags -timeout 360m
=== RUN   TestAccDMSReplicationConfig_disappears
=== PAUSE TestAccDMSReplicationConfig_disappears
=== RUN   TestAccDMSReplicationConfig_tags
=== PAUSE TestAccDMSReplicationConfig_tags
=== CONT  TestAccDMSReplicationConfig_disappears
=== CONT  TestAccDMSReplicationConfig_tags
--- PASS: TestAccDMSReplicationConfig_tags (1644.31s)
--- PASS: TestAccDMSReplicationConfig_disappears (1599.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	1687.788s
% make testacc TESTARGS='-run=TestAccDMSReplicationConfig_basic\|TestAccDMSReplicationConfig_update\|TestAccDMSReplicationConfig_startReplication' PKG=dms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2  -run=TestAccDMSReplicationConfig_basic\|TestAccDMSReplicationConfig_update\|TestAccDMSReplicationConfig_startReplication -timeout 360m
=== RUN   TestAccDMSReplicationConfig_basic
=== PAUSE TestAccDMSReplicationConfig_basic
=== RUN   TestAccDMSReplicationConfig_update
=== PAUSE TestAccDMSReplicationConfig_update
=== RUN   TestAccDMSReplicationConfig_startReplication
=== PAUSE TestAccDMSReplicationConfig_startReplication
=== CONT  TestAccDMSReplicationConfig_basic
=== CONT  TestAccDMSReplicationConfig_startReplication
--- PASS: TestAccDMSReplicationConfig_basic (1503.43s)
=== CONT  TestAccDMSReplicationConfig_update
--- PASS: TestAccDMSReplicationConfig_startReplication (3061.71s)
--- PASS: TestAccDMSReplicationConfig_update (1562.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	3097.219s

@ewbankkit ewbankkit merged commit a7a008a into hashicorp:main Sep 22, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.19.0 milestone Sep 22, 2023
@hashicorp hashicorp deleted a comment from github-actions bot Sep 26, 2023
@tim-mcmurray
Copy link

I see this was completed. Was the registry documentation updated for this provider on the Terraform website?

@ewbankkit
Copy link
Contributor

Will be released tomorrow, September 28th in Terraform AWS Provider v5.19.0. Registry documentation is updated as part of the release.

@github-actions
Copy link

This functionality has been released in v5.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/dms Issues and PRs that pertain to the dms service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New]: Need DMS Serverless Replication [New Resource]: DMS serverless replication
7 participants