r/aws_autoscaling_group: Add ignore_failed_scaling_activities argument

[ewbankkit]

Description

Adds the ignore_failed_scaling_activities argument to ignore any failed Auto Scaling scaling activities when waiting for capacity.

Relations

Closes #29753.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture\|TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType\|TestAccAutoScalingGroup_withLoadBalancer\|TestAccAutoScalingGroup_simple' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture\|TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType\|TestAccAutoScalingGroup_withLoadBalancer\|TestAccAutoScalingGroup_simple -timeout 180m
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN   TestAccAutoScalingGroup_simple
=== PAUSE TestAccAutoScalingGroup_simple
=== RUN   TestAccAutoScalingGroup_withLoadBalancer
=== PAUSE TestAccAutoScalingGroup_withLoadBalancer
=== RUN   TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType
=== PAUSE TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType
=== RUN   TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture
=== PAUSE TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture
=== RUN   TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture_IgnoreFailedScalingActivities
=== PAUSE TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture_IgnoreFailedScalingActivities
=== RUN   TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture_Recovers
=== PAUSE TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture_Recovers
=== CONT  TestAccAutoScalingGroup_basic
=== CONT  TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture
--- PASS: TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture (33.66s)
=== CONT  TestAccAutoScalingGroup_withLoadBalancer
--- PASS: TestAccAutoScalingGroup_basic (60.20s)
=== CONT  TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType
--- PASS: TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType (32.36s)
=== CONT  TestAccAutoScalingGroup_simple
--- PASS: TestAccAutoScalingGroup_simple (184.50s)
=== CONT  TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture_Recovers
--- PASS: TestAccAutoScalingGroup_withLoadBalancer (285.66s)
=== CONT  TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture_IgnoreFailedScalingActivities
--- PASS: TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture_IgnoreFailedScalingActivities (155.23s)
--- PASS: TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture_Recovers (278.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	560.999s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

$ make testacc TESTARGS='-run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture\|TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType\|TestAccAutoScalingGroup_withLoadBalancer\|TestAccAutoScalingGroup_simple' PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20  -run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture\|TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType\|TestAccAutoScalingGroup_withLoadBalancer\|TestAccAutoScalingGroup_simple -timeout 180m

--- PASS: TestAccAutoScalingGroup_withScalingActivityErrorPlacementGroupNotSupportedOnInstanceType (28.06s)
--- PASS: TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture (28.68s)
--- PASS: TestAccAutoScalingGroup_basic (52.69s)
--- PASS: TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture_IgnoreFailedScalingActivities (152.43s)
--- PASS: TestAccAutoScalingGroup_simple (186.61s)
--- PASS: TestAccAutoScalingGroup_withLoadBalancer (203.88s)
--- PASS: TestAccAutoScalingGroup_withScalingActivityErrorIncorrectInstanceArchitecture_Recovers (246.52s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        249.603s

[github-actions]

This functionality has been released in v5.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[DarwinJS]

@ewbankkit - thanks for this! I can't find this new parameter in the documentation? https://registry.terraform.io/modules/terraform-aws-modules/autoscaling/aws/latest?tab=inputs
Am I missing it somewhere?

[jar-b]

Hi @DarwinJS - the parameter is documented here:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group#ignore_failed_scaling_activities

The link you shared is to a module, which is not managed in this repository. I'd suggest opening an issue there to add support for this new parameter:
https://github.com/terraform-aws-modules/terraform-aws-autoscaling

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.