Update aws_lb resource to cover edge cases with network load balancer security groups.
#32987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/M
terraform-aws-provider
bot
added
the
needs-triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @fhke 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
justinretzolk
added
enhancement
# Conflicts: # website/docs/r/lb.html.markdown
…raffic' argument.
…Balancer_ApplicationLoadBalancer_updatedSecurityGroups'.
…s' and 'TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets'.
…e_link_traffic' argument." This reverts commit 6899de6.
…cer_updateSecurityGroups'.
% git commit -m "Further simplification for 'TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups'." [detached HEAD e2bcfa7] Further simplification for 'TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups'. 1 file changed, 4 insertions(+), 19 deletions(-) ewbankkit@ewbankkit-C02F408DML85 terraform-provider-aws % make testacc TESTARGS='-run=TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups\|TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets' PKG=elbv2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run=TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups\|TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets -timeout 180m === RUN TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups === PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups === RUN TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets === PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets === CONT TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups === CONT TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets --- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets (468.87s) --- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups (761.27s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 766.221s
|
@fhke Thanks for the contribution 🎉 👏. |
ewbankkit
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccELBV2LoadBalancer_' PKG=elbv2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3 -run=TestAccELBV2LoadBalancer_ -timeout 180m
=== RUN TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== RUN TestAccELBV2LoadBalancer_NLB_basic
=== PAUSE TestAccELBV2LoadBalancer_NLB_basic
=== RUN TestAccELBV2LoadBalancer_LoadBalancerType_gateway
=== PAUSE TestAccELBV2LoadBalancer_LoadBalancerType_gateway
=== RUN TestAccELBV2LoadBalancer_disappears
=== PAUSE TestAccELBV2LoadBalancer_disappears
=== RUN TestAccELBV2LoadBalancer_ipv6SubnetMapping
=== PAUSE TestAccELBV2LoadBalancer_ipv6SubnetMapping
=== RUN TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing
=== PAUSE TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing
=== RUN TestAccELBV2LoadBalancer_ALB_outpost
=== PAUSE TestAccELBV2LoadBalancer_ALB_outpost
=== RUN TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== PAUSE TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== RUN TestAccELBV2LoadBalancer_NLB_privateIPv4Address
=== PAUSE TestAccELBV2LoadBalancer_NLB_privateIPv4Address
=== RUN TestAccELBV2LoadBalancer_backwardsCompatibility
=== PAUSE TestAccELBV2LoadBalancer_backwardsCompatibility
=== RUN TestAccELBV2LoadBalancer_generatedName
=== PAUSE TestAccELBV2LoadBalancer_generatedName
=== RUN TestAccELBV2LoadBalancer_generatesNameForZeroValue
=== PAUSE TestAccELBV2LoadBalancer_generatesNameForZeroValue
=== RUN TestAccELBV2LoadBalancer_namePrefix
=== PAUSE TestAccELBV2LoadBalancer_namePrefix
=== RUN TestAccELBV2LoadBalancer_duplicateName
=== PAUSE TestAccELBV2LoadBalancer_duplicateName
=== RUN TestAccELBV2LoadBalancer_tags
=== PAUSE TestAccELBV2LoadBalancer_tags
=== RUN TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatePreserveHostHeader
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatePreserveHostHeader
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWAFFailOpen
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWAFFailOpen
=== RUN TestAccELBV2LoadBalancer_updateIPAddressType
=== PAUSE TestAccELBV2LoadBalancer_updateIPAddressType
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatedSecurityGroups
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatedSecurityGroups
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateSubnets
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateSubnets
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_noSecurityGroup
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_noSecurityGroup
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogs
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogs
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogsPrefix
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogsPrefix
=== RUN TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs
=== RUN TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix
=== RUN TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups
=== RUN TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets
=== RUN TestAccELBV2LoadBalancer_updateDesyncMitigationMode
=== PAUSE TestAccELBV2LoadBalancer_updateDesyncMitigationMode
=== RUN TestAccELBV2LoadBalancer_ALB_updateTLSVersionAndCipherSuite
=== PAUSE TestAccELBV2LoadBalancer_ALB_updateTLSVersionAndCipherSuite
=== RUN TestAccELBV2LoadBalancer_ALB_updateXffHeaderProcessingMode
=== PAUSE TestAccELBV2LoadBalancer_ALB_updateXffHeaderProcessingMode
=== RUN TestAccELBV2LoadBalancer_ALB_updateXffClientPort
=== PAUSE TestAccELBV2LoadBalancer_ALB_updateXffClientPort
=== CONT TestAccELBV2LoadBalancer_ALB_basic
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatePreserveHostHeader
=== CONT TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (168.35s)
=== CONT TestAccELBV2LoadBalancer_ALB_updateXffClientPort
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatePreserveHostHeader (273.38s)
=== CONT TestAccELBV2LoadBalancer_ALB_updateXffHeaderProcessingMode
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs (415.13s)
=== CONT TestAccELBV2LoadBalancer_ALB_updateTLSVersionAndCipherSuite
--- PASS: TestAccELBV2LoadBalancer_ALB_updateXffClientPort (334.01s)
=== CONT TestAccELBV2LoadBalancer_updateDesyncMitigationMode
--- PASS: TestAccELBV2LoadBalancer_ALB_updateXffHeaderProcessingMode (357.28s)
=== CONT TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets
--- PASS: TestAccELBV2LoadBalancer_ALB_updateTLSVersionAndCipherSuite (321.78s)
=== CONT TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups
--- PASS: TestAccELBV2LoadBalancer_updateDesyncMitigationMode (287.74s)
=== CONT TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSubnets (462.19s)
=== CONT TestAccELBV2LoadBalancer_backwardsCompatibility
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix (335.67s)
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields
--- PASS: TestAccELBV2LoadBalancer_backwardsCompatibility (173.13s)
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields (268.36s)
=== CONT TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups (730.63s)
=== CONT TestAccELBV2LoadBalancer_tags
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2 (289.45s)
=== CONT TestAccELBV2LoadBalancer_duplicateName
--- PASS: TestAccELBV2LoadBalancer_duplicateName (169.17s)
=== CONT TestAccELBV2LoadBalancer_namePrefix
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone (341.77s)
=== CONT TestAccELBV2LoadBalancer_generatesNameForZeroValue
--- PASS: TestAccELBV2LoadBalancer_tags (276.76s)
=== CONT TestAccELBV2LoadBalancer_generatedName
--- PASS: TestAccELBV2LoadBalancer_namePrefix (153.19s)
=== CONT TestAccELBV2LoadBalancer_updateIPAddressType
--- PASS: TestAccELBV2LoadBalancer_generatesNameForZeroValue (162.66s)
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatedSecurityGroups
--- PASS: TestAccELBV2LoadBalancer_generatedName (164.99s)
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWAFFailOpen
--- PASS: TestAccELBV2LoadBalancer_updateIPAddressType (230.50s)
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatedSecurityGroups (228.62s)
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateSubnets
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWAFFailOpen (280.81s)
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_noSecurityGroup
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection (273.82s)
=== CONT TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateSubnets (207.82s)
=== CONT TestAccELBV2LoadBalancer_NLB_privateIPv4Address
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_noSecurityGroup (169.94s)
=== CONT TestAccELBV2LoadBalancer_networkLoadBalancerEIP
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing (263.34s)
=== CONT TestAccELBV2LoadBalancer_ALB_outpost
acctest.go:1101: skipping since no Outposts found
--- SKIP: TestAccELBV2LoadBalancer_ALB_outpost (0.50s)
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogsPrefix
--- PASS: TestAccELBV2LoadBalancer_NLB_privateIPv4Address (253.09s)
=== CONT TestAccELBV2LoadBalancer_disappears
--- PASS: TestAccELBV2LoadBalancer_networkLoadBalancerEIP (249.27s)
--- PASS: TestAccELBV2LoadBalancer_ipv6SubnetMapping (264.58s)
=== CONT TestAccELBV2LoadBalancer_LoadBalancerType_gateway
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogsPrefix (271.55s)
=== CONT TestAccELBV2LoadBalancer_NLB_basic
--- PASS: TestAccELBV2LoadBalancer_disappears (156.41s)
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogs
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerType_gateway (203.53s)
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (210.05s)
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogs (385.75s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 3135.106s
|
This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AWS recently introduced support for security groups with network load balancers. While the
aws_lbresource is already largely compatible with this change, there are two cases not currently covered by the Terraform provider:These actions are not supported by the AWS API, and will cause a
ValidationErrorresponse if they are attempted. This PR forces the resource to be recreated if either of these changes are attempted.This PR also contains an update to the docs to reflect the AWS update, and the behaviour introduced.
Relations
Closes #32982
References