Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add computed field for asset_id attribute #33142

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

silvaalbert
Copy link
Contributor

@silvaalbert silvaalbert commented Aug 22, 2023

Description

Fixes bug in issue #33140 by setting the asset_id field to Computed

Relations

Closes #33140

Output from Acceptance Testing

make testacc TESTS=TestAccEC2Host_outpostAssetId PKG=ec2 ACCTEST_PARALLELISM=5  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5 -run='TestAccEC2Host_outpostAssetId'  -timeout 180m
=== RUN   TestAccEC2Host_outpostAssetId
=== PAUSE TestAccEC2Host_outpostAssetId
=== CONT  TestAccEC2Host_outpostAssetId
--- PASS: TestAccEC2Host_outpostAssetId (23.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	27.031s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Aug 22, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Aug 22, 2023
@silvaalbert silvaalbert marked this pull request as ready for review August 22, 2023 18:02
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 22, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=^TestAccEC2Host_basic$$' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=^TestAccEC2Host_basic$ -timeout 180m
=== RUN   TestAccEC2Host_basic
=== PAUSE TestAccEC2Host_basic
=== CONT  TestAccEC2Host_basic
--- PASS: TestAccEC2Host_basic (67.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	73.267s

@ewbankkit
Copy link
Contributor

@silvaalbert Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f8bd269 into hashicorp:main Aug 23, 2023
49 checks passed
@github-actions github-actions bot added this to the v5.14.0 milestone Aug 23, 2023
@github-actions
Copy link

This functionality has been released in v5.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partner Contribution from a partner. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_ec2_host attempts to replace resource when an outpost_arn is specified without an asset_id
4 participants