Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMS: Fix acceptance test failures #33158

Merged
merged 32 commits into from
Aug 23, 2023
Merged

DMS: Fix acceptance test failures #33158

merged 32 commits into from
Aug 23, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 23, 2023

Description

In CI:

=== RUN   TestAccDMSReplicationInstanceDataSource_basic
=== PAUSE TestAccDMSReplicationInstanceDataSource_basic
=== CONT  TestAccDMSReplicationInstanceDataSource_basic
    replication_instance_data_source_test.go:23: Step 1/1 error: Error running apply: exit status 1
        Error: creating DMS Replication Instance: ResourceNotFoundFault: Some of the subnet id(s) are invalid: [subnet-0b8d5cdfe51619590, subnet-0b823ecfe2dfcee09, subnet-0ba7e7e3b57ece13c]:The subnet ID 'subnet-0b823ecfe2dfcee09' does not exist (Service: AmazonEC2; Status Code: 400; Error Code: InvalidSubnetID.NotFound; Request ID: 38e25c31-1b48-4571-99af-35f422b47d3d; Proxy: null), rid=38e25c31-1b48-4571-99af-35f422b47d3d
          with aws_dms_replication_instance.test,
          on terraform_plugin_test.tf line 2, in resource "aws_dms_replication_instance" "test":
           2: resource "aws_dms_replication_instance" "test" {
--- FAIL: TestAccDMSReplicationInstanceDataSource_basic (92.13s)

Adds IPv6 support.

Relations

Closes #25191.
Closes #33139.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccDMSReplicationSubnetGroup_' PKG=dms 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSReplicationSubnetGroup_ -timeout 180m
=== RUN   TestAccDMSReplicationSubnetGroup_basic
=== PAUSE TestAccDMSReplicationSubnetGroup_basic
=== RUN   TestAccDMSReplicationSubnetGroup_disappears
=== PAUSE TestAccDMSReplicationSubnetGroup_disappears
=== RUN   TestAccDMSReplicationSubnetGroup_tags
=== PAUSE TestAccDMSReplicationSubnetGroup_tags
=== CONT  TestAccDMSReplicationSubnetGroup_basic
=== CONT  TestAccDMSReplicationSubnetGroup_tags
=== CONT  TestAccDMSReplicationSubnetGroup_disappears
--- PASS: TestAccDMSReplicationSubnetGroup_disappears (34.82s)
--- PASS: TestAccDMSReplicationSubnetGroup_basic (62.80s)
--- PASS: TestAccDMSReplicationSubnetGroup_tags (84.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	89.273s
% make testacc TESTARGS='-run=TestAccDMSReplicationInstance_' PKG=dms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 3  -run=TestAccDMSReplicationInstance_ -timeout 180m
=== RUN   TestAccDMSReplicationInstance_basic
=== PAUSE TestAccDMSReplicationInstance_basic
=== RUN   TestAccDMSReplicationInstance_disappears
=== PAUSE TestAccDMSReplicationInstance_disappears
=== RUN   TestAccDMSReplicationInstance_allocatedStorage
=== PAUSE TestAccDMSReplicationInstance_allocatedStorage
=== RUN   TestAccDMSReplicationInstance_autoMinorVersionUpgrade
=== PAUSE TestAccDMSReplicationInstance_autoMinorVersionUpgrade
=== RUN   TestAccDMSReplicationInstance_availabilityZone
=== PAUSE TestAccDMSReplicationInstance_availabilityZone
=== RUN   TestAccDMSReplicationInstance_kmsKeyARN
=== PAUSE TestAccDMSReplicationInstance_kmsKeyARN
=== RUN   TestAccDMSReplicationInstance_multiAz
=== PAUSE TestAccDMSReplicationInstance_multiAz
=== RUN   TestAccDMSReplicationInstance_preferredMaintenanceWindow
=== PAUSE TestAccDMSReplicationInstance_preferredMaintenanceWindow
=== RUN   TestAccDMSReplicationInstance_publiclyAccessible
=== PAUSE TestAccDMSReplicationInstance_publiclyAccessible
=== RUN   TestAccDMSReplicationInstance_replicationInstanceClass
=== PAUSE TestAccDMSReplicationInstance_replicationInstanceClass
=== RUN   TestAccDMSReplicationInstance_tags
=== PAUSE TestAccDMSReplicationInstance_tags
=== RUN   TestAccDMSReplicationInstance_vpcSecurityGroupIDs
=== PAUSE TestAccDMSReplicationInstance_vpcSecurityGroupIDs
=== CONT  TestAccDMSReplicationInstance_basic
=== CONT  TestAccDMSReplicationInstance_multiAz
=== CONT  TestAccDMSReplicationInstance_replicationInstanceClass
--- PASS: TestAccDMSReplicationInstance_basic (804.98s)
=== CONT  TestAccDMSReplicationInstance_vpcSecurityGroupIDs
--- PASS: TestAccDMSReplicationInstance_replicationInstanceClass (1609.62s)
=== CONT  TestAccDMSReplicationInstance_tags
--- PASS: TestAccDMSReplicationInstance_vpcSecurityGroupIDs (926.64s)
=== CONT  TestAccDMSReplicationInstance_publiclyAccessible
--- PASS: TestAccDMSReplicationInstance_publiclyAccessible (969.26s)
=== CONT  TestAccDMSReplicationInstance_preferredMaintenanceWindow
--- PASS: TestAccDMSReplicationInstance_tags (1000.23s)
=== CONT  TestAccDMSReplicationInstance_autoMinorVersionUpgrade
--- PASS: TestAccDMSReplicationInstance_preferredMaintenanceWindow (946.24s)
=== CONT  TestAccDMSReplicationInstance_kmsKeyARN
--- PASS: TestAccDMSReplicationInstance_multiAz (3550.08s)
=== CONT  TestAccDMSReplicationInstance_availabilityZone
--- PASS: TestAccDMSReplicationInstance_autoMinorVersionUpgrade (1010.39s)
=== CONT  TestAccDMSReplicationInstance_allocatedStorage
--- PASS: TestAccDMSReplicationInstance_kmsKeyARN (947.38s)
=== CONT  TestAccDMSReplicationInstance_disappears
--- PASS: TestAccDMSReplicationInstance_availabilityZone (895.42s)
--- PASS: TestAccDMSReplicationInstance_disappears (848.81s)
--- PASS: TestAccDMSReplicationInstance_allocatedStorage (1530.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	5155.662s
% make testacc TESTARGS='-run=TestAccDMSReplicationInstanceDataSource_basic\|TestAccDMSReplicationInstance_basic\|TestAccDMSReplicationInstance_networkType' PKG=dms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 3  -run=TestAccDMSReplicationInstanceDataSource_basic\|TestAccDMSReplicationInstance_basic\|TestAccDMSReplicationInstance_networkType -timeout 180m
=== RUN   TestAccDMSReplicationInstanceDataSource_basic
=== PAUSE TestAccDMSReplicationInstanceDataSource_basic
=== RUN   TestAccDMSReplicationInstance_basic
=== PAUSE TestAccDMSReplicationInstance_basic
=== RUN   TestAccDMSReplicationInstance_networkType
=== PAUSE TestAccDMSReplicationInstance_networkType
=== CONT  TestAccDMSReplicationInstanceDataSource_basic
=== CONT  TestAccDMSReplicationInstance_networkType
=== CONT  TestAccDMSReplicationInstance_basic
--- PASS: TestAccDMSReplicationInstance_basic (879.23s)
--- PASS: TestAccDMSReplicationInstanceDataSource_basic (887.15s)
--- PASS: TestAccDMSReplicationInstance_networkType (1208.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	1049.496s
% make testacc TESTARGS='-run=TestAccDMSReplicationInstance_engineVersion' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSReplicationInstance_engineVersion -timeout 180m
=== RUN   TestAccDMSReplicationInstance_engineVersion
=== PAUSE TestAccDMSReplicationInstance_engineVersion
=== CONT  TestAccDMSReplicationInstance_engineVersion
--- PASS: TestAccDMSReplicationInstance_engineVersion (1519.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	1524.537s
% make testacc TESTARGS='-run=TestAccDMSEndpointDataSource_basic' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSEndpointDataSource_basic -timeout 180m
=== RUN   TestAccDMSEndpointDataSource_basic
=== PAUSE TestAccDMSEndpointDataSource_basic
=== CONT  TestAccDMSEndpointDataSource_basic
--- PASS: TestAccDMSEndpointDataSource_basic (35.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	40.730s

Acceptance test output:

% make testacc TESTARGS='-run=TestAccDMSReplicationSubnetGroup_basic' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSReplicationSubnetGroup_basic -timeout 180m
=== RUN   TestAccDMSReplicationSubnetGroup_basic
=== PAUSE TestAccDMSReplicationSubnetGroup_basic
=== CONT  TestAccDMSReplicationSubnetGroup_basic
--- PASS: TestAccDMSReplicationSubnetGroup_basic (56.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	61.156s
% make testacc TESTARGS='-run=TestAccDMSReplicationSubnetGroup_' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSReplicationSubnetGroup_ -timeout 180m
=== RUN   TestAccDMSReplicationSubnetGroup_basic
=== PAUSE TestAccDMSReplicationSubnetGroup_basic
=== RUN   TestAccDMSReplicationSubnetGroup_disappears
=== PAUSE TestAccDMSReplicationSubnetGroup_disappears
=== RUN   TestAccDMSReplicationSubnetGroup_tags
=== PAUSE TestAccDMSReplicationSubnetGroup_tags
=== CONT  TestAccDMSReplicationSubnetGroup_basic
=== CONT  TestAccDMSReplicationSubnetGroup_tags
=== CONT  TestAccDMSReplicationSubnetGroup_disappears
--- PASS: TestAccDMSReplicationSubnetGroup_disappears (34.82s)
--- PASS: TestAccDMSReplicationSubnetGroup_basic (62.80s)
--- PASS: TestAccDMSReplicationSubnetGroup_tags (84.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	89.273s
% make testacc TESTARGS='-run=TestAccDMSReplicationSubnetGroupDataSource_' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSReplicationSubnetGroupDataSource_ -timeout 180m
=== RUN   TestAccDMSReplicationSubnetGroupDataSource_basic
=== PAUSE TestAccDMSReplicationSubnetGroupDataSource_basic
=== CONT  TestAccDMSReplicationSubnetGroupDataSource_basic
--- PASS: TestAccDMSReplicationSubnetGroupDataSource_basic (31.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	36.458s
…sappears'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccDMSReplicationInstance_disappears' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSReplicationInstance_disappears -timeout 180m
=== RUN   TestAccDMSReplicationInstance_disappears
=== PAUSE TestAccDMSReplicationInstance_disappears
=== CONT  TestAccDMSReplicationInstance_disappears
--- PASS: TestAccDMSReplicationInstance_disappears (830.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	835.639s
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Aug 23, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. service/dms Issues and PRs that pertain to the dms service. labels Aug 23, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 23, 2023
@ewbankkit ewbankkit merged commit 2ebfc34 into main Aug 23, 2023
61 checks passed
@ewbankkit ewbankkit deleted the t-dms-failures branch August 23, 2023 18:35
@github-actions github-actions bot added this to the v5.14.0 milestone Aug 23, 2023
github-actions bot pushed a commit that referenced this pull request Aug 23, 2023
@github-actions
Copy link

This functionality has been released in v5.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/dms Issues and PRs that pertain to the dms service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants