Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_codeartifact_domain: fix error with asset_size_bytes size #33220

Merged
merged 5 commits into from
Aug 29, 2023
Merged

r/aws_codeartifact_domain: fix error with asset_size_bytes size #33220

merged 5 commits into from
Aug 29, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Aug 29, 2023 •
edited
Loading

Description

Relations

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccCodeArtifact_serial/^Domain/$' PKG=codeartifact

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codeartifact/... -v -count 1 -parallel 20  -run=TestAccCodeArtifact_serial/^Domain/ -timeout 180m
--- PASS: TestAccCodeArtifact_serial (377.54s)
    --- PASS: TestAccCodeArtifact_serial/Domain (207.51s)
        --- PASS: TestAccCodeArtifact_serial/Domain/tags (68.48s)
        --- PASS: TestAccCodeArtifact_serial/Domain/basic (29.88s)
        --- PASS: TestAccCodeArtifact_serial/Domain/defaultEncryptionKey (28.65s)
        --- PASS: TestAccCodeArtifact_serial/Domain/disappears (24.28s)
        --- PASS: TestAccCodeArtifact_serial/Domain/migrateAssetSizeBytesToString (56.21s)
    --- PASS: TestAccCodeArtifact_serial/DomainPermissionsPolicy (170.04s)
        --- PASS: TestAccCodeArtifact_serial/DomainPermissionsPolicy/disappearsDomain (25.14s)
        --- PASS: TestAccCodeArtifact_serial/DomainPermissionsPolicy/ignoreEquivalent (38.82s)
        --- PASS: TestAccCodeArtifact_serial/DomainPermissionsPolicy/basic (49.81s)
        --- PASS: TestAccCodeArtifact_serial/DomainPermissionsPolicy/disappears (26.29s)
        --- PASS: TestAccCodeArtifact_serial/DomainPermissionsPolicy/owner (29.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codeartifact	381.096s

misak113 and others added 4 commits August 9, 2023 12:55
@misak113
Change the type of aws_codeartifact_domain asset_size_bytes to float …
835d577 
…(64) instead of int (32)

Because this value can get really big and the Integer (signed 32 size) can overflow. The maximum int32 value is 2147483647. See https://pkg.go.dev/builtin#int
That is roughly 2 GBi of data that is easy to reach.

Example of error:
```
panic: Error reading level state: strconv.ParseInt: parsing "15679188538": value out of range
```
@johnsonaj
Merge branch 'b-aws-codeartifact-domain-asset_size_bytes' into b-aws_…
de670bf 
…codeartifact_domain
@johnsonaj
aws_codeartifact_domain: use TypeString
1032b91
@johnsonaj
aws_codeartifact_domain: add test
bf339fa
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codeartifact Issues and PRs that pertain to the codeartifact service. labels Aug 29, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 29, 2023
@johnsonaj
Copy link
Contributor Author

Closes #32926

@johnsonaj johnsonaj merged commit 17e1e3a into main Aug 29, 2023
36 checks passed
@johnsonaj johnsonaj deleted the b-aws_codeartifact_domain branch August 29, 2023 17:09
@github-actions github-actions bot added this to the v5.15.0 milestone Aug 29, 2023
github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
Update CHANGELOG.md for #33220
cf53100
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This functionality has been released in v5.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/codeartifact Issues and PRs that pertain to the codeartifact service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnsonaj @misak113