Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource - OpenSearch Package & OpenSearch Package Association #33227

Merged
merged 37 commits into from
Sep 19, 2023

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Aug 29, 2023

Description

Adds 2 new resources:

  • aws_opensearch_package
  • aws_opensearch_package_association

Relations

Closes #32648

References

Output from Acceptance Testing

make testacc TESTS=TestAccOpenSearchPackage PKG=opensearch

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/opensearch Issues and PRs that pertain to the opensearch service. labels Aug 29, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Aug 29, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 30, 2023
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. size/L Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. labels Sep 7, 2023
@bschaatsbergen bschaatsbergen marked this pull request as ready for review September 18, 2023 19:47
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Sep 18, 2023
@ewbankkit ewbankkit self-assigned this Sep 19, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 19, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOpenSearchPackage_\|TestAccOpenSearchPackageAssociation_' PKG=opensearch ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 2  -run=TestAccOpenSearchPackage_\|TestAccOpenSearchPackageAssociation_ -timeout 180m
=== RUN   TestAccOpenSearchPackageAssociation_basic
=== PAUSE TestAccOpenSearchPackageAssociation_basic
=== RUN   TestAccOpenSearchPackageAssociation_disappears
=== PAUSE TestAccOpenSearchPackageAssociation_disappears
=== RUN   TestAccOpenSearchPackage_basic
=== PAUSE TestAccOpenSearchPackage_basic
=== RUN   TestAccOpenSearchPackage_disappears
=== PAUSE TestAccOpenSearchPackage_disappears
=== CONT  TestAccOpenSearchPackageAssociation_basic
=== CONT  TestAccOpenSearchPackage_basic
--- PASS: TestAccOpenSearchPackage_basic (47.67s)
=== CONT  TestAccOpenSearchPackage_disappears
--- PASS: TestAccOpenSearchPackage_disappears (41.82s)
=== CONT  TestAccOpenSearchPackageAssociation_disappears
--- PASS: TestAccOpenSearchPackageAssociation_basic (1954.50s)
--- PASS: TestAccOpenSearchPackageAssociation_disappears (2063.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	2158.910s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c9115e6 into hashicorp:main Sep 19, 2023
60 checks passed
@github-actions github-actions bot added this to the v5.18.0 milestone Sep 19, 2023
@bschaatsbergen bschaatsbergen deleted the opensearch-package branch September 19, 2023 17:07
@github-actions
Copy link

This functionality has been released in v5.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/opensearch Issues and PRs that pertain to the opensearch service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New resource]: Manage AWS OpenSearch custom packages and cluster associations
3 participants