Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSx Windows acceptance tests fixes and enhancements #33303

Merged
merged 21 commits into from
Sep 5, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 5, 2023

Description

Relations

Relates #33245.

References

Output from Acceptance Testing

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxWindowsFileSystem_\|TestAccFSxWindowsFileSystemDataSource_' PKG=fsx ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 3  -run=TestAccFSxWindowsFileSystem_\|TestAccFSxWindowsFileSystemDataSource_ -timeout 720m
=== RUN   TestAccFSxWindowsFileSystemDataSource_basic
=== PAUSE TestAccFSxWindowsFileSystemDataSource_basic
=== RUN   TestAccFSxWindowsFileSystem_basic
=== PAUSE TestAccFSxWindowsFileSystem_basic
=== RUN   TestAccFSxWindowsFileSystem_disappears
=== PAUSE TestAccFSxWindowsFileSystem_disappears
=== RUN   TestAccFSxWindowsFileSystem_singleAz2
=== PAUSE TestAccFSxWindowsFileSystem_singleAz2
=== RUN   TestAccFSxWindowsFileSystem_storageTypeHdd
=== PAUSE TestAccFSxWindowsFileSystem_storageTypeHdd
=== RUN   TestAccFSxWindowsFileSystem_multiAz
=== PAUSE TestAccFSxWindowsFileSystem_multiAz
=== RUN   TestAccFSxWindowsFileSystem_aliases
=== PAUSE TestAccFSxWindowsFileSystem_aliases
=== RUN   TestAccFSxWindowsFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccFSxWindowsFileSystem_automaticBackupRetentionDays
=== RUN   TestAccFSxWindowsFileSystem_copyTagsToBackups
=== PAUSE TestAccFSxWindowsFileSystem_copyTagsToBackups
=== RUN   TestAccFSxWindowsFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccFSxWindowsFileSystem_dailyAutomaticBackupStartTime
=== RUN   TestAccFSxWindowsFileSystem_kmsKeyID
=== PAUSE TestAccFSxWindowsFileSystem_kmsKeyID
=== RUN   TestAccFSxWindowsFileSystem_securityGroupIDs
=== PAUSE TestAccFSxWindowsFileSystem_securityGroupIDs
=== RUN   TestAccFSxWindowsFileSystem_selfManagedActiveDirectory
=== PAUSE TestAccFSxWindowsFileSystem_selfManagedActiveDirectory
=== RUN   TestAccFSxWindowsFileSystem_storageCapacity
=== PAUSE TestAccFSxWindowsFileSystem_storageCapacity
=== RUN   TestAccFSxWindowsFileSystem_fromBackup
=== PAUSE TestAccFSxWindowsFileSystem_fromBackup
=== RUN   TestAccFSxWindowsFileSystem_tags
=== PAUSE TestAccFSxWindowsFileSystem_tags
=== RUN   TestAccFSxWindowsFileSystem_throughputCapacity
=== PAUSE TestAccFSxWindowsFileSystem_throughputCapacity
=== RUN   TestAccFSxWindowsFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccFSxWindowsFileSystem_weeklyMaintenanceStartTime
=== RUN   TestAccFSxWindowsFileSystem_audit
=== PAUSE TestAccFSxWindowsFileSystem_audit
=== RUN   TestAccFSxWindowsFileSystem_diskIops
=== PAUSE TestAccFSxWindowsFileSystem_diskIops
=== CONT  TestAccFSxWindowsFileSystemDataSource_basic
=== CONT  TestAccFSxWindowsFileSystem_securityGroupIDs
=== CONT  TestAccFSxWindowsFileSystem_diskIops
--- PASS: TestAccFSxWindowsFileSystemDataSource_basic (3155.18s)
=== CONT  TestAccFSxWindowsFileSystem_audit
--- PASS: TestAccFSxWindowsFileSystem_diskIops (3320.59s)
=== CONT  TestAccFSxWindowsFileSystem_weeklyMaintenanceStartTime
--- PASS: TestAccFSxWindowsFileSystem_securityGroupIDs (4413.74s)
=== CONT  TestAccFSxWindowsFileSystem_throughputCapacity
--- PASS: TestAccFSxWindowsFileSystem_audit (3287.96s)
=== CONT  TestAccFSxWindowsFileSystem_tags
--- PASS: TestAccFSxWindowsFileSystem_weeklyMaintenanceStartTime (3313.12s)
=== CONT  TestAccFSxWindowsFileSystem_fromBackup
--- PASS: TestAccFSxWindowsFileSystem_throughputCapacity (4140.95s)
=== CONT  TestAccFSxWindowsFileSystem_storageCapacity
--- PASS: TestAccFSxWindowsFileSystem_tags (3283.24s)
--- PASS: TestAccFSxWindowsFileSystem_fromBackup (4589.95s)
=== CONT  TestAccFSxWindowsFileSystem_selfManagedActiveDirectory
--- PASS: TestAccFSxWindowsFileSystem_storageCapacity (4470.87s)
=== CONT  TestAccFSxWindowsFileSystem_singleAz2
--- PASS: TestAccFSxWindowsFileSystem_selfManagedActiveDirectory (2971.56s)
=== CONT  TestAccFSxWindowsFileSystem_multiAz
=== CONT  TestAccFSxWindowsFileSystem_storageTypeHdd
--- PASS: TestAccFSxWindowsFileSystem_singleAz2 (3884.74s)
=== CONT  TestAccFSxWindowsFileSystem_aliases
--- PASS: TestAccFSxWindowsFileSystem_multiAz (4844.22s)
=== CONT  TestAccFSxWindowsFileSystem_disappears
--- PASS: TestAccFSxWindowsFileSystem_storageTypeHdd (3809.14s)
=== CONT  TestAccFSxWindowsFileSystem_kmsKeyID
--- PASS: TestAccFSxWindowsFileSystem_aliases (3550.46s)
=== CONT  TestAccFSxWindowsFileSystem_basic
--- PASS: TestAccFSxWindowsFileSystem_disappears (3249.87s)
=== CONT  TestAccFSxWindowsFileSystem_copyTagsToBackups
--- PASS: TestAccFSxWindowsFileSystem_basic (2929.42s)
=== CONT  TestAccFSxWindowsFileSystem_automaticBackupRetentionDays
--- PASS: TestAccFSxWindowsFileSystem_kmsKeyID (4259.69s)
=== CONT  TestAccFSxWindowsFileSystem_dailyAutomaticBackupStartTime
--- PASS: TestAccFSxWindowsFileSystem_copyTagsToBackups (4280.77s)
--- PASS: TestAccFSxWindowsFileSystem_automaticBackupRetentionDays (3151.62s)
--- PASS: TestAccFSxWindowsFileSystem_dailyAutomaticBackupStartTime (3341.69s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	26666.327s

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/fsx Issues and PRs that pertain to the fsx service. size/XL Managed by automation to categorize the size of a PR. labels Sep 5, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 5, 2023
@ewbankkit ewbankkit merged commit f36f9df into main Sep 5, 2023
61 checks passed
@ewbankkit ewbankkit deleted the f-aws_fsx_windows_file_system-additions branch September 5, 2023 13:21
@github-actions github-actions bot added this to the v5.16.0 milestone Sep 5, 2023
github-actions bot pushed a commit that referenced this pull request Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/fsx Issues and PRs that pertain to the fsx service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant