Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_db_instance_automated_backups_replication: Guard against status code capitalization changes #33369

Merged

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 8, 2023

Description

Guard against unannounced status code capitalization changes.

Relations

Closes #33354.
Closes #33362.
Relates #32597.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRDSInstanceAutomatedBackupsReplication_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstanceAutomatedBackupsReplication_ -timeout 180m
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_basic
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_basic
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_disappears
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_disappears
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_basic
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod (1334.72s)
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_disappears
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_basic (1342.79s)
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_disappears (1447.62s)
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted (1532.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2880.353s

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Sep 8, 2023
@github-actions github-actions bot added the service/rds Issues and PRs that pertain to the rds service. label Sep 8, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 8, 2023
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Sep 8, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

% make testacc TESTARGS='-run=TestAccRDSInstanceAutomatedBackupsReplication_' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSInstanceAutomatedBackupsReplication_ -timeout 180m

--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod (1171.42s)
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_basic (1201.17s)
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_disappears (1206.67s)
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted (1464.45s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1467.651s

@ewbankkit ewbankkit merged commit 0118993 into main Sep 8, 2023
61 checks passed
@ewbankkit ewbankkit deleted the b-aws_db_instance_automated_backups_replication-status-codes branch September 8, 2023 17:33
@github-actions github-actions bot added this to the v5.17.0 milestone Sep 8, 2023
github-actions bot pushed a commit that referenced this pull request Sep 8, 2023
@ewbankkit ewbankkit modified the milestones: v5.17.0, v5.16.1 Sep 8, 2023
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Sep 11, 2023
@github-actions
Copy link

This functionality has been released in v5.16.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants