Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F add json attribute to patch baseline resource #33402

Merged

Conversation

stromp
Copy link
Contributor

@stromp stromp commented Sep 11, 2023

Description

Adding the json attribute to the patch_baseline resource. In order to define custom baselines in aws you need to be able to upload the s3 definition of the patchbaseline to an S3 bucket. The json definition facilitates in creating a pattern in terraform to do this.

Closes #33565.

Output from Acceptance Testing

make testacc TESTS=TestAccSSMPatchBaseline_basic PKG=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMPatchBaseline_basic'  -timeout 180m
=== RUN   TestAccSSMPatchBaseline_basic
=== PAUSE TestAccSSMPatchBaseline_basic
=== CONT  TestAccSSMPatchBaseline_basic
--- PASS: TestAccSSMPatchBaseline_basic (80.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        81.424smake testacc TESTS=TestAccSSMPatchBaselineDataSource_existingBaseline PKG=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMPatchBaselineDataSource_existingBaseline'  -timeout 180m
=== RUN   TestAccSSMPatchBaselineDataSource_existingBaseline
=== PAUSE TestAccSSMPatchBaselineDataSource_existingBaseline
=== CONT  TestAccSSMPatchBaselineDataSource_existingBaseline
--- PASS: TestAccSSMPatchBaselineDataSource_existingBaseline (47.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        49.661s
    

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ssm Issues and PRs that pertain to the ssm service. labels Sep 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 11, 2023
@stromp stromp marked this pull request as ready for review September 11, 2023 14:43
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 11, 2023
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Sep 21, 2023
@YakDriver YakDriver force-pushed the f-add-json-attribute-to-patch-baseline-resource branch from 8487bdc to 557650a Compare January 20, 2024 00:34
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make t T='TestAccSSMPatchBaselineDataSource_|TestAccSSMPatchBaseline_' K=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMPatchBaselineDataSource_|TestAccSSMPatchBaseline_'  -timeout 360m
=== RUN   TestAccSSMPatchBaselineDataSource_existingBaseline
=== PAUSE TestAccSSMPatchBaselineDataSource_existingBaseline
=== RUN   TestAccSSMPatchBaselineDataSource_newBaseline
=== PAUSE TestAccSSMPatchBaselineDataSource_newBaseline
=== RUN   TestAccSSMPatchBaseline_basic
=== PAUSE TestAccSSMPatchBaseline_basic
=== RUN   TestAccSSMPatchBaseline_tags
=== PAUSE TestAccSSMPatchBaseline_tags
=== RUN   TestAccSSMPatchBaseline_disappears
=== PAUSE TestAccSSMPatchBaseline_disappears
=== RUN   TestAccSSMPatchBaseline_operatingSystem
=== PAUSE TestAccSSMPatchBaseline_operatingSystem
=== RUN   TestAccSSMPatchBaseline_approveUntilDateParam
=== PAUSE TestAccSSMPatchBaseline_approveUntilDateParam
=== RUN   TestAccSSMPatchBaseline_sources
=== PAUSE TestAccSSMPatchBaseline_sources
=== RUN   TestAccSSMPatchBaseline_approvedPatchesNonSec
=== PAUSE TestAccSSMPatchBaseline_approvedPatchesNonSec
=== RUN   TestAccSSMPatchBaseline_rejectPatchesAction
=== PAUSE TestAccSSMPatchBaseline_rejectPatchesAction
=== CONT  TestAccSSMPatchBaselineDataSource_existingBaseline
=== CONT  TestAccSSMPatchBaseline_operatingSystem
=== CONT  TestAccSSMPatchBaseline_tags
=== CONT  TestAccSSMPatchBaseline_basic
=== CONT  TestAccSSMPatchBaseline_disappears
=== CONT  TestAccSSMPatchBaseline_approvedPatchesNonSec
=== CONT  TestAccSSMPatchBaseline_approveUntilDateParam
=== CONT  TestAccSSMPatchBaseline_rejectPatchesAction
=== CONT  TestAccSSMPatchBaselineDataSource_newBaseline
=== CONT  TestAccSSMPatchBaseline_sources
--- PASS: TestAccSSMPatchBaselineDataSource_existingBaseline (17.37s)
--- PASS: TestAccSSMPatchBaselineDataSource_newBaseline (24.04s)
--- PASS: TestAccSSMPatchBaseline_disappears (24.62s)
--- PASS: TestAccSSMPatchBaseline_approvedPatchesNonSec (28.50s)
--- PASS: TestAccSSMPatchBaseline_rejectPatchesAction (28.65s)
--- PASS: TestAccSSMPatchBaseline_sources (41.26s)
--- PASS: TestAccSSMPatchBaseline_approveUntilDateParam (41.39s)
--- PASS: TestAccSSMPatchBaseline_basic (41.53s)
--- PASS: TestAccSSMPatchBaseline_operatingSystem (41.65s)
--- PASS: TestAccSSMPatchBaseline_tags (50.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	52.979s

@YakDriver YakDriver self-assigned this Jan 20, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 20, 2024
@YakDriver YakDriver merged commit cd58d59 into hashicorp:main Jan 20, 2024
62 checks passed
@github-actions github-actions bot added this to the v5.34.0 milestone Jan 20, 2024
Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ssm Issues and PRs that pertain to the ssm service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add json attribute to patch baseline resource
3 participants