r/aws_neptune_cluster_instance: remove engine_version as ForceNew parameter and fixed default cluster parameter behavior. #33487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XS
terraform-aws-provider
bot
added
needs-triage
jar-b
removed
the
needs-triage
Added new test to ensure parameters with default values are ignored. Updated existing tests that were referencing deprecated engine versions.
github-actions
bot
added
size/M
triggan
changed the title
ewbankkit
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
LGTM 🚀.
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccNeptuneClusterParameterGroup_\|TestAccNeptuneClusterInstance_' PKG=neptune ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 3 -run=TestAccNeptuneClusterParameterGroup_\|TestAccNeptuneClusterInstance_ -timeout 720m
=== RUN TestAccNeptuneClusterInstance_basic
=== PAUSE TestAccNeptuneClusterInstance_basic
=== RUN TestAccNeptuneClusterInstance_disappears
=== PAUSE TestAccNeptuneClusterInstance_disappears
=== RUN TestAccNeptuneClusterInstance_nameGenerated
=== PAUSE TestAccNeptuneClusterInstance_nameGenerated
=== RUN TestAccNeptuneClusterInstance_namePrefix
=== PAUSE TestAccNeptuneClusterInstance_namePrefix
=== RUN TestAccNeptuneClusterInstance_tags
=== PAUSE TestAccNeptuneClusterInstance_tags
=== RUN TestAccNeptuneClusterInstance_withAZ
=== PAUSE TestAccNeptuneClusterInstance_withAZ
=== RUN TestAccNeptuneClusterInstance_withSubnetGroup
=== PAUSE TestAccNeptuneClusterInstance_withSubnetGroup
=== RUN TestAccNeptuneClusterInstance_kmsKey
=== PAUSE TestAccNeptuneClusterInstance_kmsKey
=== RUN TestAccNeptuneClusterParameterGroup_basic
=== PAUSE TestAccNeptuneClusterParameterGroup_basic
=== RUN TestAccNeptuneClusterParameterGroup_namePrefix
=== PAUSE TestAccNeptuneClusterParameterGroup_namePrefix
=== RUN TestAccNeptuneClusterParameterGroup_generatedName
=== PAUSE TestAccNeptuneClusterParameterGroup_generatedName
=== RUN TestAccNeptuneClusterParameterGroup_description
=== PAUSE TestAccNeptuneClusterParameterGroup_description
=== RUN TestAccNeptuneClusterParameterGroup_NamePrefix_parameter
=== PAUSE TestAccNeptuneClusterParameterGroup_NamePrefix_parameter
=== RUN TestAccNeptuneClusterParameterGroup_parameter
=== PAUSE TestAccNeptuneClusterParameterGroup_parameter
=== RUN TestAccNeptuneClusterParameterGroup_parameterDefault
=== PAUSE TestAccNeptuneClusterParameterGroup_parameterDefault
=== RUN TestAccNeptuneClusterParameterGroup_tags
=== PAUSE TestAccNeptuneClusterParameterGroup_tags
=== CONT TestAccNeptuneClusterInstance_basic
=== CONT TestAccNeptuneClusterParameterGroup_basic
=== CONT TestAccNeptuneClusterParameterGroup_NamePrefix_parameter
--- PASS: TestAccNeptuneClusterParameterGroup_basic (26.84s)
=== CONT TestAccNeptuneClusterInstance_tags
--- PASS: TestAccNeptuneClusterParameterGroup_NamePrefix_parameter (44.17s)
=== CONT TestAccNeptuneClusterInstance_kmsKey
--- PASS: TestAccNeptuneClusterInstance_kmsKey (1611.66s)
=== CONT TestAccNeptuneClusterInstance_withSubnetGroup
--- PASS: TestAccNeptuneClusterInstance_tags (1646.13s)
=== CONT TestAccNeptuneClusterInstance_withAZ
--- PASS: TestAccNeptuneClusterInstance_basic (1816.14s)
=== CONT TestAccNeptuneClusterParameterGroup_generatedName
--- PASS: TestAccNeptuneClusterParameterGroup_generatedName (27.37s)
=== CONT TestAccNeptuneClusterParameterGroup_description
--- PASS: TestAccNeptuneClusterParameterGroup_description (24.11s)
=== CONT TestAccNeptuneClusterInstance_nameGenerated
--- PASS: TestAccNeptuneClusterInstance_withSubnetGroup (1604.78s)
=== CONT TestAccNeptuneClusterInstance_namePrefix
--- PASS: TestAccNeptuneClusterInstance_withAZ (1605.46s)
=== CONT TestAccNeptuneClusterParameterGroup_parameterDefault
--- PASS: TestAccNeptuneClusterParameterGroup_parameterDefault (20.19s)
=== CONT TestAccNeptuneClusterParameterGroup_tags
--- PASS: TestAccNeptuneClusterInstance_nameGenerated (1456.80s)
=== CONT TestAccNeptuneClusterInstance_disappears
--- PASS: TestAccNeptuneClusterParameterGroup_tags (54.69s)
=== CONT TestAccNeptuneClusterParameterGroup_parameter
--- PASS: TestAccNeptuneClusterParameterGroup_parameter (41.37s)
=== CONT TestAccNeptuneClusterParameterGroup_namePrefix
--- PASS: TestAccNeptuneClusterParameterGroup_namePrefix (23.75s)
--- PASS: TestAccNeptuneClusterInstance_namePrefix (1730.71s)
--- PASS: TestAccNeptuneClusterInstance_disappears (2174.27s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/neptune 5504.026s
|
@triggan Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes behavior of
engine_versionparameter onaws_neptune_cluster_instanceresource to ignore this parameter. This complies with the AWS documentation for bothcreate-db-instanceandmodify-db-instance.engine_versionis controlled at a cluster level in Neptune.More info in Issue #33467 .
This PR also addresses an issue where cluster parameters defined in a template with an
engine-defaultvalue are seen as changes anterraform apply. Changes are included here to evaluate defined parameters in a template against defaults in a cluster parameter group to ensure only changes are submitted if the change includes a non-default value or if changing the value back to a default.More info in Issue #20056.
Submitted new tests to check for default parameter values and ensure this is seen as a non-change. Also updated existing tests that were failing due to deprecated engine versions being used.
Relations
Closes #33467.
Closes #29785.
Closes #20056.
Closes #28260.
References
https://docs.aws.amazon.com/cli/latest/reference/neptune/create-db-instance.html
https://docs.aws.amazon.com/cli/latest/reference/neptune/modify-db-instance.html
Output from Acceptance Testing