Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_config_config_rule add Support for Evaluation Modes #33532

Closed
kneekeel opened this issue Sep 19, 2023 · 3 comments · Fixed by #34033
Closed

[Enhancement]: aws_config_config_rule add Support for Evaluation Modes #33532

kneekeel opened this issue Sep 19, 2023 · 3 comments · Fixed by #34033
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/configservice Issues and PRs that pertain to the configservice service.
Milestone

Comments

@kneekeel
Copy link

kneekeel commented Sep 19, 2023

Description

The current aws_config_config_rule resource does not support the configuration of an AWS Config Rule's Evaluation Mode. By default, AWS sets the Evaluation Mode to DETECTIVE.

Affected Resource(s) and/or Data Source(s)

  • aws_config_config_rule

Potential Terraform Configuration

resource "aws_config_config_rule" "example" {
  depends_on = [aws_lambda_permission.example]

  name             = "example"
  description      = "add evaluation_modes to resource attributes"
  input_parameters = jsonencode({})

  scope {
    compliance_resource_types = ["AWS::EC2::Instance"]
  }

  source {
    owner             = "CUSTOM_LAMBDA"
    source_identifier = aws_lambda_function.example.arn
    source_detail {
      event_source = "aws.config"
      message_type = "ConfigurationItemChangeNotification"
    }
    source_detail {
      event_source = "aws.config"
      message_type = "OversizedConfigurationItemChangeNotification"
    }
  }

  evaluation_modes = [
    "DETECTIVE",
    "PROACTIVE"
  ]
}

References

Would you like to implement a fix?

No

@kneekeel kneekeel added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 19, 2023
@github-actions github-actions bot added the service/configservice Issues and PRs that pertain to the configservice service. label Sep 19, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 19, 2023
@johnsonaj johnsonaj removed the needs-triage Waiting for first response or review from a maintainer. label Oct 19, 2023
@github-actions github-actions bot added this to the v5.23.0 milestone Oct 20, 2023
@github-actions
Copy link

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/configservice Issues and PRs that pertain to the configservice service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants