Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clean Rooms Configured Table resource #33602

Merged

Conversation

Jolcik
Copy link
Contributor

@Jolcik Jolcik commented Sep 23, 2023

Description

This pull request adds a new resource for AWS Clean Rooms service which is not currently fully supported by the plugin. The change adds Configured Table resource, which is used by the Collaboration to reference AWS Glue tables.

Relations

Relates #30024

References

https://docs.aws.amazon.com/clean-rooms/latest/apireference/API_ConfiguredTable.html

Output from Acceptance Testing

> make testacc TESTS=TestAccCleanRoomsConfiguredTable PKG=cleanrooms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cleanrooms/... -v -count 1 -parallel 20 -run='TestAccCleanRoomsConfiguredTable'  -timeout 360m
=== RUN   TestAccCleanRoomsConfiguredTable_basic
=== PAUSE TestAccCleanRoomsConfiguredTable_basic
=== RUN   TestAccCleanRoomsConfiguredTable_disappears
=== PAUSE TestAccCleanRoomsConfiguredTable_disappears
=== RUN   TestAccCleanRoomsConfiguredTable_mutableProperties
=== PAUSE TestAccCleanRoomsConfiguredTable_mutableProperties
=== RUN   TestAccCleanRoomsConfiguredTable_updateAllowedColumns
=== PAUSE TestAccCleanRoomsConfiguredTable_updateAllowedColumns
=== RUN   TestAccCleanRoomsConfiguredTable_updateTableReference
=== PAUSE TestAccCleanRoomsConfiguredTable_updateTableReference
=== RUN   TestAccCleanRoomsConfiguredTable_updateTableReference_onlyDatabase
=== PAUSE TestAccCleanRoomsConfiguredTable_updateTableReference_onlyDatabase
=== RUN   TestAccCleanRoomsConfiguredTable_updateTableReference_onlyTable
=== PAUSE TestAccCleanRoomsConfiguredTable_updateTableReference_onlyTable
=== CONT  TestAccCleanRoomsConfiguredTable_basic
=== CONT  TestAccCleanRoomsConfiguredTable_updateTableReference
=== CONT  TestAccCleanRoomsConfiguredTable_updateTableReference_onlyTable
=== CONT  TestAccCleanRoomsConfiguredTable_updateTableReference_onlyDatabase
=== CONT  TestAccCleanRoomsConfiguredTable_mutableProperties
=== CONT  TestAccCleanRoomsConfiguredTable_updateAllowedColumns
=== CONT  TestAccCleanRoomsConfiguredTable_disappears
--- PASS: TestAccCleanRoomsConfiguredTable_disappears (49.16s)
--- PASS: TestAccCleanRoomsConfiguredTable_basic (49.99s)
--- PASS: TestAccCleanRoomsConfiguredTable_updateTableReference (82.98s)
--- PASS: TestAccCleanRoomsConfiguredTable_mutableProperties (83.47s)
--- PASS: TestAccCleanRoomsConfiguredTable_updateAllowedColumns (84.75s)
--- PASS: TestAccCleanRoomsConfiguredTable_updateTableReference_onlyDatabase (85.81s)
--- PASS: TestAccCleanRoomsConfiguredTable_updateTableReference_onlyTable (86.25s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cleanrooms 89.995s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. examples Introduces or discusses updates to examples. generators Relates to code generators. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. and removed size/XL Managed by automation to categorize the size of a PR. labels Sep 23, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 23, 2023
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 27, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCleanRoomsConfiguredTable_' PKG=cleanrooms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cleanrooms/... -v -count 1 -parallel 2  -run=TestAccCleanRoomsConfiguredTable_ -timeout 360m
=== RUN   TestAccCleanRoomsConfiguredTable_basic
=== PAUSE TestAccCleanRoomsConfiguredTable_basic
=== RUN   TestAccCleanRoomsConfiguredTable_disappears
=== PAUSE TestAccCleanRoomsConfiguredTable_disappears
=== RUN   TestAccCleanRoomsConfiguredTable_mutableProperties
=== PAUSE TestAccCleanRoomsConfiguredTable_mutableProperties
=== RUN   TestAccCleanRoomsConfiguredTable_updateAllowedColumns
=== PAUSE TestAccCleanRoomsConfiguredTable_updateAllowedColumns
=== RUN   TestAccCleanRoomsConfiguredTable_updateTableReference
=== PAUSE TestAccCleanRoomsConfiguredTable_updateTableReference
=== RUN   TestAccCleanRoomsConfiguredTable_updateTableReference_onlyDatabase
=== PAUSE TestAccCleanRoomsConfiguredTable_updateTableReference_onlyDatabase
=== RUN   TestAccCleanRoomsConfiguredTable_updateTableReference_onlyTable
=== PAUSE TestAccCleanRoomsConfiguredTable_updateTableReference_onlyTable
=== CONT  TestAccCleanRoomsConfiguredTable_basic
=== CONT  TestAccCleanRoomsConfiguredTable_updateTableReference
--- PASS: TestAccCleanRoomsConfiguredTable_basic (29.91s)
=== CONT  TestAccCleanRoomsConfiguredTable_mutableProperties
--- PASS: TestAccCleanRoomsConfiguredTable_updateTableReference (52.21s)
=== CONT  TestAccCleanRoomsConfiguredTable_updateAllowedColumns
--- PASS: TestAccCleanRoomsConfiguredTable_mutableProperties (49.59s)
=== CONT  TestAccCleanRoomsConfiguredTable_updateTableReference_onlyTable
--- PASS: TestAccCleanRoomsConfiguredTable_updateAllowedColumns (51.56s)
=== CONT  TestAccCleanRoomsConfiguredTable_disappears
--- PASS: TestAccCleanRoomsConfiguredTable_updateTableReference_onlyTable (50.18s)
=== CONT  TestAccCleanRoomsConfiguredTable_updateTableReference_onlyDatabase
--- PASS: TestAccCleanRoomsConfiguredTable_disappears (27.68s)
--- PASS: TestAccCleanRoomsConfiguredTable_updateTableReference_onlyDatabase (49.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cleanrooms	184.668s

@ewbankkit
Copy link
Contributor

@Jolcik Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 53f3eb2 into hashicorp:main Sep 27, 2023
54 checks passed
@github-actions github-actions bot added this to the v5.19.0 milestone Sep 27, 2023
@github-actions
Copy link

This functionality has been released in v5.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. generators Relates to code generators. new-resource Introduces a new resource. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants