Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_sesv2_account_vdm_attributes: new resource #33705

Merged

Conversation

kamilturek
Copy link
Collaborator

Description

This PR adds the aws_sesv2_account_vdm_attributes resource.

Relations

Closes #31406.

References

https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_PutAccountVdmAttributes.html

Output from Acceptance Testing

$ make testacc TESTARGS="-run=TestAccSESV2AccountVdmAttributes_serial" PKG=sesv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2AccountVdmAttributes_serial -timeout 360m
=== RUN   TestAccSESV2AccountVdmAttributes_serial
=== PAUSE TestAccSESV2AccountVdmAttributes_serial
=== CONT  TestAccSESV2AccountVdmAttributes_serial
=== RUN   TestAccSESV2AccountVdmAttributes_serial/basic
=== RUN   TestAccSESV2AccountVdmAttributes_serial/disappears
=== RUN   TestAccSESV2AccountVdmAttributes_serial/engagementMetrics
=== RUN   TestAccSESV2AccountVdmAttributes_serial/optimizedSharedDelivery
--- PASS: TestAccSESV2AccountVdmAttributes_serial (123.78s)
    --- PASS: TestAccSESV2AccountVdmAttributes_serial/basic (24.95s)
    --- PASS: TestAccSESV2AccountVdmAttributes_serial/disappears (20.05s)
    --- PASS: TestAccSESV2AccountVdmAttributes_serial/engagementMetrics (39.16s)
    --- PASS: TestAccSESV2AccountVdmAttributes_serial/optimizedSharedDelivery (39.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      125.895s

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sesv2 Issues and PRs that pertain to the sesv2 service. generators Relates to code generators. labels Oct 1, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Oct 1, 2023
@kamilturek kamilturek marked this pull request as ready for review October 1, 2023 16:41
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 3, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESV2AccountVDMAttributes_serial' PKG=sesv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2AccountVDMAttributes_serial -timeout 360m
=== RUN   TestAccSESV2AccountVDMAttributes_serial
=== PAUSE TestAccSESV2AccountVDMAttributes_serial
=== CONT  TestAccSESV2AccountVDMAttributes_serial
=== RUN   TestAccSESV2AccountVDMAttributes_serial/engagementMetrics
=== RUN   TestAccSESV2AccountVDMAttributes_serial/optimizedSharedDelivery
=== RUN   TestAccSESV2AccountVDMAttributes_serial/basic
=== RUN   TestAccSESV2AccountVDMAttributes_serial/disappears
--- PASS: TestAccSESV2AccountVDMAttributes_serial (99.32s)
    --- PASS: TestAccSESV2AccountVDMAttributes_serial/engagementMetrics (31.99s)
    --- PASS: TestAccSESV2AccountVDMAttributes_serial/optimizedSharedDelivery (31.90s)
    --- PASS: TestAccSESV2AccountVDMAttributes_serial/basic (18.83s)
    --- PASS: TestAccSESV2AccountVDMAttributes_serial/disappears (16.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	104.564s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b41e8d7 into hashicorp:main Oct 3, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.20.0 milestone Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This functionality has been released in v5.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@kamilturek kamilturek deleted the f-aws-sesv2-account-vdm-attributes branch October 6, 2023 18:19
Copy link

github-actions bot commented Nov 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-resource Introduces a new resource. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: SESv2 Virtual Deliverability Manager (+Settings)
2 participants