Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F finspace kx cluster cache type and size changes #33745

Merged
merged 11 commits into from
Oct 4, 2023

Conversation

kavan-aws
Copy link
Contributor

Description

This PR adds support for new cache type enums CACHE_12 and CACHE_250. New acceptance tests that create clusters with the 2 new enums are included. This PR also adds support for larger cache sizes. Further validation on both cache size and type is still done after the API call is made.

Relations

Relates #31806

Output from Acceptance Testing

% make testacc TESTS=TestAccFinSpaceKxCluster_cache12Configurations PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_cache12Configurations'  -timeout 360m
=== RUN   TestAccFinSpaceKxCluster_cache12Configurations
=== PAUSE TestAccFinSpaceKxCluster_cache12Configurations
=== CONT  TestAccFinSpaceKxCluster_cache12Configurations
--- PASS: TestAccFinSpaceKxCluster_cache12Configurations (2873.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	2901.285s

% make testacc TESTS=TestAccFinSpaceKxCluster_cache250Configurations PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_cache250Configurations'  -timeout 360m
=== RUN   TestAccFinSpaceKxCluster_cache250Configurations
=== PAUSE TestAccFinSpaceKxCluster_cache250Configurations
=== CONT  TestAccFinSpaceKxCluster_cache250Configurations
--- PASS: TestAccFinSpaceKxCluster_cache250Configurations (2641.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3471.082s

# Tested with larger cache size (36000)
% make testacc TESTS=TestAccFinSpaceKxCluster_cacheConfigurations PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_cacheConfigurations'  -timeout 360m
=== RUN   TestAccFinSpaceKxCluster_cacheConfigurations
=== PAUSE TestAccFinSpaceKxCluster_cacheConfigurations
=== CONT  TestAccFinSpaceKxCluster_cacheConfigurations
--- PASS: TestAccFinSpaceKxCluster_cacheConfigurations (4402.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	4430.108s

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/finspace Issues and PRs that pertain to the finspace service. and removed size/L Managed by automation to categorize the size of a PR. labels Oct 4, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 4, 2023
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Oct 4, 2023
@jar-b jar-b self-assigned this Oct 4, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2023
@kavan-aws
Copy link
Contributor Author

Reran new tests successfully, output of updated tests below

make testacc TESTS=TestAccFinSpaceKxCluster_cache PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_cache'  -timeout 360m
=== RUN   TestAccFinSpaceKxCluster_cache250Configurations
=== PAUSE TestAccFinSpaceKxCluster_cache250Configurations
=== RUN   TestAccFinSpaceKxCluster_cache12Configurations
=== PAUSE TestAccFinSpaceKxCluster_cache12Configurations
=== CONT  TestAccFinSpaceKxCluster_cache250Configurations
=== CONT  TestAccFinSpaceKxCluster_cache12Configurations
--- PASS: TestAccFinSpaceKxCluster_cache250Configurations (2982.54s)
--- PASS: TestAccFinSpaceKxCluster_cache12Configurations (4230.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	4258.634s

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jar-b jar-b merged commit 368267f into hashicorp:main Oct 4, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.20.0 milestone Oct 4, 2023
@jar-b
Copy link
Member

jar-b commented Oct 4, 2023

Thanks for your contribution, @kavan-aws! 👏

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This functionality has been released in v5.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Nov 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/finspace Issues and PRs that pertain to the finspace service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants