Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add number_display_format_configuration and percentage_display_format_configuration to expandNumericFormatConfiguration #33777

Closed
jackarmorgie opened this issue Oct 5, 2023 · 3 comments · Fixed by #33931
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/quicksight Issues and PRs that pertain to the quicksight service.
Milestone

Comments

@jackarmorgie
Copy link
Contributor

Description

This function is missing the two attributes mentioned in the title:

func expandNumericFormatConfiguration(tfList []interface{}) *quicksight.NumericFormatConfiguration {

Affected Resource(s) and/or Data Source(s)

aws_quicksight_dashboard

Potential Terraform Configuration

No response

References

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_NumericFormatConfiguration.html

Would you like to implement a fix?

Yes

@jackarmorgie jackarmorgie added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 5, 2023
@justinretzolk justinretzolk added service/quicksight Issues and PRs that pertain to the quicksight service. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2023
@github-actions github-actions bot added this to the v5.26.0 milestone Nov 14, 2023
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants