Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Event Version for Lambda when creating aws_vpclattice_target_group #33786

Closed
stephenbawks opened this issue Oct 5, 2023 · 3 comments · Fixed by #33804
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/vpclattice Issues and PRs that pertain to the vpclattice service.
Milestone

Comments

@stephenbawks
Copy link

stephenbawks commented Oct 5, 2023

Description

When creating a VPC Lattice Target Group that points to a Lambda function, VPC Lattice now has two different versions of the event that gets sent to Lambda. There is the original one which they are now calling v1 and now the new one which is labeled v2.

There is a new attribute when creating a Lattice Target group that specifies the event version to use.

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/vpc-lattice/client/create_target_group.html

Specifically lambdaEventStructureVersion

I think it should also default to V2 since AWS is defaulting to that on new target groups when they are being created in the console.

Affected Resource(s) and/or Data Source(s)

aws_vpclattice_target_group

Potential Terraform Configuration

resource "aws_vpclattice_target_group" "lambda" {
  name = local.target_group_name
  type = "LAMBDA"
  
  lambda_event_version = "V2"  

  tags = local.tags
}

References

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/vpc-lattice/client/create_target_group.html

https://docs.aws.amazon.com/vpc-lattice/latest/ug/lambda-functions.html#receive-event-from-service

Would you like to implement a fix?

No

@stephenbawks stephenbawks added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 5, 2023
@github-actions github-actions bot added service/vpc Issues and PRs that pertain to the vpc service. service/vpclattice Issues and PRs that pertain to the vpclattice service. labels Oct 5, 2023
@ewbankkit ewbankkit removed needs-triage Waiting for first response or review from a maintainer. service/vpc Issues and PRs that pertain to the vpc service. labels Oct 6, 2023
@github-actions github-actions bot added this to the v5.21.0 milestone Oct 9, 2023
@github-actions
Copy link

This functionality has been released in v5.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/vpclattice Issues and PRs that pertain to the vpclattice service.
Projects
None yet
2 participants