Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_appflow_connector_profile: Fix various crashes #33856

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 9, 2023

Description

Ibid.

Relations

Closes #33855.
Closes #33803.
Closes #33169.
Closes #29507.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAppFlowConnectorProfile_' PKG=appflow ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 2  -run=TestAccAppFlowConnectorProfile_ -timeout 360m
=== RUN   TestAccAppFlowConnectorProfile_basic
=== PAUSE TestAccAppFlowConnectorProfile_basic
=== RUN   TestAccAppFlowConnectorProfile_update
=== PAUSE TestAccAppFlowConnectorProfile_update
=== RUN   TestAccAppFlowConnectorProfile_disappears
=== PAUSE TestAccAppFlowConnectorProfile_disappears
=== CONT  TestAccAppFlowConnectorProfile_basic
=== CONT  TestAccAppFlowConnectorProfile_disappears
--- PASS: TestAccAppFlowConnectorProfile_disappears (286.01s)
=== CONT  TestAccAppFlowConnectorProfile_update
--- PASS: TestAccAppFlowConnectorProfile_basic (286.96s)
--- PASS: TestAccAppFlowConnectorProfile_update (324.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	616.253s

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/appflow Issues and PRs that pertain to the appflow service. labels Oct 9, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 9, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Oct 9, 2023
@ewbankkit ewbankkit merged commit d2bd9da into main Oct 9, 2023
72 checks passed
@ewbankkit ewbankkit deleted the b-aws_appflow_connector_profile-crashes branch October 9, 2023 20:22
@github-actions github-actions bot added this to the v5.21.0 milestone Oct 9, 2023
github-actions bot pushed a commit that referenced this pull request Oct 9, 2023
@github-actions
Copy link

This functionality has been released in v5.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Oct 12, 2023
@tusharpandit18
Copy link

tusharpandit18 commented Oct 16, 2023

Hi @ewbankkit , when I click on v5.21.0 of the Terraform AWS Provider, it says the version is still unreleased;
I have a configuration as
terraform { required_providers { aws = { source = "hashicorp/aws" version = "~> 5.0" } } }
which automatically picks the latest version; when do you think the version will be released?

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Oct 16, 2023

@tusharpandit18 v5.21.0 was released on October 12th. The way our release process works the release date is changed in CHANGELOG.md the commit after the release tag, so the release tag version always says Unreleased.

@tusharpandit18
Copy link

Interesting. For me it still says we have 5.19.0; will double check on our side; Thanks

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/appflow Issues and PRs that pertain to the appflow service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants