Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch adding vpc endpoint resource #33925

Merged

Conversation

mikekinlock
Copy link
Contributor

@mikekinlock mikekinlock commented Oct 13, 2023

Change

Added the elasticsearch vpc-endpoint resource

Description

Added the option to configure a resource which manages the VPC-Endpoint of elasticsearch

Relations

Closes #27978.
Closes #28140.
Relates #32435.

References

https://docs.aws.amazon.com/cli/latest/reference/es/create-vpc-endpoint.html

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticsearch/... -v -count 1 -parallel 20 -run='TestAccelasticsearchVPCEndpoint'  -timeout 360m
=== RUN   TestAccelasticsearchVPCEndpoint_basic
=== PAUSE TestAccelasticsearchVPCEndpoint_basic
=== RUN   TestAccelasticsearchVPCEndpoint_disappears
=== PAUSE TestAccelasticsearchVPCEndpoint_disappears
=== RUN   TestAccelasticsearchVPCEndpoint_update
=== PAUSE TestAccelasticsearchVPCEndpoint_update
=== CONT  TestAccelasticsearchVPCEndpoint_basic
=== CONT  TestAccelasticsearchVPCEndpoint_update
=== CONT  TestAccelasticsearchVPCEndpoint_disappears
--- PASS: TestAccelasticsearchVPCEndpoint_basic (1557.94s)
--- PASS: TestAccelasticsearchVPCEndpoint_disappears (1560.27s)
--- PASS: TestAccelasticsearchVPCEndpoint_update (1560.35s)
% make testacc TESTS=TestAccelasticsearchVPCEndpoint PKG=elasticsearch

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@mikekinlock mikekinlock changed the title F elasticsearch adding vpc endpoint Elasticsearch adding vpc endpoint resource Oct 13, 2023
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. generators Relates to code generators. labels Oct 13, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 13, 2023
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Oct 13, 2023
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 15, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccElasticsearchDomain_VPC_update\|TestAccElasticsearchVPCEndpoint_\|TestAccElasticsearchDomainDataSource_advanced' PKG=elasticsearch ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticsearch/... -v -count 1 -parallel 2  -run=TestAccElasticsearchDomain_VPC_update\|TestAccElasticsearchVPCEndpoint_\|TestAccElasticsearchDomainDataSource_advanced -timeout 720m
=== RUN   TestAccElasticsearchDomainDataSource_advanced
=== PAUSE TestAccElasticsearchDomainDataSource_advanced
=== RUN   TestAccElasticsearchDomain_VPC_update
=== PAUSE TestAccElasticsearchDomain_VPC_update
=== RUN   TestAccElasticsearchVPCEndpoint_basic
=== PAUSE TestAccElasticsearchVPCEndpoint_basic
=== RUN   TestAccElasticsearchVPCEndpoint_disappears
=== PAUSE TestAccElasticsearchVPCEndpoint_disappears
=== RUN   TestAccElasticsearchVPCEndpoint_update
=== PAUSE TestAccElasticsearchVPCEndpoint_update
=== CONT  TestAccElasticsearchDomainDataSource_advanced
=== CONT  TestAccElasticsearchVPCEndpoint_disappears
--- PASS: TestAccElasticsearchVPCEndpoint_disappears (2088.42s)
=== CONT  TestAccElasticsearchVPCEndpoint_update
--- PASS: TestAccElasticsearchDomainDataSource_advanced (2291.66s)
=== CONT  TestAccElasticsearchVPCEndpoint_basic
--- PASS: TestAccElasticsearchVPCEndpoint_basic (1851.45s)
=== CONT  TestAccElasticsearchDomain_VPC_update
--- PASS: TestAccElasticsearchVPCEndpoint_update (2322.95s)
--- PASS: TestAccElasticsearchDomain_VPC_update (3937.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch	8085.812s

@ewbankkit
Copy link
Contributor

@mikekinlock Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b4947bb into hashicorp:main Oct 16, 2023
50 checks passed
@github-actions github-actions bot added this to the v5.22.0 milestone Oct 16, 2023
@github-actions
Copy link

This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Include terraform support to create Amazon OpenSearch Service-managed VPC endpoint
2 participants