Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support for signer:SignPayload in aws_signer_signing_profile_permission #33941

Closed
aii-satoshi-abe opened this issue Oct 16, 2023 · 4 comments · Fixed by #33852
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/signer Issues and PRs that pertain to the signer service.
Milestone

Comments

@aii-satoshi-abe
Copy link

aii-satoshi-abe commented Oct 16, 2023

Description

Currently, aws_signer_signing_profile_permission supports the following actions

  • signer:StartSigningJob
  • signer:GetSigningProfile
  • signer:RevokeSignature

When setting Notation-OCI-SHA384-ECDSA for platform_id in aws_signer_signing_profile, "signer:SignPayload" is required in addition.

Affected Resource(s) and/or Data Source(s)

aws_signer_signing_profile_permission

Potential Terraform Configuration

resource "aws_signer_signing_profile_permission" "example_profile_permission" {
  profile_name = aws_signer_signing_profile.example_signing_profile.name
  action       = "signer:SignPayload"
  principal    = "123456789012"
}

References

https://docs.aws.amazon.com/service-authorization/latest/reference/list_awssigner.html

Would you like to implement a fix?

No

@aii-satoshi-abe aii-satoshi-abe added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 16, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/signer Issues and PRs that pertain to the signer service. label Oct 16, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 16, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 16, 2023
@jbianquetti-nami
Copy link

The error message is like this one:

 Error: adding new Signer Signing Profile Permission for "xxxxxxxx": operation error signer: AddProfilePermission, https response error StatusCode: 400, RequestID: 6be71783-f247-49cd-bf1f-8f75f8596fdb, ValidationException: Action signer:StartSigningJob not supported for platform Notation-OCI-SHA384-ECDSA. Action must be one of [signer:SignPayload, signer:GetSigningProfile, signer:RevokeSignature]

@github-actions
Copy link

This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/signer Issues and PRs that pertain to the signer service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants