Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource Lex Bot Locale #33949

Merged
merged 12 commits into from Nov 8, 2023
Merged

New Resource Lex Bot Locale #33949

merged 12 commits into from Nov 8, 2023

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Oct 16, 2023

Description

Adds new resource of Bot Locale

Relations

Relates #21375

References

Output from Acceptance Testing

> make testacc TESTS=TestAccLexV2ModelsBotLocale_ PKG=lexv2models
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsBotLocale_'  -timeout 360m
=== RUN   TestAccLexV2ModelsBotLocale_basic
=== PAUSE TestAccLexV2ModelsBotLocale_basic
=== RUN   TestAccLexV2ModelsBotLocale_disappears
=== PAUSE TestAccLexV2ModelsBotLocale_disappears
=== CONT  TestAccLexV2ModelsBotLocale_basic
=== CONT  TestAccLexV2ModelsBotLocale_disappears
--- PASS: TestAccLexV2ModelsBotLocale_disappears (27.62s)
--- PASS: TestAccLexV2ModelsBotLocale_basic (27.78s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models        30.908s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lexv2models Issues and PRs that pertain to the lexv2models service. labels Oct 16, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 16, 2023
@nam054 nam054 changed the title base files New Resource Lex Bot Locale Oct 19, 2023
Copy link

github-actions bot commented Nov 2, 2023

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@nam054 nam054 marked this pull request as ready for review November 7, 2023 00:57
@github-actions github-actions bot added the generators Relates to code generators. label Nov 7, 2023
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

% make test t T=TestAccLexV2ModelsBotLocale_ K=lexv2models
==> Checking that code complies with gofmt requirements...
go test ./internal/service/lexv2models/...  -timeout=5m
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models	2.113s
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsBotLocale_'  -timeout 360m
=== RUN   TestAccLexV2ModelsBotLocale_basic
=== PAUSE TestAccLexV2ModelsBotLocale_basic
=== RUN   TestAccLexV2ModelsBotLocale_disappears
=== PAUSE TestAccLexV2ModelsBotLocale_disappears
=== CONT  TestAccLexV2ModelsBotLocale_basic
=== CONT  TestAccLexV2ModelsBotLocale_disappears
--- PASS: TestAccLexV2ModelsBotLocale_basic (176.81s)
--- PASS: TestAccLexV2ModelsBotLocale_disappears (181.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models	183.529s

@nam054 nam054 merged commit 797fbb9 into main Nov 8, 2023
44 checks passed
@nam054 nam054 deleted the f-resource-locale branch November 8, 2023 03:57
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 8, 2023
github-actions bot pushed a commit that referenced this pull request Nov 8, 2023
Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/lexv2models Issues and PRs that pertain to the lexv2models service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants