Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_elasticache_replication_group: Fix error incorrectly forcing recreation when changing version from 6.x to 6.2 #33954

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

gdavison
Copy link
Contributor

Description

The resource aws_elasticache_replication_group incorrectly identifies switching from version 6.x to 6.2 as a downgrade, which requires a re-creation of the resource.

Relations

Closes #28011
Supersedes #28877

Output from Acceptance Testing

% make testacc PKG=elasticache TESTS=TestAccElastiCacheReplicationGroup_

--- PASS: TestAccElastiCacheReplicationGroup_clusteringAndCacheNodesCausesError (6.37s)
--- PASS: TestAccElastiCacheReplicationGroup_ValidationMultiAz_noAutomaticFailover (8.55s)
--- FAIL: TestAccElastiCacheReplicationGroup_tagWithOtherModification (928.49s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_nonClusteredParameterGroup (987.41s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC (1008.87s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzNotInVPC_repeated (1009.08s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterModeValidation_numNodeGroupsOnSecondary (1086.15s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_basic (1292.78s)
--- PASS: TestAccElastiCacheReplicationGroup_basic (1376.56s)
--- PASS: TestAccElastiCacheReplicationGroup_dataTiering (1382.25s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_singleNode (1396.95s)
--- PASS: TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Enabled (1937.98s)
--- PASS: TestAccElastiCacheReplicationGroup_Validation_globalReplicationGroupIdAndNodeType (967.78s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersFailover_autoFailoverEnabled (1557.85s)
--- PASS: TestAccElastiCacheReplicationGroup_Engine_Redis_LogDeliveryConfigurations_ClusterMode_Disabled (2497.64s)
--- PASS: TestAccElastiCacheReplicationGroup_deprecatedAvailabilityZones_multiAzInVPC (2499.05s)
--- PASS: TestAccElastiCacheReplicationGroup_Validation_noNodeType (5.66s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleDown (2665.87s)
--- PASS: TestAccElastiCacheReplicationGroup_tags (1701.66s)
--- PASS: TestAccElastiCacheReplicationGroup_multiAzInVPC (2815.20s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroups_scaleUp (3097.10s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_scaleDown (2195.94s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterModeUpdateNumNodeGroupsAndReplicasPerNodeGroup_scaleDown (3218.32s)
--- PASS: TestAccElastiCacheReplicationGroup_enableAuthTokenTransitEncryption (922.25s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappearsRemoveMemberCluster_atTargetSize (2357.28s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_updateReplicasPerNodeGroup (3428.48s)
--- PASS: TestAccElastiCacheReplicationGroup_autoMinorVersionUpgrade (1079.48s)
--- PASS: TestAccElastiCacheReplicationGroup_finalSnapshot (1117.61s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_noChange (2448.59s)
--- PASS: TestAccElastiCacheReplicationGroup_enableSnapshotting (1007.62s)
--- PASS: TestAccElastiCacheReplicationGroup_enableAtRestEncryption (1433.57s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersMemberClusterDisappears_addMemberCluster (2827.55s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_multiAZEnabled (2669.00s)
--- PASS: TestAccElastiCacheReplicationGroup_vpc (1157.14s)
--- PASS: TestAccElastiCacheReplicationGroup_updateAuthToken (1159.95s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClustersFailover_autoFailoverDisabled (1813.18s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic (4474.75s)
--- PASS: TestAccElastiCacheReplicationGroup_updateDescription (1464.79s)
--- PASS: TestAccElastiCacheReplicationGroup_updateMaintenanceWindow (984.89s)
--- PASS: TestAccElastiCacheReplicationGroup_updateParameterGroup (1291.14s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic (2676.51s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_full (3324.65s)
--- PASS: TestAccElastiCacheReplicationGroup_disappears (1047.21s)
--- PASS: TestAccElastiCacheReplicationGroup_uppercase (913.20s)
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_v7 (917.16s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_disappears (4903.96s)
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic (2312.00s)
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion (1192.38s)
--- PASS: TestAccElastiCacheReplicationGroup_useCMKKMSKeyID (885.25s)
--- PASS: TestAccElastiCacheReplicationGroup_basic_v5 (1221.40s)
--- PASS: TestAccElastiCacheReplicationGroup_updateUserGroups (2116.00s)
--- PASS: TestAccElastiCacheReplicationGroup_updateNodeSize (2329.38s)
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_update (7435.93s)

TestAccElastiCacheReplicationGroup_tagWithOtherModification is an unrelated error

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elasticache Issues and PRs that pertain to the elasticache service. size/XL Managed by automation to categorize the size of a PR. labels Oct 16, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 16, 2023
.changelog/33954.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccElastiCacheReplicationGroup_EngineVersion_update\|TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2  -run=TestAccElastiCacheReplicationGroup_EngineVersion_update\|TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion -timeout 720m
=== RUN   TestAccElastiCacheReplicationGroup_EngineVersion_update
=== PAUSE TestAccElastiCacheReplicationGroup_EngineVersion_update
=== RUN   TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion
=== PAUSE TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion
=== CONT  TestAccElastiCacheReplicationGroup_EngineVersion_update
=== CONT  TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_6xToRealVersion (1013.33s)
--- PASS: TestAccElastiCacheReplicationGroup_EngineVersion_update (6628.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	6635.618s

@gdavison gdavison merged commit 1b4a5ae into main Oct 19, 2023
35 checks passed
@gdavison gdavison deleted the b-elasticache-engine-version branch October 19, 2023 21:03
@github-actions github-actions bot added this to the v5.22.0 milestone Oct 19, 2023
@github-actions
Copy link

This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/elasticache Issues and PRs that pertain to the elasticache service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_elasticache_replication_group recreates resource on engine_version upgrade
3 participants