resource/aws_s3_bucket_object_lock_configuration: fix deletion bug

[naruse666]

Description

aws_s3_bucket_object_lock_configuration was used RetryUntilNotFound but it can not be delete.
It will cause resource found loop.

I used RetryWhenNotFound in case object_lock_configuration cannot be get due to some error. I think this appropriate this case.

Relations

Closes #33943

Output from Acceptance Testing

Does not exist related test.

This is my first time PR for this org. Please point out if I've made any mistakes.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @naruse666 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

@naruse666 Thanks for the contribution 🎉 👏.
I think the best thing here is to remove the wait completely on Delete (restoring the functionality from v5.18.0).

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccS3BucketObjectLockConfiguration_' PKG=s3 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 2  -run=TestAccS3BucketObjectLockConfiguration_ -timeout 360m
=== RUN   TestAccS3BucketObjectLockConfiguration_basic
=== PAUSE TestAccS3BucketObjectLockConfiguration_basic
=== RUN   TestAccS3BucketObjectLockConfiguration_disappears
=== PAUSE TestAccS3BucketObjectLockConfiguration_disappears
=== RUN   TestAccS3BucketObjectLockConfiguration_update
=== PAUSE TestAccS3BucketObjectLockConfiguration_update
=== RUN   TestAccS3BucketObjectLockConfiguration_migrate_noChange
=== PAUSE TestAccS3BucketObjectLockConfiguration_migrate_noChange
=== RUN   TestAccS3BucketObjectLockConfiguration_migrate_withChange
=== PAUSE TestAccS3BucketObjectLockConfiguration_migrate_withChange
=== RUN   TestAccS3BucketObjectLockConfiguration_noRule
=== PAUSE TestAccS3BucketObjectLockConfiguration_noRule
=== CONT  TestAccS3BucketObjectLockConfiguration_basic
=== CONT  TestAccS3BucketObjectLockConfiguration_migrate_noChange
--- PASS: TestAccS3BucketObjectLockConfiguration_basic (49.29s)
=== CONT  TestAccS3BucketObjectLockConfiguration_update
--- PASS: TestAccS3BucketObjectLockConfiguration_migrate_noChange (66.55s)
=== CONT  TestAccS3BucketObjectLockConfiguration_disappears
--- PASS: TestAccS3BucketObjectLockConfiguration_update (54.29s)
=== CONT  TestAccS3BucketObjectLockConfiguration_noRule
--- PASS: TestAccS3BucketObjectLockConfiguration_disappears (46.90s)
=== CONT  TestAccS3BucketObjectLockConfiguration_migrate_withChange
--- PASS: TestAccS3BucketObjectLockConfiguration_noRule (46.03s)
--- PASS: TestAccS3BucketObjectLockConfiguration_migrate_withChange (62.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	181.731s

[gdewitte]

Thank you all! 👍

[github-actions]

This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.