[aws_storagegateway_gateway] Allow value of 0 for maintenance_start_time.day_of_week

[sodle]

Description

Allows a value of 0 (representing Sunday) for the maintenance_start_time.day_of_week attribute of aws_storagegateway_gateway resources.

Previously, a zero value in this field would be converted to null, resulting in an error from AWS when deploying.

Added an acceptance test that validates this case.

Relations

Closes #26597

Output from Acceptance Testing

% make testacc TESTS=TestAccStorageGatewayGateway_maintenanceStartTime PKG=storagegateway
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/storagegateway/... -v -count 1 -parallel 20 -run='TestAccStorageGatewayGateway_maintenanceStartTime'  -timeout 360m
=== RUN   TestAccStorageGatewayGateway_maintenanceStartTime
=== PAUSE TestAccStorageGatewayGateway_maintenanceStartTime
=== CONT  TestAccStorageGatewayGateway_maintenanceStartTime
--- PASS: TestAccStorageGatewayGateway_maintenanceStartTime (771.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway     774.616s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @sodle 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccStorageGatewayGateway_maintenanceStartTime' PKG=storagegateway ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/storagegateway/... -v -count 1 -parallel 2  -run=TestAccStorageGatewayGateway_maintenanceStartTime -timeout 360m
=== RUN   TestAccStorageGatewayGateway_maintenanceStartTime
=== PAUSE TestAccStorageGatewayGateway_maintenanceStartTime
=== CONT  TestAccStorageGatewayGateway_maintenanceStartTime
--- PASS: TestAccStorageGatewayGateway_maintenanceStartTime (235.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway	240.733s

% make testacc TESTARGS='-run=TestAccStorageGatewayGateway_GatewayType_cached' PKG=storagegateway ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/storagegateway/... -v -count 1 -parallel 2  -run=TestAccStorageGatewayGateway_GatewayType_cached -timeout 360m
=== RUN   TestAccStorageGatewayGateway_GatewayType_cached
=== PAUSE TestAccStorageGatewayGateway_GatewayType_cached
=== CONT  TestAccStorageGatewayGateway_GatewayType_cached
--- PASS: TestAccStorageGatewayGateway_GatewayType_cached (247.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway	252.831s

[ewbankkit]

@sodle Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.