feat: add network_type and ip_discovery to ElastiCache replication group

[bschaatsbergen]

Description

Adds the ip_discovery parameter to elasticache replication group that is now supported on Redis 6.2 and Memcached engine version 1.6.6 on all instances built on the Nitro system.

Relations

Closes #28131

References

API Documentation: https://docs.aws.amazon.com/AmazonElastiCache/latest/APIReference/API_ReplicationGroup.html

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccElastiCacheReplicationGroup_ipDiscovery\|TestAccElastiCacheReplicationGroup_networkType' PKG=elasticache
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 20  -run=TestAccElastiCacheReplicationGroup_ipDiscovery\|TestAccElastiCacheReplicationGroup_networkType -timeout 360m
=== RUN   TestAccElastiCacheReplicationGroup_ipDiscovery
=== PAUSE TestAccElastiCacheReplicationGroup_ipDiscovery
=== RUN   TestAccElastiCacheReplicationGroup_networkType
=== PAUSE TestAccElastiCacheReplicationGroup_networkType
=== CONT  TestAccElastiCacheReplicationGroup_ipDiscovery
=== CONT  TestAccElastiCacheReplicationGroup_networkType
--- PASS: TestAccElastiCacheReplicationGroup_ipDiscovery (1099.22s)
--- PASS: TestAccElastiCacheReplicationGroup_networkType (1099.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	1101.578s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[bschaatsbergen]

@tophercullen, @kbergha, @otyaglo, @larsboldt - I expect this to be merged fairly quickly 👍🏼

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccElastiCacheReplicationGroup_ipDiscovery\|TestAccElastiCacheReplicationGroup_networkType' PKG=elasticache ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2  -run=TestAccElastiCacheReplicationGroup_ipDiscovery\|TestAccElastiCacheReplicationGroup_networkType -timeout 360m
=== RUN   TestAccElastiCacheReplicationGroup_ipDiscovery
=== PAUSE TestAccElastiCacheReplicationGroup_ipDiscovery
=== RUN   TestAccElastiCacheReplicationGroup_networkType
=== PAUSE TestAccElastiCacheReplicationGroup_networkType
=== CONT  TestAccElastiCacheReplicationGroup_ipDiscovery
=== CONT  TestAccElastiCacheReplicationGroup_networkType
--- PASS: TestAccElastiCacheReplicationGroup_ipDiscovery (1003.67s)
--- PASS: TestAccElastiCacheReplicationGroup_networkType (1117.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	1122.299s

% make testacc TESTARGS='-run=TestAccElastiCacheReplicationGroup_basic' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2  -run=TestAccElastiCacheReplicationGroup_basic -timeout 360m
=== RUN   TestAccElastiCacheReplicationGroup_basic
=== PAUSE TestAccElastiCacheReplicationGroup_basic
=== RUN   TestAccElastiCacheReplicationGroup_basic_v5
=== PAUSE TestAccElastiCacheReplicationGroup_basic_v5
=== CONT  TestAccElastiCacheReplicationGroup_basic
=== CONT  TestAccElastiCacheReplicationGroup_basic_v5
--- PASS: TestAccElastiCacheReplicationGroup_basic_v5 (824.96s)
--- PASS: TestAccElastiCacheReplicationGroup_basic (880.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	886.325s

[ewbankkit]

@bschaatsbergen Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.