Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support managed rotation for AWS Secrets Manager #34108

Closed
jar-b opened this issue Oct 25, 2023 · 3 comments · Fixed by #34180
Closed

[Enhancement]: Support managed rotation for AWS Secrets Manager #34108

jar-b opened this issue Oct 25, 2023 · 3 comments · Fixed by #34180
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/secretsmanager Issues and PRs that pertain to the secretsmanager service.
Milestone

Comments

@jar-b
Copy link
Member

jar-b commented Oct 25, 2023

Description

AWS SecretsManager provides "managed" rotation for certain use cases such as Amazon RDS, Amazon Aurora, and Amazon RedShift database credentials. In these cases the RotateSecret API does not require a value for RotationLambdaArn as rotation is fully managed. To support these use cases, the rotation_lambda_arn argument in the aws_secretsmanager_secret_rotation resource should be changed from required to optional.

Affected Resource(s) and/or Data Source(s)

  • aws_sercretsmanager_secret_rotation

Potential Terraform Configuration

resource "aws_secretsmanager_secret_rotation" "example" {
  secret_id           = aws_secretsmanager_secret.example.id
  # no rotation_lambda_arn argument is required

  rotation_rules {
    automatically_after_days = 30
  }
}

References

Would you like to implement a fix?

None

@jar-b jar-b added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 25, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/secretsmanager Issues and PRs that pertain to the secretsmanager service. label Oct 25, 2023
@jar-b jar-b self-assigned this Oct 31, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 31, 2023
@github-actions github-actions bot added this to the v5.24.0 milestone Nov 1, 2023
Copy link

github-actions bot commented Nov 2, 2023

This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Dec 3, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/secretsmanager Issues and PRs that pertain to the secretsmanager service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant