Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build_batch_config cannot be removed problem #34121

Merged
merged 31 commits into from
Jan 23, 2024

Conversation

digglife
Copy link
Contributor

@digglife digglife commented Oct 26, 2023

Important

Please adding a 👍 reaction if you want this PR to be merged.

Description

This PR fixes the problem that build_batch_config can't be removed even when we deleted build_batch_config attribute from the CodeBuild resource definition.

Relations

Closes #29261.
Closes #35108.

Output from Acceptance Testing

Without This Change

% make testacc TESTS=TestAccCodeBuildProject_buildBatchConfigDelete  PKG=codebuild
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildProject_buildBatchConfigDelete'  -timeout 360m
=== RUN   TestAccCodeBuildProject_buildBatchConfigDelete
=== PAUSE TestAccCodeBuildProject_buildBatchConfigDelete
=== CONT  TestAccCodeBuildProject_buildBatchConfigDelete
    project_test.go:807: Step 3/3 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_codebuild_project.test will be updated in-place
          ~ resource "aws_codebuild_project" "test" {
                id                     = "arn:aws:codebuild:us-west-2:197452176456:project/tf-acc-test-6659012423945905063"
                name                   = "tf-acc-test-6659012423945905063"
                tags                   = {}
                # (9 unchanged attributes hidden)
        
              - build_batch_config {
                  - combine_artifacts = true -> null
                  - service_role      = "arn:aws:iam::197452176456:role/tf-acc-test-6659012423945905063" -> null
                  - timeout_in_mins   = 480 -> null
        
                  - restrictions {
                      - compute_types_allowed  = [] -> null
                      - maximum_builds_allowed = 10 -> null
                    }
                }
        
                # (5 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccCodeBuildProject_buildBatchConfigDelete (141.91s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	142.083s
FAIL

With This Change

% make testacc TESTS=TestAccCodeBuildProject_buildBatchConfigDelete  PKG=codebuild
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildProject_buildBatchConfigDelete'  -timeout 360m
=== RUN   TestAccCodeBuildProject_buildBatchConfigDelete
=== PAUSE TestAccCodeBuildProject_buildBatchConfigDelete
=== CONT  TestAccCodeBuildProject_buildBatchConfigDelete
--- PASS: TestAccCodeBuildProject_buildBatchConfigDelete (113.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	113.346s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codebuild Issues and PRs that pertain to the codebuild service. labels Oct 26, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 26, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @digglife 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 26, 2023
@digglife
Copy link
Contributor Author

digglife commented Nov 9, 2023

Could any maintainers kindly review this change?

Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaJiska
Copy link

RaJiska commented Dec 8, 2023

We applied build_batch_config to all our pipelines as we wanted to enable the feature but only one actually was using it. We wanted to urgently revert it when we realised having the batch config and while the buildspec does not have batch references causes the pipeline to fail, until we realised Terraform was bugged and had to quickly come up with some backup CLI command to fix it.

Thanks @digglife for making the PR. I think this should be merged ASAP.

@digglife
Copy link
Contributor Author

Hi maintainers,
Could you please kindly merge this PR?

% make testacc TESTARGS='-run=TestAccCodeBuildProject_' PKG=codebuild ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 2  -run=TestAccCodeBuildProject_ -timeout 360m
=== RUN   TestAccCodeBuildProject_basic
=== PAUSE TestAccCodeBuildProject_basic
=== RUN   TestAccCodeBuildProject_disappears
=== PAUSE TestAccCodeBuildProject_disappears
=== RUN   TestAccCodeBuildProject_tags
=== PAUSE TestAccCodeBuildProject_tags
=== RUN   TestAccCodeBuildProject_publicVisibility
=== PAUSE TestAccCodeBuildProject_publicVisibility
=== RUN   TestAccCodeBuildProject_badgeEnabled
=== PAUSE TestAccCodeBuildProject_badgeEnabled
=== RUN   TestAccCodeBuildProject_buildTimeout
=== PAUSE TestAccCodeBuildProject_buildTimeout
=== RUN   TestAccCodeBuildProject_queuedTimeout
=== PAUSE TestAccCodeBuildProject_queuedTimeout
=== RUN   TestAccCodeBuildProject_cache
=== PAUSE TestAccCodeBuildProject_cache
=== RUN   TestAccCodeBuildProject_description
=== PAUSE TestAccCodeBuildProject_description
=== RUN   TestAccCodeBuildProject_fileSystemLocations
=== PAUSE TestAccCodeBuildProject_fileSystemLocations
=== RUN   TestAccCodeBuildProject_sourceVersion
=== PAUSE TestAccCodeBuildProject_sourceVersion
=== RUN   TestAccCodeBuildProject_encryptionKey
=== PAUSE TestAccCodeBuildProject_encryptionKey
=== RUN   TestAccCodeBuildProject_Environment_environmentVariable
=== PAUSE TestAccCodeBuildProject_Environment_environmentVariable
=== RUN   TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
=== PAUSE TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
=== RUN   TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
=== PAUSE TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
=== RUN   TestAccCodeBuildProject_Environment_certificate
=== PAUSE TestAccCodeBuildProject_Environment_certificate
=== RUN   TestAccCodeBuildProject_Environment_registryCredential
=== PAUSE TestAccCodeBuildProject_Environment_registryCredential
=== RUN   TestAccCodeBuildProject_Logs_cloudWatchLogs
=== PAUSE TestAccCodeBuildProject_Logs_cloudWatchLogs
=== RUN   TestAccCodeBuildProject_Logs_s3Logs
=== PAUSE TestAccCodeBuildProject_Logs_s3Logs
=== RUN   TestAccCodeBuildProject_buildBatch
=== PAUSE TestAccCodeBuildProject_buildBatch
=== RUN   TestAccCodeBuildProject_buildBatchConfigDelete
=== PAUSE TestAccCodeBuildProject_buildBatchConfigDelete
=== RUN   TestAccCodeBuildProject_Source_gitCloneDepth
=== PAUSE TestAccCodeBuildProject_Source_gitCloneDepth
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_gitHub
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_gitHub
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SecondarySourcesVersions
=== PAUSE TestAccCodeBuildProject_SecondarySourcesVersions
=== RUN   TestAccCodeBuildProject_Source_insecureSSL
=== PAUSE TestAccCodeBuildProject_Source_insecureSSL
=== RUN   TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
=== RUN   TestAccCodeBuildProject_SourceType_bitbucket
=== PAUSE TestAccCodeBuildProject_SourceType_bitbucket
=== RUN   TestAccCodeBuildProject_SourceType_codeCommit
=== PAUSE TestAccCodeBuildProject_SourceType_codeCommit
=== RUN   TestAccCodeBuildProject_SourceType_codePipeline
=== PAUSE TestAccCodeBuildProject_SourceType_codePipeline
=== RUN   TestAccCodeBuildProject_SourceType_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceType_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceType_s3
=== PAUSE TestAccCodeBuildProject_SourceType_s3
=== RUN   TestAccCodeBuildProject_SourceType_noSource
=== PAUSE TestAccCodeBuildProject_SourceType_noSource
=== RUN   TestAccCodeBuildProject_SourceType_noSourceInvalid
=== PAUSE TestAccCodeBuildProject_SourceType_noSourceInvalid
=== RUN   TestAccCodeBuildProject_vpc
=== PAUSE TestAccCodeBuildProject_vpc
=== RUN   TestAccCodeBuildProject_windowsServer2019Container
=== PAUSE TestAccCodeBuildProject_windowsServer2019Container
=== RUN   TestAccCodeBuildProject_armContainer
=== PAUSE TestAccCodeBuildProject_armContainer
=== RUN   TestAccCodeBuildProject_linuxLambdaContainer
=== PAUSE TestAccCodeBuildProject_linuxLambdaContainer
=== RUN   TestAccCodeBuildProject_Artifacts_artifactIdentifier
=== PAUSE TestAccCodeBuildProject_Artifacts_artifactIdentifier
=== RUN   TestAccCodeBuildProject_Artifacts_encryptionDisabled
=== PAUSE TestAccCodeBuildProject_Artifacts_encryptionDisabled
=== RUN   TestAccCodeBuildProject_Artifacts_location
=== PAUSE TestAccCodeBuildProject_Artifacts_location
=== RUN   TestAccCodeBuildProject_Artifacts_name
=== PAUSE TestAccCodeBuildProject_Artifacts_name
=== RUN   TestAccCodeBuildProject_Artifacts_namespaceType
=== PAUSE TestAccCodeBuildProject_Artifacts_namespaceType
=== RUN   TestAccCodeBuildProject_Artifacts_overrideArtifactName
=== PAUSE TestAccCodeBuildProject_Artifacts_overrideArtifactName
=== RUN   TestAccCodeBuildProject_Artifacts_packaging
=== PAUSE TestAccCodeBuildProject_Artifacts_packaging
=== RUN   TestAccCodeBuildProject_Artifacts_path
=== PAUSE TestAccCodeBuildProject_Artifacts_path
=== RUN   TestAccCodeBuildProject_Artifacts_type
=== PAUSE TestAccCodeBuildProject_Artifacts_type
=== RUN   TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== PAUSE TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== RUN   TestAccCodeBuildProject_secondaryArtifacts
=== PAUSE TestAccCodeBuildProject_secondaryArtifacts
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_location
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_location
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_name
    acctest.go:93: Currently no solution to allow updates on name attribute
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_name (0.00s)
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_path
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_path
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_packaging
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_packaging
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_type
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_type
=== RUN   TestAccCodeBuildProject_SecondarySources_codeCommit
=== PAUSE TestAccCodeBuildProject_SecondarySources_codeCommit
=== RUN   TestAccCodeBuildProject_concurrentBuildLimit
=== PAUSE TestAccCodeBuildProject_concurrentBuildLimit
=== CONT  TestAccCodeBuildProject_basic
=== CONT  TestAccCodeBuildProject_SecondarySources_codeCommit
=== NAME  TestAccCodeBuildProject_basic
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_basic (0.86s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (BITBUCKET) not found
--- SKIP: TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket (0.18s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_type
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_type (25.55s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_packaging
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_packaging (0.18s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_path
--- PASS: TestAccCodeBuildProject_SecondarySources_codeCommit (26.90s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_path
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_path (0.18s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_location
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_namespaceType (0.19s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_location
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_location (0.20s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled (0.19s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName (0.18s)
=== CONT  TestAccCodeBuildProject_secondaryArtifacts
=== NAME  TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier (0.19s)
=== CONT  TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== NAME  TestAccCodeBuildProject_secondaryArtifacts
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_secondaryArtifacts (0.18s)
=== CONT  TestAccCodeBuildProject_Artifacts_type
--- PASS: TestAccCodeBuildProject_Artifacts_type (45.61s)
=== CONT  TestAccCodeBuildProject_Artifacts_path
--- PASS: TestAccCodeBuildProject_Artifacts_bucketOwnerAccess (45.65s)
=== CONT  TestAccCodeBuildProject_Artifacts_packaging
=== NAME  TestAccCodeBuildProject_Artifacts_path
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_path (0.19s)
=== CONT  TestAccCodeBuildProject_Artifacts_overrideArtifactName
=== NAME  TestAccCodeBuildProject_Artifacts_packaging
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_packaging (0.18s)
=== CONT  TestAccCodeBuildProject_Artifacts_namespaceType
=== NAME  TestAccCodeBuildProject_Artifacts_overrideArtifactName
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_overrideArtifactName (0.19s)
=== CONT  TestAccCodeBuildProject_Artifacts_name
=== NAME  TestAccCodeBuildProject_Artifacts_namespaceType
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_namespaceType (0.19s)
=== CONT  TestAccCodeBuildProject_Artifacts_location
=== NAME  TestAccCodeBuildProject_Artifacts_name
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_name (0.18s)
=== CONT  TestAccCodeBuildProject_Artifacts_encryptionDisabled
=== NAME  TestAccCodeBuildProject_Artifacts_location
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_location (0.18s)
=== CONT  TestAccCodeBuildProject_Artifacts_artifactIdentifier
=== NAME  TestAccCodeBuildProject_Artifacts_encryptionDisabled
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_encryptionDisabled (0.19s)
=== CONT  TestAccCodeBuildProject_linuxLambdaContainer
=== NAME  TestAccCodeBuildProject_Artifacts_artifactIdentifier
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_artifactIdentifier (0.19s)
=== CONT  TestAccCodeBuildProject_armContainer
=== NAME  TestAccCodeBuildProject_linuxLambdaContainer
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_linuxLambdaContainer (0.19s)
=== CONT  TestAccCodeBuildProject_windowsServer2019Container
=== NAME  TestAccCodeBuildProject_armContainer
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_armContainer (0.19s)
=== CONT  TestAccCodeBuildProject_vpc
=== NAME  TestAccCodeBuildProject_windowsServer2019Container
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_windowsServer2019Container (0.19s)
=== CONT  TestAccCodeBuildProject_SourceType_noSourceInvalid
=== NAME  TestAccCodeBuildProject_vpc
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_vpc (0.19s)
=== CONT  TestAccCodeBuildProject_SourceType_noSource
--- PASS: TestAccCodeBuildProject_SourceType_noSourceInvalid (13.34s)
=== CONT  TestAccCodeBuildProject_SourceType_s3
--- PASS: TestAccCodeBuildProject_SourceType_noSource (29.19s)
=== CONT  TestAccCodeBuildProject_SourceType_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SourceType_gitHubEnterprise (0.19s)
=== CONT  TestAccCodeBuildProject_SourceType_codePipeline
--- PASS: TestAccCodeBuildProject_SourceType_s3 (29.29s)
=== CONT  TestAccCodeBuildProject_SourceType_codeCommit
--- PASS: TestAccCodeBuildProject_SourceType_codePipeline (29.79s)
=== CONT  TestAccCodeBuildProject_SourceType_bitbucket
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (BITBUCKET) not found
--- SKIP: TestAccCodeBuildProject_SourceType_bitbucket (0.18s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SourceReportBuildStatus_gitHub (0.18s)
=== CONT  TestAccCodeBuildProject_Environment_registryCredential
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Environment_registryCredential (0.20s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise (0.17s)
=== CONT  TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise (0.18s)
=== CONT  TestAccCodeBuildProject_Source_insecureSSL
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Source_insecureSSL (0.18s)
=== CONT  TestAccCodeBuildProject_concurrentBuildLimit
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_concurrentBuildLimit (0.18s)
=== CONT  TestAccCodeBuildProject_description
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_description (0.20s)
=== CONT  TestAccCodeBuildProject_Environment_certificate
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Environment_certificate (0.19s)
=== CONT  TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value (0.19s)
=== CONT  TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type (0.19s)
=== CONT  TestAccCodeBuildProject_Environment_environmentVariable
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Environment_environmentVariable (0.18s)
=== CONT  TestAccCodeBuildProject_encryptionKey
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_encryptionKey (0.18s)
=== CONT  TestAccCodeBuildProject_sourceVersion
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_sourceVersion (0.18s)
=== CONT  TestAccCodeBuildProject_fileSystemLocations
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_fileSystemLocations (0.18s)
=== CONT  TestAccCodeBuildProject_badgeEnabled
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_badgeEnabled (0.18s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesVersions
--- PASS: TestAccCodeBuildProject_SourceType_codeCommit (29.71s)
=== CONT  TestAccCodeBuildProject_cache
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_cache (0.18s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise (0.19s)
=== CONT  TestAccCodeBuildProject_queuedTimeout
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_queuedTimeout (0.18s)
=== CONT  TestAccCodeBuildProject_buildTimeout
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_buildTimeout (0.18s)
=== CONT  TestAccCodeBuildProject_tags
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_tags (0.18s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub (0.19s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
--- PASS: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit (52.04s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise (0.19s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_gitHub
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SourceGitSubmodules_gitHub (0.18s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
--- PASS: TestAccCodeBuildProject_SecondarySourcesVersions (64.28s)
=== CONT  TestAccCodeBuildProject_publicVisibility
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_publicVisibility (0.17s)
=== CONT  TestAccCodeBuildProject_Source_gitCloneDepth
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Source_gitCloneDepth (0.43s)
=== CONT  TestAccCodeBuildProject_buildBatchConfigDelete
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_buildBatchConfigDelete (0.18s)
=== CONT  TestAccCodeBuildProject_Logs_s3Logs
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Logs_s3Logs (0.18s)
=== CONT  TestAccCodeBuildProject_Logs_cloudWatchLogs
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Logs_cloudWatchLogs (0.17s)
=== CONT  TestAccCodeBuildProject_buildBatch
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_buildBatch (0.18s)
=== CONT  TestAccCodeBuildProject_disappears
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_disappears (0.18s)
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_codeCommit (39.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	250.741s
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. and removed size/M Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. labels Jan 23, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCodeBuildReportGroup_' PKG=codebuild ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 2  -run=TestAccCodeBuildReportGroup_ -timeout 360m
=== RUN   TestAccCodeBuildReportGroup_basic
=== PAUSE TestAccCodeBuildReportGroup_basic
=== RUN   TestAccCodeBuildReportGroup_Export_s3
=== PAUSE TestAccCodeBuildReportGroup_Export_s3
=== RUN   TestAccCodeBuildReportGroup_tags
=== PAUSE TestAccCodeBuildReportGroup_tags
=== RUN   TestAccCodeBuildReportGroup_deleteReports
=== PAUSE TestAccCodeBuildReportGroup_deleteReports
=== RUN   TestAccCodeBuildReportGroup_disappears
=== PAUSE TestAccCodeBuildReportGroup_disappears
=== CONT  TestAccCodeBuildReportGroup_basic
=== CONT  TestAccCodeBuildReportGroup_deleteReports
--- PASS: TestAccCodeBuildReportGroup_deleteReports (21.77s)
=== CONT  TestAccCodeBuildReportGroup_disappears
--- PASS: TestAccCodeBuildReportGroup_basic (21.78s)
=== CONT  TestAccCodeBuildReportGroup_tags
--- PASS: TestAccCodeBuildReportGroup_disappears (16.08s)
=== CONT  TestAccCodeBuildReportGroup_Export_s3
--- PASS: TestAccCodeBuildReportGroup_tags (40.81s)
--- PASS: TestAccCodeBuildReportGroup_Export_s3 (39.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	87.105s
% make testacc TESTARGS='-run=TestAccCodeBuildResourcePolicy_' PKG=codebuild ACCTEST_PARALLELISM=2    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 2  -run=TestAccCodeBuildResourcePolicy_ -timeout 360m
=== RUN   TestAccCodeBuildResourcePolicy_basic
=== PAUSE TestAccCodeBuildResourcePolicy_basic
=== RUN   TestAccCodeBuildResourcePolicy_disappears
=== PAUSE TestAccCodeBuildResourcePolicy_disappears
=== RUN   TestAccCodeBuildResourcePolicy_Disappears_resource
=== PAUSE TestAccCodeBuildResourcePolicy_Disappears_resource
=== CONT  TestAccCodeBuildResourcePolicy_basic
=== CONT  TestAccCodeBuildResourcePolicy_Disappears_resource
--- PASS: TestAccCodeBuildResourcePolicy_Disappears_resource (18.70s)
=== CONT  TestAccCodeBuildResourcePolicy_disappears
--- PASS: TestAccCodeBuildResourcePolicy_basic (21.39s)
--- PASS: TestAccCodeBuildResourcePolicy_disappears (16.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	45.931s
% make testacc TESTARGS='-run=TestAccCodeBuildSourceCredential_' PKG=codebuild ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 2  -run=TestAccCodeBuildSourceCredential_ -timeout 360m
=== RUN   TestAccCodeBuildSourceCredential_basic
=== PAUSE TestAccCodeBuildSourceCredential_basic
=== RUN   TestAccCodeBuildSourceCredential_basicAuth
=== PAUSE TestAccCodeBuildSourceCredential_basicAuth
=== RUN   TestAccCodeBuildSourceCredential_disappears
=== PAUSE TestAccCodeBuildSourceCredential_disappears
=== CONT  TestAccCodeBuildSourceCredential_basic
=== CONT  TestAccCodeBuildSourceCredential_disappears
--- PASS: TestAccCodeBuildSourceCredential_disappears (17.32s)
=== CONT  TestAccCodeBuildSourceCredential_basicAuth
--- PASS: TestAccCodeBuildSourceCredential_basic (31.59s)
--- PASS: TestAccCodeBuildSourceCredential_basicAuth (29.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	57.121s
% AWS_CODEBUILD_GITHUB_SOURCE_LOCATION=https://github.com/ewbankkit/terraform-aws-provider-codebuild-test.git make testacc TESTARGS='-run=TestAccCodeBuildWebhook_' PKG=codebuild ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 2  -run=TestAccCodeBuildWebhook_ -timeout 360m
=== RUN   TestAccCodeBuildWebhook_bitbucket
=== PAUSE TestAccCodeBuildWebhook_bitbucket
=== RUN   TestAccCodeBuildWebhook_gitHub
=== PAUSE TestAccCodeBuildWebhook_gitHub
=== RUN   TestAccCodeBuildWebhook_gitHubEnterprise
=== PAUSE TestAccCodeBuildWebhook_gitHubEnterprise
=== RUN   TestAccCodeBuildWebhook_buildType
=== PAUSE TestAccCodeBuildWebhook_buildType
=== RUN   TestAccCodeBuildWebhook_branchFilter
=== PAUSE TestAccCodeBuildWebhook_branchFilter
=== RUN   TestAccCodeBuildWebhook_filterGroup
=== PAUSE TestAccCodeBuildWebhook_filterGroup
=== RUN   TestAccCodeBuildWebhook_disappears
=== PAUSE TestAccCodeBuildWebhook_disappears
=== RUN   TestAccCodeBuildWebhook_Disappears_project
=== PAUSE TestAccCodeBuildWebhook_Disappears_project
=== CONT  TestAccCodeBuildWebhook_bitbucket
=== CONT  TestAccCodeBuildWebhook_branchFilter
=== NAME  TestAccCodeBuildWebhook_bitbucket
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (BITBUCKET) not found
--- SKIP: TestAccCodeBuildWebhook_bitbucket (0.82s)
=== CONT  TestAccCodeBuildWebhook_disappears
--- PASS: TestAccCodeBuildWebhook_disappears (26.65s)
=== CONT  TestAccCodeBuildWebhook_Disappears_project
--- PASS: TestAccCodeBuildWebhook_branchFilter (42.50s)
=== CONT  TestAccCodeBuildWebhook_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildWebhook_gitHubEnterprise (0.18s)
=== CONT  TestAccCodeBuildWebhook_buildType
--- PASS: TestAccCodeBuildWebhook_Disappears_project (27.16s)
=== CONT  TestAccCodeBuildWebhook_gitHub
--- PASS: TestAccCodeBuildWebhook_gitHub (30.40s)
=== CONT  TestAccCodeBuildWebhook_filterGroup
--- PASS: TestAccCodeBuildWebhook_buildType (59.42s)
--- PASS: TestAccCodeBuildWebhook_filterGroup (31.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	113.196s
% AWS_CODEBUILD_GITHUB_SOURCE_LOCATION=https://github.com/ewbankkit/terraform-aws-provider-codebuild-test.git make testacc TESTARGS='-run=TestAccCodeBuildProject_' PKG=codebuild ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 2  -run=TestAccCodeBuildProject_ -timeout 360m
=== RUN   TestAccCodeBuildProject_basic
=== PAUSE TestAccCodeBuildProject_basic
=== RUN   TestAccCodeBuildProject_disappears
=== PAUSE TestAccCodeBuildProject_disappears
=== RUN   TestAccCodeBuildProject_tags
=== PAUSE TestAccCodeBuildProject_tags
=== RUN   TestAccCodeBuildProject_publicVisibility
=== PAUSE TestAccCodeBuildProject_publicVisibility
=== RUN   TestAccCodeBuildProject_badgeEnabled
=== PAUSE TestAccCodeBuildProject_badgeEnabled
=== RUN   TestAccCodeBuildProject_buildTimeout
=== PAUSE TestAccCodeBuildProject_buildTimeout
=== RUN   TestAccCodeBuildProject_queuedTimeout
=== PAUSE TestAccCodeBuildProject_queuedTimeout
=== RUN   TestAccCodeBuildProject_cache
=== PAUSE TestAccCodeBuildProject_cache
=== RUN   TestAccCodeBuildProject_description
=== PAUSE TestAccCodeBuildProject_description
=== RUN   TestAccCodeBuildProject_fileSystemLocations
=== PAUSE TestAccCodeBuildProject_fileSystemLocations
=== RUN   TestAccCodeBuildProject_sourceVersion
=== PAUSE TestAccCodeBuildProject_sourceVersion
=== RUN   TestAccCodeBuildProject_encryptionKey
=== PAUSE TestAccCodeBuildProject_encryptionKey
=== RUN   TestAccCodeBuildProject_Environment_environmentVariable
=== PAUSE TestAccCodeBuildProject_Environment_environmentVariable
=== RUN   TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
=== PAUSE TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
=== RUN   TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
=== PAUSE TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
=== RUN   TestAccCodeBuildProject_Environment_certificate
=== PAUSE TestAccCodeBuildProject_Environment_certificate
=== RUN   TestAccCodeBuildProject_Environment_registryCredential
=== PAUSE TestAccCodeBuildProject_Environment_registryCredential
=== RUN   TestAccCodeBuildProject_Logs_cloudWatchLogs
=== PAUSE TestAccCodeBuildProject_Logs_cloudWatchLogs
=== RUN   TestAccCodeBuildProject_Logs_s3Logs
=== PAUSE TestAccCodeBuildProject_Logs_s3Logs
=== RUN   TestAccCodeBuildProject_buildBatch
=== PAUSE TestAccCodeBuildProject_buildBatch
=== RUN   TestAccCodeBuildProject_buildBatchConfigDelete
=== PAUSE TestAccCodeBuildProject_buildBatchConfigDelete
=== RUN   TestAccCodeBuildProject_Source_gitCloneDepth
=== PAUSE TestAccCodeBuildProject_Source_gitCloneDepth
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_gitHub
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_gitHub
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SecondarySourcesVersions
=== PAUSE TestAccCodeBuildProject_SecondarySourcesVersions
=== RUN   TestAccCodeBuildProject_Source_insecureSSL
=== PAUSE TestAccCodeBuildProject_Source_insecureSSL
=== RUN   TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
=== RUN   TestAccCodeBuildProject_SourceType_bitbucket
=== PAUSE TestAccCodeBuildProject_SourceType_bitbucket
=== RUN   TestAccCodeBuildProject_SourceType_codeCommit
=== PAUSE TestAccCodeBuildProject_SourceType_codeCommit
=== RUN   TestAccCodeBuildProject_SourceType_codePipeline
=== PAUSE TestAccCodeBuildProject_SourceType_codePipeline
=== RUN   TestAccCodeBuildProject_SourceType_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceType_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceType_s3
=== PAUSE TestAccCodeBuildProject_SourceType_s3
=== RUN   TestAccCodeBuildProject_SourceType_noSource
=== PAUSE TestAccCodeBuildProject_SourceType_noSource
=== RUN   TestAccCodeBuildProject_SourceType_noSourceInvalid
=== PAUSE TestAccCodeBuildProject_SourceType_noSourceInvalid
=== RUN   TestAccCodeBuildProject_vpc
=== PAUSE TestAccCodeBuildProject_vpc
=== RUN   TestAccCodeBuildProject_windowsServer2019Container
=== PAUSE TestAccCodeBuildProject_windowsServer2019Container
=== RUN   TestAccCodeBuildProject_armContainer
=== PAUSE TestAccCodeBuildProject_armContainer
=== RUN   TestAccCodeBuildProject_linuxLambdaContainer
=== PAUSE TestAccCodeBuildProject_linuxLambdaContainer
=== RUN   TestAccCodeBuildProject_Artifacts_artifactIdentifier
=== PAUSE TestAccCodeBuildProject_Artifacts_artifactIdentifier
=== RUN   TestAccCodeBuildProject_Artifacts_encryptionDisabled
=== PAUSE TestAccCodeBuildProject_Artifacts_encryptionDisabled
=== RUN   TestAccCodeBuildProject_Artifacts_location
=== PAUSE TestAccCodeBuildProject_Artifacts_location
=== RUN   TestAccCodeBuildProject_Artifacts_name
=== PAUSE TestAccCodeBuildProject_Artifacts_name
=== RUN   TestAccCodeBuildProject_Artifacts_namespaceType
=== PAUSE TestAccCodeBuildProject_Artifacts_namespaceType
=== RUN   TestAccCodeBuildProject_Artifacts_overrideArtifactName
=== PAUSE TestAccCodeBuildProject_Artifacts_overrideArtifactName
=== RUN   TestAccCodeBuildProject_Artifacts_packaging
=== PAUSE TestAccCodeBuildProject_Artifacts_packaging
=== RUN   TestAccCodeBuildProject_Artifacts_path
=== PAUSE TestAccCodeBuildProject_Artifacts_path
=== RUN   TestAccCodeBuildProject_Artifacts_type
=== PAUSE TestAccCodeBuildProject_Artifacts_type
=== RUN   TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== PAUSE TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== RUN   TestAccCodeBuildProject_secondaryArtifacts
=== PAUSE TestAccCodeBuildProject_secondaryArtifacts
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_location
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_location
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_name
    acctest.go:93: Currently no solution to allow updates on name attribute
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_name (0.00s)
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_path
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_path
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_packaging
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_packaging
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_type
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_type
=== RUN   TestAccCodeBuildProject_SecondarySources_codeCommit
=== PAUSE TestAccCodeBuildProject_SecondarySources_codeCommit
=== RUN   TestAccCodeBuildProject_concurrentBuildLimit
=== PAUSE TestAccCodeBuildProject_concurrentBuildLimit
=== CONT  TestAccCodeBuildProject_basic
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
--- PASS: TestAccCodeBuildProject_basic (28.62s)
=== CONT  TestAccCodeBuildProject_Logs_cloudWatchLogs
--- PASS: TestAccCodeBuildProject_SourceReportBuildStatus_gitHub (41.56s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (BITBUCKET) not found
--- SKIP: TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket (0.19s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise (0.19s)
=== CONT  TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise (0.19s)
=== CONT  TestAccCodeBuildProject_Source_insecureSSL
--- PASS: TestAccCodeBuildProject_Logs_cloudWatchLogs (53.35s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesVersions
--- PASS: TestAccCodeBuildProject_Source_insecureSSL (42.26s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise (0.18s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
--- PASS: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub (37.68s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
--- PASS: TestAccCodeBuildProject_SecondarySourcesVersions (62.66s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise (0.19s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_gitHub
--- PASS: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit (50.45s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_gitHub (41.90s)
=== CONT  TestAccCodeBuildProject_Source_gitCloneDepth
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_codeCommit (45.11s)
=== CONT  TestAccCodeBuildProject_buildBatchConfigDelete
--- PASS: TestAccCodeBuildProject_Source_gitCloneDepth (46.18s)
=== CONT  TestAccCodeBuildProject_buildBatch
--- PASS: TestAccCodeBuildProject_buildBatchConfigDelete (47.24s)
=== CONT  TestAccCodeBuildProject_Logs_s3Logs
--- PASS: TestAccCodeBuildProject_buildBatch (47.18s)
=== CONT  TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
--- PASS: TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type (57.27s)
=== CONT  TestAccCodeBuildProject_Environment_registryCredential
--- PASS: TestAccCodeBuildProject_Logs_s3Logs (64.29s)
=== CONT  TestAccCodeBuildProject_Environment_certificate
--- PASS: TestAccCodeBuildProject_Environment_certificate (31.07s)
=== CONT  TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
--- PASS: TestAccCodeBuildProject_Environment_registryCredential (46.70s)
=== CONT  TestAccCodeBuildProject_buildTimeout
--- PASS: TestAccCodeBuildProject_buildTimeout (43.79s)
=== CONT  TestAccCodeBuildProject_description
--- PASS: TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value (63.39s)
=== CONT  TestAccCodeBuildProject_cache
--- PASS: TestAccCodeBuildProject_description (41.44s)
=== CONT  TestAccCodeBuildProject_queuedTimeout
--- PASS: TestAccCodeBuildProject_queuedTimeout (42.36s)
=== CONT  TestAccCodeBuildProject_encryptionKey
--- PASS: TestAccCodeBuildProject_encryptionKey (30.79s)
=== CONT  TestAccCodeBuildProject_Environment_environmentVariable
--- PASS: TestAccCodeBuildProject_cache (122.57s)
=== CONT  TestAccCodeBuildProject_fileSystemLocations
--- PASS: TestAccCodeBuildProject_Environment_environmentVariable (60.07s)
=== CONT  TestAccCodeBuildProject_sourceVersion
--- PASS: TestAccCodeBuildProject_sourceVersion (24.47s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled (41.73s)
=== CONT  TestAccCodeBuildProject_Artifacts_overrideArtifactName
--- PASS: TestAccCodeBuildProject_Artifacts_overrideArtifactName (44.49s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName (41.15s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
--- PASS: TestAccCodeBuildProject_fileSystemLocations (200.59s)
=== CONT  TestAccCodeBuildProject_secondaryArtifacts
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier (53.03s)
=== CONT  TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
--- PASS: TestAccCodeBuildProject_secondaryArtifacts (43.62s)
=== CONT  TestAccCodeBuildProject_Artifacts_type
--- PASS: TestAccCodeBuildProject_Artifacts_bucketOwnerAccess (44.08s)
=== CONT  TestAccCodeBuildProject_Artifacts_path
--- PASS: TestAccCodeBuildProject_Artifacts_type (44.48s)
=== CONT  TestAccCodeBuildProject_Artifacts_packaging
--- PASS: TestAccCodeBuildProject_Artifacts_path (48.05s)
=== CONT  TestAccCodeBuildProject_windowsServer2019Container
--- PASS: TestAccCodeBuildProject_Artifacts_packaging (48.82s)
=== CONT  TestAccCodeBuildProject_concurrentBuildLimit
--- PASS: TestAccCodeBuildProject_windowsServer2019Container (29.98s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_path
--- PASS: TestAccCodeBuildProject_concurrentBuildLimit (42.77s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_path (41.66s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_location
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_namespaceType (43.64s)
=== CONT  TestAccCodeBuildProject_SecondarySources_codeCommit
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_location (44.47s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_packaging
--- PASS: TestAccCodeBuildProject_SecondarySources_codeCommit (26.73s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_type
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_packaging (43.61s)
=== CONT  TestAccCodeBuildProject_publicVisibility
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_type (25.43s)
=== CONT  TestAccCodeBuildProject_tags
--- PASS: TestAccCodeBuildProject_publicVisibility (55.56s)
=== CONT  TestAccCodeBuildProject_badgeEnabled
--- PASS: TestAccCodeBuildProject_tags (55.47s)
=== CONT  TestAccCodeBuildProject_Artifacts_encryptionDisabled
--- PASS: TestAccCodeBuildProject_badgeEnabled (35.44s)
=== CONT  TestAccCodeBuildProject_Artifacts_name
--- PASS: TestAccCodeBuildProject_Artifacts_encryptionDisabled (54.34s)
=== CONT  TestAccCodeBuildProject_Artifacts_location
--- PASS: TestAccCodeBuildProject_Artifacts_name (50.39s)
=== CONT  TestAccCodeBuildProject_linuxLambdaContainer
--- PASS: TestAccCodeBuildProject_Artifacts_location (49.98s)
=== CONT  TestAccCodeBuildProject_disappears
--- PASS: TestAccCodeBuildProject_linuxLambdaContainer (29.96s)
=== CONT  TestAccCodeBuildProject_Artifacts_namespaceType
--- PASS: TestAccCodeBuildProject_disappears (26.94s)
=== CONT  TestAccCodeBuildProject_armContainer
--- PASS: TestAccCodeBuildProject_Artifacts_namespaceType (46.12s)
=== CONT  TestAccCodeBuildProject_SourceType_s3
--- PASS: TestAccCodeBuildProject_armContainer (30.00s)
=== CONT  TestAccCodeBuildProject_vpc
--- PASS: TestAccCodeBuildProject_vpc (60.88s)
=== CONT  TestAccCodeBuildProject_SourceType_codePipeline
--- PASS: TestAccCodeBuildProject_SourceType_s3 (29.31s)
=== CONT  TestAccCodeBuildProject_SourceType_noSourceInvalid
--- PASS: TestAccCodeBuildProject_SourceType_noSourceInvalid (13.24s)
=== CONT  TestAccCodeBuildProject_SourceType_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SourceType_gitHubEnterprise (0.19s)
=== CONT  TestAccCodeBuildProject_SourceType_codeCommit
--- PASS: TestAccCodeBuildProject_SourceType_codePipeline (28.80s)
=== CONT  TestAccCodeBuildProject_SourceType_bitbucket
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (BITBUCKET) not found
--- SKIP: TestAccCodeBuildProject_SourceType_bitbucket (0.20s)
=== CONT  TestAccCodeBuildProject_Artifacts_artifactIdentifier
--- PASS: TestAccCodeBuildProject_SourceType_codeCommit (28.90s)
=== CONT  TestAccCodeBuildProject_SourceType_noSource
--- PASS: TestAccCodeBuildProject_Artifacts_artifactIdentifier (44.83s)
--- PASS: TestAccCodeBuildProject_SourceType_noSource (29.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	1300.819s

@ewbankkit ewbankkit merged commit a2a325c into hashicorp:main Jan 23, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.34.0 milestone Jan 23, 2024
Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
@digglife digglife deleted the f-build_batch_config_delete branch July 13, 2024 06:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/codebuild Issues and PRs that pertain to the codebuild service. size/M Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
5 participants