Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_lambda_function: Add vpc_config.ipv6_allowed_for_dual_stack attribute #34134

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 27, 2023

Description

Adds the vpc_config.ipv6_allowed_for_dual_stack attribute, matching the aws_lambda_function resource.

Relations

Closes #34131.
Relates #34045.

Output from Acceptance Testing

Before

% make testacc TESTARGS='-run=TestAccLambdaFunctionDataSource_vpc$$' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaFunctionDataSource_vpc$ -timeout 360m
=== RUN   TestAccLambdaFunctionDataSource_vpc
=== PAUSE TestAccLambdaFunctionDataSource_vpc
=== CONT  TestAccLambdaFunctionDataSource_vpc
panic: Invalid address to set: []string{"vpc_config", "0", "ipv6_allowed_for_dual_stack"}

goroutine 1934 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc0001f0880, {0xec203cf, 0xa}, {0xc5c7ea0, 0xc002115470})
        /Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.29.0/helper/schema/resource_data.go:233 +0x291
github.com/hashicorp/terraform-provider-aws/internal/service/lambda.dataSourceFunctionRead({0xfffcee0, 0xc0018224e0}, 0xc0001f0880, {0xeba7520?, 0xc004692690})
        /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/service/lambda/function_data_source.go:321 +0x1cd2
github.com/hashicorp/terraform-provider-aws/internal/provider.interceptedHandler[...].func1(0x0?, {0xeba7520?, 0xc004692690?})
        /Users/ewbankkit/altsrc.1/github.com/terraform-providers/terraform-provider-aws/internal/provider/intercept.go:111 +0x34b
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xfffcee0?, {0xfffcee0?, 0xc000ff6d20?}, 0xd?, {0xeba7520?, 0xc004692690?})
        /Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.29.0/helper/schema/resource.go:790 +0x87
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0xc004dc77a0, {0xfffcee0, 0xc000ff6d20}, 0xc0001f0480, {0xeba7520, 0xc004692690})
        /Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.29.0/helper/schema/resource.go:1015 +0x150
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadDataSource(0xc0067c5ef0, {0xfffcee0?, 0xc000be5e90?}, 0xc0052f2080)
        /Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.29.0/helper/schema/grpc_provider.go:1237 +0x38f
github.com/hashicorp/terraform-plugin-mux/tf5muxserver.(*muxServer).ReadDataSource(0xfffce38?, {0xfffcee0?, 0xc000be5bc0?}, 0xc0052f2080)
        /Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-mux@v0.12.0/tf5muxserver/mux_server_ReadDataSource.go:36 +0x1b5
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ReadDataSource(0xc004bd83c0, {0xfffcee0?, 0xc000be5410?}, 0xc0001bc320)
        /Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.19.0/tfprotov5/tf5server/server.go:699 +0x403
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadDataSource_Handler({0xe926400?, 0xc004bd83c0}, {0xfffcee0, 0xc000be5410}, 0xc0004fc070, 0x0)
        /Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.19.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:503 +0x170
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0026903c0, {0x1000ab20, 0xc00656c340}, 0xc001ef4ea0, 0xc00654e4e0, 0x16642f68, 0x0)
        /Users/ewbankkit/go/pkg/mod/google.golang.org/grpc@v1.58.2/server.go:1376 +0xdd2
google.golang.org/grpc.(*Server).handleStream(0xc0026903c0, {0x1000ab20, 0xc00656c340}, 0xc001ef4ea0, 0x0)
        /Users/ewbankkit/go/pkg/mod/google.golang.org/grpc@v1.58.2/server.go:1753 +0xa36
google.golang.org/grpc.(*Server).serveStreams.func1.1()
        /Users/ewbankkit/go/pkg/mod/google.golang.org/grpc@v1.58.2/server.go:998 +0x98
created by google.golang.org/grpc.(*Server).serveStreams.func1
        /Users/ewbankkit/go/pkg/mod/google.golang.org/grpc@v1.58.2/server.go:996 +0x18c
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/lambda     214.807s
FAIL
make: *** [testacc] Error 1

After

% make testacc TESTARGS='-run=TestAccLambdaFunctionDataSource_vpc$$' PKG=lambda                 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaFunctionDataSource_vpc$ -timeout 360m
=== RUN   TestAccLambdaFunctionDataSource_vpc
=== PAUSE TestAccLambdaFunctionDataSource_vpc
=== CONT  TestAccLambdaFunctionDataSource_vpc
--- PASS: TestAccLambdaFunctionDataSource_vpc (1546.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     1552.076s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. labels Oct 27, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 27, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels Oct 27, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS='-run=TestAccLambdaFunctionDataSource_vpc$$' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaFunctionDataSource_vpc$ -timeout 360m
=== RUN   TestAccLambdaFunctionDataSource_vpc
=== PAUSE TestAccLambdaFunctionDataSource_vpc
=== CONT  TestAccLambdaFunctionDataSource_vpc
--- PASS: TestAccLambdaFunctionDataSource_vpc (702.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     705.900s

@ewbankkit ewbankkit added this to the v5.23.1 milestone Oct 27, 2023
@ewbankkit ewbankkit merged commit 528d9cc into main Oct 27, 2023
75 checks passed
@ewbankkit ewbankkit deleted the b-aws_lambda_function.regression branch October 27, 2023 14:14
github-actions bot pushed a commit that referenced this pull request Oct 27, 2023
@github-actions
Copy link

This functionality has been released in v5.23.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Oct 27, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: d/aws_lambda_function issue in aws provider 5.23.0
3 participants